From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF5F432E6; Fri, 10 Nov 2023 13:36:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BAC54064C; Fri, 10 Nov 2023 13:36:01 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 2127440291 for ; Fri, 10 Nov 2023 13:36:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CN+MTf/xtnKByisx1JZ6WZh76MneqJf/q4FKm5MmbCSFnYWlpMOAj49GGCic1UcfH3HdToL9lrWqvvahE59qJWW87fjwgGGphygnJ5XJxpnbktAalSjYKwowPIxkrPNsMR1y2PM9aXTr/NPuRHlV9fMmcuu+Y7KdbO9Gc3bzUozxBQe43e4qz91GRWEIazr8CfG4P5JNTk/HH/Hs+i0uYUPXoWDejwO4jZy54cOYs9CiX6U+6VB66wlKCXUmCdA3ZuhBtuWIx3OHMhGUBvWiTiExzMkNucRNjGMSnYniVygpfYu59BbEfknzeU2ijhXhtYjAo5IlzES4DQxYor47kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhLqW9rx4JmqPdroOKPkBLsDglZfjtvH46Rd5e8OhpU=; b=GZfnQqRHspsdSsnngGu3yc8GKKOl+07wX1070iesk0/UvlxBORWD1x/XKww/AgsbnIX1xepDhCOSmI6xuX/Oxr6yv/6z1lWy5GYG6J/lUndnczIDmMcnGAsS5PkMSEUi+EQCMdDKWbjwArKz5oRUmJwzz/7IRQxpyXXelw5csjnnoa8fm2cMK9r5h3hwkQeSVkGGCisDu72aeG571zTViBb9uzf0Svj45VWyqQQmQHB+0T1daG1LCe9c7xazXQ2ybT+C0/J17zLovkkArizG+oqGvEHG21YhqDWZrVvDJZuQYGAb7ywadcYRFIhrjuY1QSdMmGwzbsNOnB0EVmMujA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhLqW9rx4JmqPdroOKPkBLsDglZfjtvH46Rd5e8OhpU=; b=rFz0AqQ86fQTVjQ9DZyOzE1dgqveZYfhormEXaonpO0GomLXYFdbli8EYm/gzRknv1uF86cOSLAxzTFVABVtcgb9ascUDWRsYZ1zI8/R+jIzRE8R4A0+I1iUpojZIrqsrLOYC1mqgA/ciKaWEZNGh55XGWHLk7Qg3toTT4A/cOM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB8082.namprd12.prod.outlook.com (2603:10b6:8:e6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Fri, 10 Nov 2023 12:35:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Fri, 10 Nov 2023 12:35:56 +0000 Message-ID: <1a1e6750-f282-43f6-b3dc-159b50b49aab@amd.com> Date: Fri, 10 Nov 2023 12:35:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code To: Jie Hai , dev@dpdk.org References: <20231108034434.559030-1-haijie1@huawei.com> <8107a0ea-016c-088d-edc7-6a619d27da26@huawei.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <8107a0ea-016c-088d-edc7-6a619d27da26@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB8082:EE_ X-MS-Office365-Filtering-Correlation-Id: e8d73099-42b0-40af-2f1b-08dbe1e9960d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z3+I68A392c38HeAzhirkJ/BTtUB+5mgREdt6bDtGqGN2DAGNuDh+lf7XZKahYwQC82fjtVPPxS+ZT35u9P1NyoEAwekKVRow9X1s/sdLJZpp2ESMTW2xAmNHfV8ZG/jnkIiCFeZddrPHz+MXI5H/9g+G3TTs6TyS99vGvGBekc9k86ozTaHPOZK+0b2oAq7aCOSLWvzyCDImq16dIvV2ZyXCjRPh8GYvzODn8KXTu/2iMuNk7uSv7+fIRUBhAuWYCWErQmh55dJ/88ZH8WyZWVFXEkwnBvRzKAMeg1rSUCCnXbT93pz/z3ebziSt4yEzeRBHr6ihqaANCVXAHMtOTs55vQKPK8Q2BCI4Lm4sfBU8FE0TiBSg+YSvzrCal0OVRqQOePpUAXcuTRkXjuP453LiZF7CRtJLBUL6ZGf8vviX3ZuMHwhV9kNwYr1StqmRspeDkmhU1wmbPLR32VmQtDFcalbNu1GYxvz0YEIV1uCSZOH1feiNrEN/skW/EveYlm/nAou8EdtSiDw8oI5jXNMKRnhJStTmYqOQ9KkSuvDUoFp+RCXhE/MDWJahRBt5wGfQVEL1Zl8zZsoeM9EiNLW4W/b+OZHW+i+VwHF4Ng/Kd2xkSM2n+s0TQvYyb2QqO26lnHjHnsb0WXHn79vapYkxwrOAzMak6yrx286g+/cTtw3heRr2RX4a3ZO4hj9cqphxSj0H+8MnX2IIVDCUw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(376002)(346002)(39860400002)(396003)(230922051799003)(230273577357003)(230173577357003)(64100799003)(186009)(1800799009)(451199024)(2906002)(15650500001)(83380400001)(31696002)(86362001)(38100700002)(36756003)(6506007)(8676002)(8936002)(6666004)(53546011)(6512007)(41300700001)(6486002)(478600001)(44832011)(66556008)(316002)(66476007)(66946007)(31686004)(26005)(5660300002)(2616005)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1h6ZTBqUmJoMXhJN3IvSHg3WUs0WjNDM1F5bDJxS2NlMVRFUFdWQ012eUE0?= =?utf-8?B?OGdCNDRQdHlSMTZENkRTUEdKS0NRNWgxV0UydFBvYlFSOUZwbnJyYmtHcnFT?= =?utf-8?B?Z0RKbEpoS2ExdjRXcVNIY0hzUWRnWSs5VEkyWFJLSXZOMGg2WStBQ1lkbkZa?= =?utf-8?B?REsyc2N1bXY1Y2VJN2gwZHZ1Z2N1MWRGSlUvSDdCRkVwTXljbzhXYXRNL1Yv?= =?utf-8?B?Um1LYm02Tk1nRFAvZ1pTOXA2VTFCT05rOVV2WFA2bkdPWjBBNDZoc21iS2FY?= =?utf-8?B?akcydUhVbVFIM1pnK3ZubmJuenBtd0FSbm9uMktGaE82R0M1YlEyK3Vwdnl3?= =?utf-8?B?ZnBmMG13cmlXVVhSQy9Zb3BnbjZ6SFhyTy9MZFE0N3RlN2xLY1VIS2FkbG9h?= =?utf-8?B?VmIrTm9NTlF4Um92YUNiZmZrS3FUUHpoQTFIZHpGc3hoRGNSdzFIUUV4bHZG?= =?utf-8?B?RHpqNnNObFRaeFo4RlRYS1FCMkNBQkdaRjEvUDkvNXQwS3hURWllRnJBcFgz?= =?utf-8?B?WlU5TU5vZjZVbEtMVXVWYnRSaUxmWllNODJKQnlsRTYzcDFjM2ZiYU9BQlhX?= =?utf-8?B?SWhFNTFDcnBpWXlZcTdWUDFGTHZRTWQvNm1ydHhYUE03WFQ3clpjeXhlbFpQ?= =?utf-8?B?dFMzemE2SHErRzdZNHh5TXNSSkhSU21KbVdxSThtbkZtVlZDQUpRRXVTTXRp?= =?utf-8?B?V0VUeTJBT3JNR0JBRHp2dXZJc2xDaFlBUDNJN1F3Z3BTdVVQWFEwUmxpazNS?= =?utf-8?B?QTJRNWsxSCtBWENwTStUVFhpYXNHblQ2WFRERkZaekN2SSs5Uzh6ZGNLNXcy?= =?utf-8?B?SnBRZWdRZDFQT3l0azlUQ1I3MVljczZNdExyRmJPK1dBTFBVaU10a2FGNlkw?= =?utf-8?B?U3U1YUJ3QlpKM0dLL0ZlUWlnMFNXWENZNHFSYnpzQmgreHZuZ0VBQlJaU0FB?= =?utf-8?B?c2NnaHB1dTFvZXRSYXRudTlaMDNRSndMMnlkTHkxM1lhRHlpcThSczlPMlAy?= =?utf-8?B?WG8zT01JdkpBc2lTNjJjZ2dUdzlxTjJ0U0QzMnJhM1dTSmpGUkNCOFZXK0l2?= =?utf-8?B?UmY3YmdUbEE3c2Q2SjVoR2VOR3JqQkVXejVrZWJkcDZNWDBkWENuZWYraGxU?= =?utf-8?B?VlA3RlNSN3hrVXBOSTBmNUtzdVJmaDh0WWV4bFNxNWpvM3JMOEp5c0V0MXRr?= =?utf-8?B?NXNtQVZOZVRUcXFFZEZXMXhEeVFvcUdPSlEvTTgvU045aWd5bThNQ0t1ZHlC?= =?utf-8?B?U29ta1FrQmVqSzhDNTdVMlZ1YlJEd0c0ay83NVFsNGlaT1Q0WXprcXFWQ2RD?= =?utf-8?B?Y3ZYRmZOM1RIRlpGcmZIWFprVEY1QjdoNFkrd1p1dVNyemJxT2ZxOVBKb0Fv?= =?utf-8?B?a2N0MWlEZ3JEbDZGNFFBMUY5MndqbDV3WnFDTUhnOW8vRlcrQTFYYm41VE1l?= =?utf-8?B?RGE5eVVyWlJqK0tRTDZ6WWl4MlVCN0Y1bzVlQWRKR1VRWHNlUkF5d1JZbUFE?= =?utf-8?B?RktpR0xYQ28xSytwKzlEeHhpbmxKNE9PekxEeVpTQmc3M1ZpK2RkZGdZYjB1?= =?utf-8?B?c1h5VTF2YjdESVlTcWpBa2Z5TFhkcmtkSzZFcG9GOUpLVmJWWWxkMHVIcFFX?= =?utf-8?B?WFdEWGR1eDJ3ZmxLdWtvL1lPSlpGempZOVVNR3NSRnBlb0Y3dEppaWVSTU93?= =?utf-8?B?OFlYMldDU0RUN3dIY1cvL3pwUE5IRnFWdE5GditQdU1VMCs4Q21ObjU3dDN6?= =?utf-8?B?ai9vMzlVNTVQZjFGSnlpTkZza2IwUGFzZXNPWlU4NUF1elV2Z3lRc0tBSUhk?= =?utf-8?B?MEEwOGNHWnFWdUx3ck80MVNzVjdzZG1kM29zUGxZbWtLYldzeG9JWjNvcXpw?= =?utf-8?B?KytrMUFVcmYyZzB0TlhWVENDdG85OHh4V0RaL3lNam5jb3V1YTZEQWdlZmU4?= =?utf-8?B?SnFUaWVyRjZpMnV0a2t4Wm1CRiswMmdxZlhWUHl2QmxFUGw2S3ZzZ21ZZHlR?= =?utf-8?B?bUJJTGV1c3o2NWhWcG5KL2ExcHlZWmRoc3dONGJIOFpQNStjNFJFc3hnU1B6?= =?utf-8?B?WEt3bUZqeFdmMm1RVkN4TXJCYWRLSmZUalVzb1hOKytqbkdQMGlNZlAveHdk?= =?utf-8?Q?0yh4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8d73099-42b0-40af-2f1b-08dbe1e9960d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2023 12:35:56.7427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n4h5bhUEYeEqdCaB4IZsqdQ8yQR/8incGsOftFSP8aPsyz99IqqJIivLeO/obTc/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8082 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2023 6:21 AM, Jie Hai wrote: > On 2023/11/10 2:50, Ferruh Yigit wrote: >> On 11/8/2023 3:44 AM, Jie Hai wrote: >>> This patchset fixes failure on sync mailbox and refactors some codes >>> on mailbox. >>> >>> Dengdui Huang (5): >>>    net/hns3: fix sync mailbox failure forever >>>    net/hns3: refactor VF mailbox message struct >>>    net/hns3: refactor PF mailbox message struct >>>    net/hns3: refactor send mailbox function >>>    net/hns3: refactor handle mailbox function >>> >> >> Hi Jie, >> >> Overall patchset looks good with minor issue below [1], but this set has >> high impact and not solving a critical defect etc, but mainly >> refactoring. >> We are very close to the release, there won't be enough time to fix any >> issue caused by this refactoring. >> >> My suggestion is to postpone the refactoring to next release, maybe get >> only the first fix patch in this release, what do you think? >> > I think it's OK. > OK, I will proceed with it, please be sure it is fully verified. >> >> >> [1] >> Can you please fix the checkpatch warning: >> >>   ### [PATCH] net/hns3: refactor handle mailbox function >> >>    Warning in drivers/net/hns3/hns3_mbx.c: >>    Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer >> rte_atomic_xxx/rte_memory_order_xxx >> > Thanks, I'will send V2 with these fixes. >> .