From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3718FA00C5; Thu, 1 Sep 2022 17:03:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ADF340C35; Thu, 1 Sep 2022 17:03:19 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 6349540695 for ; Thu, 1 Sep 2022 17:03:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFGOYwTcgYy1ht4CARojOfG71o5fbM9V3naV1oV8s9A6eSxmwzt9Tqa66SY5lXMRjcEhdQoD+TutBa1rz+ugL2SYKfgvex0p28fw5CxER5KZjZN71ftB2nLyZcpZyd/QqLmoUwG7ugMLODjjR+epXbN9eSYhBRKEu/wKUc2t7uLOyb2mdSs9yyAzRLIFi4biy65dgXZeiqpfzOp4W1HY+jH+jvP2kq/tvGfHMXbJaI0rdPpHhkZus0tnkamrDZBxcGW1UegRupZsEW+A/TrMiLXbKJNH3XZIou67baHtOoGsLxjaqoewN1sViKAxsWYHt/kfJ4b3LlsIQPB6SgOb1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xVepXglkRmwbBFBtlDGJQA194rT/oWBAeHrzev8RN5Y=; b=aRj/c1f2JdBkkshiIFVHAlytz0SjtpMVRxrHVF612ePidES0TReQLdZelevhlzcrI7D7SeIelgnIm1fnSi/yfhvUsAzsp5JGepD4a1xrKZinxWjyP5D5xh/rdj9dBD3Klv0bM8SsczgLUAo6D/PhlUfP6PGYCArhJFkkEI5Ix1bpoUkG+9OQLzR2McGdrTVzdErvUbws+Kqz9xLF0zrNzMvs2Ayn82/aT/nKH3LGbre0qrSMp48R2q2jVKPrZL1ZvIwHqQwQ+4yXO+3Tkb7hclrdCnYqwwqpcQapZF8G5YT9f+UTRfTPoFsGPzQRBvrDb9BeBtJ93RjFNztMeQfa4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=amd.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xVepXglkRmwbBFBtlDGJQA194rT/oWBAeHrzev8RN5Y=; b=R5pxCjhDZJ3pSrjVK6uexNOl3XkzIaNKHhE9xtZYRgkHg4w0Xovmz5obomz8S1aKUaZ5JPo7GvQDBH8jgb4KRjsAjDFBhobtQeZcspRvu9cT8NQ/KXVquydBKOF3XAv/omwBf1C2dbaaa7z2Xz/76ONPP8/c+P2FhVSWogjgf6Q= Received: from DM6PR06CA0093.namprd06.prod.outlook.com (2603:10b6:5:336::26) by BN6PR02MB2737.namprd02.prod.outlook.com (2603:10b6:404:fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 15:03:07 +0000 Received: from DM3NAM02FT017.eop-nam02.prod.protection.outlook.com (2603:10b6:5:336:cafe::8b) by DM6PR06CA0093.outlook.office365.com (2603:10b6:5:336::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:03:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT017.mail.protection.outlook.com (10.13.5.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 15:03:06 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 16:03:05 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 1 Sep 2022 16:03:05 +0100 Envelope-to: chandu@amd.com, bhagyada.modali@amd.com, dev@dpdk.org Received: from [10.71.194.74] (port=49694) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oTlij-0002Nv-LI; Thu, 01 Sep 2022 16:03:05 +0100 Message-ID: <1a468c8e-a612-4191-3615-0fbd1f0b04a2@xilinx.com> Date: Thu, 1 Sep 2022 16:03:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 1/4] net/axgbe: fix scattered Rx Content-Language: en-US To: , Bhagyada Modali CC: References: <20220901053311.92964-1-bhagyada.modali@amd.com> <20220901124948.97063-1-bhagyada.modali@amd.com> From: Ferruh Yigit In-Reply-To: <20220901124948.97063-1-bhagyada.modali@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b1108fe-ce69-4024-6a61-08da8c2b13e4 X-MS-TrafficTypeDiagnostic: BN6PR02MB2737:EE_ X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wzl+wrSMu28/adgye7G6OdGVXvTv3Y0zAYlSfkHpXkt0jbBx+diZ1jHVmh/f4YULpt+SuFbpJBdkS/UbPPIRcJrXIs71ufaw7ClzlXe/kYQh/sqzL872KNRDq2q01wpKD2+SL0mV5Jyxfnq5XqezMJA1TcfNcHJqHVdQfwNSDEJ1tDFEMcgzwbxT/BoAFUbzPx5riJvB7yp+L6dh+MLdmFv+KA6xRgrssb+uZB2ShtfeyFWC/tRI7PnWNl0VQKcYovnAVieY7fmPKHhtfUHQvAVJzCBXLEomFYHAgUWo204aYrycnhMExRJWPZD7n6YuOfQiujYzTqPZWWoO6EHDLGR0MbJLfzOtSxlyPfGzgQmstFKps0yoUPccC5BAx68gF0KmTbEYp4irm8SxHXnMTeTnGCIG4zxQ6e4pOUp/J5enscUn763zr+HuXeV4qugQ/uKCR58YPPpWee87ZinGF7hRFJXNZdo/3UXaDvsLodUD5I4sTg8mWHUx6/ADEAx0SGdT7u06Z6fSBtCfHP0l0CocpWeQTGJ2Wpgc6peO/QS8djM382PSLRs+UL7SH9XqUT939ma3TtmIskQHiZ5cvzXkoOeOjBnyRSj+LWP6K/jFxgDkDzmDDrN3j2BPdRgQMgoczRfsW8mvR/M/sRhZSXAgoNMDvw5ZlWt82GW5yHti59WitKBuoAiaBj6bB2tiAUtt2xR16/nO0Zb0X219soiID4nZ/TZiYRbJSM4gOwMrIEY0Oe6YCz3NMsKihRAmw1BcO/U0cMBphzRFhcB4tHsmY6g4rRHwuGBUIt4LlWEcp6bMaByTq551KoA7fPeehNb9z+6OR8SBbDwMRmtQ1EINJGxVa0yDm4z9H6W7e40= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(40470700004)(36840700001)(46966006)(8676002)(4326008)(9786002)(36756003)(70586007)(40480700001)(8936002)(31686004)(110136005)(5660300002)(316002)(4744005)(44832011)(82310400005)(2906002)(70206006)(478600001)(26005)(2616005)(186003)(82740400003)(336012)(53546011)(83380400001)(426003)(47076005)(41300700001)(31696002)(36860700001)(40460700003)(7636003)(356005)(83323001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 15:03:06.9221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1108fe-ce69-4024-6a61-08da8c2b13e4 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT017.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2737 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/1/2022 1:49 PM, Bhagyada Modali wrote: > Error check needs to be done only for last segment of Jumbo packet. > Freed first_seg and reset eop to 0 in error case > > Fixes: 965b3127d425 ("net/axgbe: support scattered Rx") > > Signed-off-by: Bhagyada Modali > --- > v2: > * removed the extra paranthesis > * initialised the variables > * updated the commit logs Patchset looks good to me, only stable tag (Cc: stable@dpdk.org) is missing which can be added while merging. Will wait maintainer ack to proceed.