From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A5AE43B2D; Mon, 19 Feb 2024 12:12:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FCBF40647; Mon, 19 Feb 2024 12:12:16 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2049.outbound.protection.outlook.com [40.107.223.49]) by mails.dpdk.org (Postfix) with ESMTP id CAFFD40275 for ; Mon, 19 Feb 2024 12:12:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iy86/qn/FUb5k2yE8/2XwPnz5rhNxwMSM/5s7KDDMkM5/NS2iyFbao2K7hEf3UnETi7T1SWypqv2qVTOb2zQCtsbfzNZ2qS1n/ESzoSfweuo29DUcJ4Ij6WXwNAcW569SuwAO0ua39Ps06e+uakiDsO2EzbL+T8kInJtWKohlgYZcIDHyZYuwY4tMEYl3ipB4bbgxx5YE6N4cbG19xflZrJjpkuoegD5xQxMZIYkUTis4m4IESyNEY59z5MmbyFltpJUqatKsR1ldB6QFNNk+BUhGg3EFCVWcZsBnh5GLcKkDC29HMy/9EuLK5ln5SfE+iuOsxZlKUovXAZW/rCDvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ui+puwSQ19qb/Bv+/drEFpEqJw0VFB1/gj9/s6SVvo=; b=Qd97D7BdQOIv40kIOKgazoXBGOSAxe4MwquhexMqFSmu42OlNrHGJ3HcqL3OjzXMYhVHa43BPbX4pdT7Vsc8D+vzQqSUCBMU5U+xx1qJuAFTdMpnEYSObUMrxbcGDKdXz+Wo7OXLTr+4MRMcIeMEA2R+u7QfI596PDQsPdX1aYJ79fGhKF994UuqFKh2DfbG/71XEw7s00YEUsNUps8O6PJyNUVSAofvtgIz8wyLr8dnynMQH5vTPvQ1+8n79EPBacnOIn8ct6LyP4roQzvMO2xEY3U2hU8gbJhHBYogm4KU45xHiSHvP9j+FMvnX+XzBCrgZP6OJQUpZNs52wx0uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ui+puwSQ19qb/Bv+/drEFpEqJw0VFB1/gj9/s6SVvo=; b=PqKwfZOQIIGTp23Tjr0FczRsD6PabWX3MTstaXq7mISY0xKsoxcOqDIo4W8UbRRhxd2mUIDvcAKZ7XioVKyDmIKP8Vc2DjMKH0Fid/Bb/TcMb1KnHSm2+IGOxRCnFmJiurz9ejaQFJAqMwNPmmfM7IEeeW26heURwHZyo6h8OBk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7812.namprd12.prod.outlook.com (2603:10b6:806:329::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Mon, 19 Feb 2024 11:12:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Mon, 19 Feb 2024 11:12:11 +0000 Message-ID: <1a5df42f-ceee-460d-a4e4-5ee725b52c16@amd.com> Date: Mon, 19 Feb 2024 11:12:09 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] net/netvsc: fix parsing of VLAN metadata Content-Language: en-US To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: <8139ddff-aabf-4ee0-a51b-a2a658691624@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7812:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a5c1321-9dd3-4a6f-b2c1-08dc313b9e47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t7uq5w/YYZq+uqUq75xKuVXTXKa/jR0r7eJIoSDjJu9H6ZLtRYcXk7hdKAIEh+gGI0qdLoSnsDOkELWBqgj9hg6JjNhlae/uXnhyQwTTElQC6p+9x6/487g0p8FHUourB7ne6ZTg9wa3hJP5qiWgsdPogPA2k1UuU1apPjD1YYEf3aVwzPrl0JVp4TqUrJGLCwbXghV3GtYsILdZSFWkoo3kBmXThy2iymlzd6rtlUG8iKpUfK0O0QzlQ1uBeI78IRzgsCqMP5jikGCbZLBPqnY/C9QozT8BRYgHcAYquIKBsUE0XCM2zdIqyjm3ONdoChRIkcQSowE5fDpwvSRvSp+TjnzfGdbOgYBfESWrJZ2D+5P1rsMc5R9jb2NrfFMNQFRJ6+FMmKo6sxI0GnlK+n2AtMz0g279G5aR6cdHJAEvXbI/ZaUE2cybIUAYMnsuVUIxAk4O/Oe2ffuPcOA98Bw755ecHR7ayvyRN0xKuEaph8He7Jc5uXC4cB2p89fOi9R9kiDqK+hlnHMISLPlaN4SCAf1Lj7ii4MYwKaEsDU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTBUMlE0K3k3SWFCV3NWZ0NweTFrM1hEczhyY2ZwczA3MDNoQWsvVUlGVTNF?= =?utf-8?B?eXRMdjB5L2JJUUcvYUxlNkNkdzhiMHJuZG9GSlhnTUNXSUJIYXZ3VHVMSHVK?= =?utf-8?B?dTNHdS9JUzVqRTkxVW0xYkFZV0J3UXd2YlUyR01RZENqTCt4aDNzUW1NWlY3?= =?utf-8?B?VU51OWVlUW55aEZpeWVKc05xRTArNDRqdTREYjhESEQwR1dSWFA4QzJoTjUy?= =?utf-8?B?SlVIaFZqWE5uYmsvUnUxREpUWmsyaEVVTVNWYzB1WGl1WjR6UUhFcEdvKzQz?= =?utf-8?B?cTJ3cFdwTlhWR3Bsa01oUDd4OE9POTJwUk9VY0hPT0RBMEJpalJWYmlGZit6?= =?utf-8?B?d3JSSVZxc1ZaVnBsaW9rc3BvU0RBeFlzc0sxN2FrVkhoWTVoTWNZZmZuVGxo?= =?utf-8?B?c2x4Y2cxTHVIQjhpRFozS0h0dy9jbFlTNUJLOWhvZWZWYVBEM2psMjBlOXMv?= =?utf-8?B?ODZIWTRqeEJVK25XTWNyTVVzYmxjZnJDd0xlejI4YVN0TG9RV0o5VzZseGI5?= =?utf-8?B?RFpzRy9vWU1JS2ovOUxER1FUSVhaTnZiRWNrblpuUExIZ1FzbVhsem40TFg5?= =?utf-8?B?anpneWRUSkRUVWZyZ1ZJdk1ldkJYK0ovMTZhaHZBMXJMVUVKMHZWMFc1dUlP?= =?utf-8?B?RnZ5TUpNdWxHM0poVnBwTU1RdmVsTDZJUVhpaGI1Y2drMHpjWjRjTG41QS9y?= =?utf-8?B?eVpnU2VOdHNyc08xbVc1b0YzQkN0d0NTVDRTZ0V0V291bWRWNHF5VW01aTJw?= =?utf-8?B?M1JRUlN5aU1hS01VVUVDdjVWOEU3aXYzU0ZnVDlXTnk1SGV1NmMyRVc3WTdQ?= =?utf-8?B?OXNLWGNIa2t2ejBnU1QyUEowVlJ2ckVITXMzRlZmOUpIcXltV0hNazl2WHNk?= =?utf-8?B?cnNVakJreXpUdjRteHNyK0RJTzNsZkZUemlJM3d5TXRiOGQ1L2oxaDZXaFNI?= =?utf-8?B?ZmJDMDJOTTR0Q0VPRG1kZU42RlZQM3J1NFlmc0VKQ2xWcFdJVzFjNVQ5Ykly?= =?utf-8?B?YVNVRG5WNzZKNENxbGx0d21obTA4c0x0eFlJcjBaWHN5RGZoZXo4TzNNSXlS?= =?utf-8?B?NG1jNG1XUzRiZjh4c1JjUmpGaG9lV3dPK2NmSG5pRUo1TXFYK2JROGRBRjJ3?= =?utf-8?B?aGlFVld3eGxvRUVsMlZTTkNzc2pkcEpmZTFNVmQ4RmFUcTRHbllScFdUNkFj?= =?utf-8?B?N29FMzl4RmFRbjh5d1lMelNDeHJGbDZMY2N1amVCcTltbjZkNWZuM0RRMGZK?= =?utf-8?B?Nm1DZzhBN1VXY2dqMWZ1U3JvSWFOb0RmU1UrR2xPMTJvSWVxQjZkV2kvWGIy?= =?utf-8?B?dkMyRFZDR3pJSEE0b1ZTY1Q3dnc2V05pdWpHQ2Z3OU4vcjZsMW5LVjdQRlpO?= =?utf-8?B?SWdIbjdaRG1IeC9ldXFNU1FxVEk2c0luYm9UV2ozMVEvcXVTVkNOcXJYejBp?= =?utf-8?B?c0RaNFBUQld3azJSZVZPRjc5enhHQTZQK3pDRFhnazRNUzRYdWRkMFVXVi9h?= =?utf-8?B?VjBMTDh6bE1hYzZnak0zNUlsSTUzTDlBdFJQM3VVQ1pyQjh5WHBNOEZobTNk?= =?utf-8?B?a3pPVUVuRjFuRElvQnU5Y1F3U2pieWhRMWlRbjhmYzAxUGZ6ZHpTZXpWczYr?= =?utf-8?B?Z0RBWmV2SHE5Y0NRSFBicWlESUNndUNrcXQ0QzNVc2N1OGQybXYvOGJOV0FX?= =?utf-8?B?TXBzejl3dUpwcWZVVncrMjQxZmVoYU9XS3RDc2dITHk0d2w4L1BCbjdxL0s4?= =?utf-8?B?MndhVjdCUWdROHFDSVB4MXRjaDkwN2RraGhJOVZMeTFaQkdMZUgvSXdtR3FS?= =?utf-8?B?S1I4RGVYRVBNVkkyNVMyS1BXU29RNjJhN2dGa3JXWURBL3QvRjN5SWs1eWht?= =?utf-8?B?WEo3ZVB6Rm9FME1GckdDNHlwZXQ0UlREZVFHL0hiTFFmeDVOTmdCV01nbG4z?= =?utf-8?B?VWN4L3NicDR6cTlXMXZMQ013OE5Nd3doK0RWL3V1bWxlZTlTWVdvOUwvN2x3?= =?utf-8?B?NVIxZk42azh6S3NVWC82VFdLdnI1S01EUld6Zyt5V2xWaXFPNDFBSG9JSTFT?= =?utf-8?B?RWl1NlRnV0R6Z3dQbkxoZ0dQMU8xK2l3cUQva1Z4TkJ1YS90OVd6ckVuRU45?= =?utf-8?Q?MHQUqAh5YFTDCOJnU5fndJelF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a5c1321-9dd3-4a6f-b2c1-08dc313b9e47 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 11:12:10.9737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GuiK6Lji1XbBR4gK8pkpVVsuOtCQyHoLhGzIkUKsygxy363acLTl9o3y07OAO+Ug X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7812 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/19/2024 9:31 AM, Alan Elder wrote: > The previous code incorrectly parsed the VLAN ID and priority. > If the 16-bits of VLAN ID and priority/CFI on the wire was > 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There > were macros defined to handle this conversion but they were not > used. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder > Acked-by: Ferruh Yigit