From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70D92A04FF; Wed, 4 May 2022 18:32:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52C9D40C35; Wed, 4 May 2022 18:32:35 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 01E284069F for ; Wed, 4 May 2022 18:32:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WeWUqf7ueGnkx7BSMbgPoxQcrX3Jx2Rb8diggHYT+QjPhA2rY9SENJ+2RwVp2z6PSE2XCpdYXPoh3JwiVgVF3nevSux4AHmL1Qk1U6ThiUf2IOwsa5o9HZPlHzWPuOwi5ZMKFZ0+IFF4mMFkQ2pVKBA1OsvX08+UUU3HrRMCKcsLh0vbQHIdnngTEKvoi3yx3Nsnz0N2IUwPHmhYyFMfktecrmB6lIbm14p6wdYRIULa3FoyhInORnPE9wOTuoCS4/lXWiRovOYey6ltLcNralLHc2a4/YUYQaWNS6+v9O65oSO+ySkn9jQMVtc/iiJLH+WGZcVnt9DqQ5X6fahx2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n4Y2sROTAiRdJ8hIPxySBartGLq7gmX/uzF317Pb5Cg=; b=ZkKGpvoB0mP5b5IPLoyMHwbcF+XVhiCGHJ3oCRVNIuB+FjS4gUlMBclXdb0f3qwWqEAPU/rV7jkPA6TEQwlHrraHx4+I2Yz7VW8ufCrZ+2fU2+ckC3cXV1IWnCCxibbkgZ5MoHdFeNnuiKwN35nhlSRYICPk0lWTKFnbDsirRKLxL5I5OpeaCAbuq7cg/f1UYlwh3rDvK+vLGpdzuIQ6ynnbqfVzZsKaG8hsBawBFtDe0Vo0WBuvhGljxPG0RSAlyMRY1iZN2Du63Ugye/xhr3URwRGZxBHtlEGtVwomGnIFmKybgIfSS584oZB/E837LhEbTICXDN193aOuN+GNTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n4Y2sROTAiRdJ8hIPxySBartGLq7gmX/uzF317Pb5Cg=; b=RENshIRVOj20LDeiOdupEDX9Z81iwo5PW6EfxBbpj4SkoeS2wDvCRFOCXgicY/SgTtMw2E94okAlg4mnPiJ2TWAyBwTn1ya01pHhAOLEqycaaVAxy5zav8r/BxgRB4gdIfvXl3dRMOX7ZkITVhDfw3BKSsnBDsFG1kBaVUwEu6s= Received: from DM5PR07CA0074.namprd07.prod.outlook.com (2603:10b6:4:ad::39) by SN4PR0201MB3613.namprd02.prod.outlook.com (2603:10b6:803:4b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 16:32:30 +0000 Received: from DM3NAM02FT053.eop-nam02.prod.protection.outlook.com (2603:10b6:4:ad:cafe::7b) by DM5PR07CA0074.outlook.office365.com (2603:10b6:4:ad::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23 via Frontend Transport; Wed, 4 May 2022 16:32:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT053.mail.protection.outlook.com (10.13.5.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 16:32:29 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 4 May 2022 17:32:28 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 4 May 2022 17:32:28 +0100 Envelope-to: humin29@huawei.com, ke1x.zhang@intel.com, chas3@att.com, dev@dpdk.org Received: from [10.71.119.146] (port=32600) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nmHvQ-00065b-BR; Wed, 04 May 2022 17:32:28 +0100 Message-ID: <1a74f1d9-5798-b996-cbfd-23fc1e673876@xilinx.com> Date: Wed, 4 May 2022 17:32:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/1] net/bonding: fix rss key configuration when the key length is 52 Content-Language: en-US To: "Min Hu (Connor)" , Ke Zhang , , References: <20220411030231.58268-1-ke1x.zhang@intel.com> <20220411054003.60095-1-ke1x.zhang@intel.com> <3f20d3e3-9a6e-7cfc-5181-5af5ff751d28@huawei.com> From: Ferruh Yigit In-Reply-To: <3f20d3e3-9a6e-7cfc-5181-5af5ff751d28@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66e4c69c-b1da-4bab-421c-08da2debaea5 X-MS-TrafficTypeDiagnostic: SN4PR0201MB3613:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RpFK/rpndIwNlSDPTcO5B/U6IZ9hYisnRTn9dVF/pCDDh7Q2Lut4EXNcZ6Dg42xM6jxH7NvlAbliihRXE1DQoThv9CoT55rh6mYByrv5DJHkky/bqfJTfF7fbq464Jk9WphORzJclCwICfUcawzjbBHV8Y4N0rGuHBbg78vqz//K+Jx7j0pEjkHaYXTj0Hjh/7k3wOCg3bw+BO1ESMG2XfrcIqN3WOjPdGNXruzSFLOSoQQXBP1bkBK4DchKGExdRV/7rvWp8adnjDXT1iKNufLwj8aZ4OBVcsRaVX3Gpn7uUIj6v9Xdmo7zpWLCgUfx/SjXFVS0TpAr8T/4SSaenL9SQ3jXWrQolOclr1NqNmcHUZ4q8O6TrU3hZt+dkowUxRjSGhZAWwrrmEa208j4agNuqelQBXNcrWp1K1bs0pnAEorHC5c+GEMwZdjxdVcgsNEeRrvgLkEhoim311AEIZ/6yY9ZanzoYHNjPybkm7AHxLmojISwqf8KzpoBO2Zx2XFl4w1gw8TTifrbUNHG+DSBjKkucZCf1pL/xuJsDWR8E2D1qSJF1kXbyTCi3ZxiXKLjv1FlsPovXSE04dytKTed7ElbzBiNi7keSvzx7WGf9bwmNQIcUpFR74R0n/b/KoHaTAJYLzWhTLonnodn+zRN8zGzBfArcOMGxb5l+pzjPqC2Lpk2LgqVv5/iY/kIgdl7EGF8m183TDxp8RdbhzVcujT1/MA7tAYIvmuaLto= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(8936002)(508600001)(186003)(9786002)(36860700001)(356005)(53546011)(31696002)(44832011)(83380400001)(40460700003)(4744005)(26005)(8676002)(31686004)(70206006)(82310400005)(2906002)(47076005)(7636003)(70586007)(36756003)(336012)(316002)(426003)(5660300002)(110136005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 16:32:29.4789 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66e4c69c-b1da-4bab-421c-08da2debaea5 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT053.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0201MB3613 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/13/2022 10:01 AM, Min Hu (Connor) wrote: <...> > 在 2022/4/11 13:40, Ke Zhang 写道: >> when creating a bonding device, if the slave device's rss key length >> = standard_rss_key length + extended_hash_key length, then bonding >> device will be same as slave, in function bond_ethdev_configure(), >> the default_rss_key length is 40, it is not matched, so it should >> calculate a new key for bonding device if the default key could not >> be used. >> >> Signed-off-by: Ke Zhang > > Acked-by: Min Hu (Connor) > Fixes: 6b1a001ec546 ("net/bonding: fix RSS key length") Cc: stable@dpdk.org (The fixes line not exactly true, since 52 byte keys seems not considered from the begging, but above commit seems the closest one to make the patch backported to proper releases.) Applied to dpdk-next-net/main, thanks.