From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CBD341C3F; Wed, 8 Feb 2023 12:04:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 040EE4014F; Wed, 8 Feb 2023 12:04:21 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2073.outbound.protection.outlook.com [40.107.92.73]) by mails.dpdk.org (Postfix) with ESMTP id 7E6D340141 for <dev@dpdk.org>; Wed, 8 Feb 2023 12:04:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PxJGfNfvruDrn0reiLbrsG3Ej8nMdEL+RUEhGw9TvRM4lS78aozhLhoz4bQRb7izLrHBF/jeirZ1rEODvkRfccbaU78lCHkW11zUmWyN2eMgv3FmZmfkVRp9b4DqQfDmzi7gXYlieYXv+RYk6SfOIZo9FYxPQbY6aa5G+S5xbScQDBDmWVHg3Gnaziz412a5hpR78U5P/l312A0i3Hgz+BV6Vfr7+qQRW/4YfSXMcqDru3S54cKyI0EDMgQDSo7r0hVkPZq4mYgIr8JZYwUlZEe79BYPs6ZssRyXlOsS/wnyCopE+tnZKel5bQAug1oYNXJm5sFxqv+J9Q65hu4R4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g61CNZY0L8ygkrLRrN/o1HmHBqda4q+/Jt/SAb70/Lo=; b=KYZAmwI9iavJ330LavNZU/PIw6hAAb+L/bWFydyw6MIJydISviPKLYJ5TyfJVp9z9gIIcVKRq5ui+knAICPNQsrCL1jHOBpaLdIK0PiNWbw8sRP7JHbq54OBmk1lYP3QgPuo6HEbi1lJrH2oGcfKjBCP9sjFxedXgTwNW0TfFD2PBVPwCjK9Kk8W8/c0/B3+aY8xoJON49Wi205YOYc1rukbygnDPuw30fZJDUUUffncsAeRN6ZG/s0ZpVIcqX91OyhOI7cqxGbmh4MHgObgTEKu7yqaDNvvw/A7Gg3Tf0h3/5+B6fxlfsefqOXanQ/Sn9oRAdPxo39pPqsX5Kf31g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g61CNZY0L8ygkrLRrN/o1HmHBqda4q+/Jt/SAb70/Lo=; b=KaalBN9muFJywevVXJOaO1Ia9R0+4uYeP+PI93CoWHZGYvHB7QBBIODd6Bq10dY9Iq3s/Bam+tGyae4anY8fbOhMR+/p5zKWFEVZvKkQ3aHSVMqLmGj8GhxGnCpdUvO4dezAgo2bY1iZwsSYOllCGrVf0HeRXRKDQsA7q+IE0Qc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6626.namprd12.prod.outlook.com (2603:10b6:208:3a2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 11:04:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%6]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 11:04:17 +0000 Message-ID: <1a9fd27f-ebbe-157c-0577-9c4ae5bbc798@amd.com> Date: Wed, 8 Feb 2023 11:04:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two) Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "thomas@monjalon.net" <thomas@monjalon.net>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "orika@nvidia.com" <orika@nvidia.com>, "chas3@att.com" <chas3@att.com>, "humin29@huawei.com" <humin29@huawei.com>, "linville@tuxdriver.com" <linville@tuxdriver.com>, "ciara.loftus@intel.com" <ciara.loftus@intel.com>, "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>, "mw@semihalf.com" <mw@semihalf.com>, "mk@semihalf.com" <mk@semihalf.com>, "shaibran@amazon.com" <shaibran@amazon.com>, "evgenys@amazon.com" <evgenys@amazon.com>, "igorch@amazon.com" <igorch@amazon.com>, "chandu@amd.com" <chandu@amd.com>, Igor Russkikh <irusskikh@marvell.com>, "shepard.siegel@atomicrules.com" <shepard.siegel@atomicrules.com>, "ed.czeck@atomicrules.com" <ed.czeck@atomicrules.com>, "john.miller@atomicrules.com" <john.miller@atomicrules.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "Maciej Czekaj [C]" <mczekaj@marvell.com>, Shijith Thotton <sthotton@marvell.com>, Srisivasubramanian Srinivasan <srinivasan@marvell.com>, Harman Kalra <hkalra@marvell.com>, "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>, "johndale@cisco.com" <johndale@cisco.com>, "hyonkim@cisco.com" <hyonkim@cisco.com>, "liudongdong3@huawei.com" <liudongdong3@huawei.com>, "yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, "simei.su@intel.com" <simei.su@intel.com>, "wenjun1.wu@intel.com" <wenjun1.wu@intel.com>, "qiming.yang@intel.com" <qiming.yang@intel.com>, "Yuying.Zhang@intel.com" <Yuying.Zhang@intel.com>, "beilei.xing@intel.com" <beilei.xing@intel.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, "junfeng.guo@intel.com" <junfeng.guo@intel.com>, "rosen.xu@intel.com" <rosen.xu@intel.com>, Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar Kokkilagadda <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>, Liron Himi <lironh@marvell.com>, "zr@semihalf.com" <zr@semihalf.com>, Radha Chintakuntla <radhac@marvell.com>, Veerasenareddy Burru <vburru@marvell.com>, Sathesh B Edara <sedara@marvell.com>, "matan@nvidia.com" <matan@nvidia.com>, "viacheslavo@nvidia.com" <viacheslavo@nvidia.com>, "longli@microsoft.com" <longli@microsoft.com>, "spinler@cesnet.cz" <spinler@cesnet.cz>, "chaoyong.he@corigine.com" <chaoyong.he@corigine.com>, "niklas.soderlund@corigine.com" <niklas.soderlund@corigine.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>, "g.singh@nxp.com" <g.singh@nxp.com>, "apeksha.gupta@nxp.com" <apeksha.gupta@nxp.com>, "sachin.saxena@nxp.com" <sachin.saxena@nxp.com>, "aboyer@pensando.io" <aboyer@pensando.io>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Devendra Singh Rawat <dsinghrawat@marvell.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>, "jianwang@trustnetic.com" <jianwang@trustnetic.com>, "jbehrens@vmware.com" <jbehrens@vmware.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "chenbo.xia@intel.com" <chenbo.xia@intel.com>, "steven.webster@windriver.com" <steven.webster@windriver.com>, "matt.peters@windriver.com" <matt.peters@windriver.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "mtetsuyah@gmail.com" <mtetsuyah@gmail.com>, "grive@u256.net" <grive@u256.net>, "jasvinder.singh@intel.com" <jasvinder.singh@intel.com>, "cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>, "jgrajcia@cisco.com" <jgrajcia@cisco.com>, "mb@smartsharesystems.com" <mb@smartsharesystems.com> References: <20230206115810.308574-1-adwivedi@marvell.com> <20230207063254.401538-1-adwivedi@marvell.com> <20230207063254.401538-4-adwivedi@marvell.com> <f2907fe2-fa55-66fb-4f89-cfd3e353684f@amd.com> <CO3PR18MB50057EB5D93AA6C1D2108DC1DDD89@CO3PR18MB5005.namprd18.prod.outlook.com> <dea51026-5f87-4581-654a-a7f2b313737c@amd.com> In-Reply-To: <dea51026-5f87-4581-654a-a7f2b313737c@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0194.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6626:EE_ X-MS-Office365-Filtering-Correlation-Id: 323ae053-ff16-4ab6-ed6b-08db09c43843 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V48U8dgIorPZN9GR3DwEY6anQa8TxpoYPqbAVAUZHBy4x7EX1IGlnjJh7R45Qvpq5omcEfvLcbZSEZPYNqTEQCsYr42VQcBL8RA/cqQ7tPkwv1LbvKM0V43ddlBXSuCxlIrOYsr7UH8IBEMEfveiMByvB18UNahtep3i0gbCUPz3d0RQ5D2LmBzgmpDTnQoT8OBqyzZPurMJmduIHcv6TyryHPA2d/FDOumbEGb/pvhj/biZkXQ3htpYrm6c4jv46hsBixsT/1MIDC5kKn/BMoWtaBfAbcFL6VYNnOj1HeU/06iMSJGpe9Wew6nYYQkb55XfwbNgMREDAAF6ft99rlfzGexEVbt01JUL5X7FTgSfpU1MWsFdzwAeqUQFMnyAjYfCnKJJqGTKg6d1e/Tw9loHLh5LOi2lGfnjKNmhOVel+FRh749ZgwOuVrhYpnPGidp/uu+RJ/OUhy/F/1T7AjhvnqHm/OmSDHiNspm+lBuytkPjFYehCqIdxWEDcGA4pzZzbucKHz9vyokJWolAVqplH0GO0qW5Fdi3PaSre0VvxJo+iKQwocoHAmj7ETlLATm2jT8w0HNpvFzB63IY/ErNJVpthIrZDuejyAyQZWPDZb4gtzkCR9i1EEnew8OwRIh5ezZO04CrIp5Yx6IjHScOySzdUeUShRwbYUiV4+BU+t5aPRHcj0+hoVDSzUPfRAkBZcsAXTN3XWk3jwQDi4DS5fbLVCEboD1UE5VCmVs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199018)(66556008)(4326008)(8676002)(66476007)(66946007)(6506007)(26005)(186003)(8936002)(41300700001)(6512007)(53546011)(478600001)(6486002)(86362001)(316002)(31696002)(6666004)(54906003)(110136005)(2906002)(5660300002)(7416002)(7366002)(7406005)(44832011)(36756003)(7336002)(2616005)(31686004)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjRTc2dwLytBbnljQ1IzbTY0VENaOHBNVlcyMDBDWk53dmtkMlpKbjBDbXRr?= =?utf-8?B?UEt2MWdhWUppditmYXNJY2VCSjBXWEtyUTFBZFBIemJiUmFZcHdmMkVpUWsr?= =?utf-8?B?d3BlZFV2OWhkQVZwTzQvbjBlKzBKek9jY3d6UFExTE40djFjSDBGWGlFOEpG?= =?utf-8?B?cDkyLzd5T1ZMQW5SZTFlRW1IblUxTDNQb3ZFMWxqMTh0SHRyYVArak9meUEy?= =?utf-8?B?TzNKaUZER0NVZjlVemN1aGdEVkJLdkNmZ2hVMUg2RzlMTVZqVFpJeEtzdHgy?= =?utf-8?B?YkZNTFFjZ0grbVU2cnJOZ1EyeWxlaXBaaTlqcWdQSDRBSks4b3llRUJyVXl1?= =?utf-8?B?d1RveDViN1VKUnk2TDJnMjFheXBwR1FmNFY0WkhFOEVsNSsxTzdEYUl3Y2kv?= =?utf-8?B?T0NXdDJqSEtwVXltVEpPdVB6K2YwQ2h6MmVEK3hyaC9DSWxvTkI2Tlpnd2hh?= =?utf-8?B?Nkp3eEMxOGpKZ2hCZmU1Zlh3S29FYVRPQS90dlN3ZTR5NjdGS1VqRk5ReS9h?= =?utf-8?B?eFJsNHZhenZZQ1RIWEphd3hJbFJRRWhyWmNBeStTSGdvSHYxajg5d0xDTFJl?= =?utf-8?B?VGsyMWh1SFV4Sy94M0drOStNbm12TXNHTWhYUGlsVjVaZ0hJUFdQb0ZGWEcv?= =?utf-8?B?K1EyclNlek9leWNtbTNxWFVLK3E5USs5b1BFWENFUmFZYm5yN25pa1B5U0pS?= =?utf-8?B?cWZPejRGczdwTUJtQkJxcm8waWUwQlU1TVRValJDZzE0YTZoYXMxblJRbnM2?= =?utf-8?B?aFdKdGNtanJtRGVKRUVJWnp3a2czaytIT3ZPMHcvS0t1dHBKYXhaNUIybDZP?= =?utf-8?B?RG9wK3U0RnRzb0Q5QTliRFZIOW9KemttNjNYVVZNT2hNQ1RXbS9FUngxeXJ6?= =?utf-8?B?S3MyQkloM3F0Nnh1N04zUWdzYmdpajltdnJNcGplOEdENWhmaDdUTEhRMWJD?= =?utf-8?B?Nk4yQTNTYUNOWFEwU1NzdWJWVnRMZEY1QklWQit6VERxNG5COElhVzdOdlVo?= =?utf-8?B?alFXaVh3OG5HbHYyMk96N3o2VGpneGNEMlNGOFVFbmM2UndqalFMZHRocVpw?= =?utf-8?B?ekNHNU1WaVlEcWtYelBldVJhNWtPV25kT1pHOWFoaUt3OVJjTFU5Vm0wSUhF?= =?utf-8?B?My9mQ0U0Q2hyUzJZTVFINTczZTMwZ2ZjWnVkdzFCbWdJYTIvU2ZZcW14eWE3?= =?utf-8?B?V3JQUFNsbXMrK0lORkh6RW53WHBTeWZxTjZCUng1dW56cWozeUVzZzRYRDZJ?= =?utf-8?B?bVEyV3RUL3krNm1peUJTRTBOcjFBa0VVZlcyb2hxTFJUUFZUWCt6RHpOMGFv?= =?utf-8?B?TFl3MjdadTZKdUlZd2RDeEFPTHhESWo1d1U5eEJra3VrV08vN3ZJSXdQMEJ6?= =?utf-8?B?L0RQV0tCVE1oZGt0NHNHVDZ2NWpQSWZ0dXVyUXR2aUlYR0ozZ1JvVlI0QXBG?= =?utf-8?B?Zk1ad0puTHpCYmNrbXUxdVFGdk9BTW9EcWxKSGNEQTFUQWppZnhtaXhKY1RM?= =?utf-8?B?SlJxN3NLNlZRVjU1N2V1SDRoQlpBQTZydXFqcU01SW1jM1NsbnBwNkV1UGZX?= =?utf-8?B?UEtJZ3psck1RME8xWlhST3NjY0J5Q3dGZGRXVkJ0TVRCWmlmZGZ6clpKL2V6?= =?utf-8?B?VmhtQUQvVmNtVFZoOHlnM29STkhlbzVkQzhzaFk4T0V2Q0ZaTmw4U1RyaXZJ?= =?utf-8?B?aVovc2FhazNHUWpvQ3Jyd240MmhpSTZ0b3NoeDBzUUl4SC9mdXRYRng5TXBp?= =?utf-8?B?QzdEN2o5c2l4eHFPQXhBY3JNeXJiVGFzR3Ezd2MyZHByTTRQYTJWMUFWT1dy?= =?utf-8?B?dldsVjBpaVg1TVdaZE9qMi80MFh4bS9lUkVPWTFaY1dvT0VpV1N5TGpJYXJD?= =?utf-8?B?WkZpVEFiNk5OOG5mdmltYnd3MzZjK1NSUnNUd0kySGhHcG9uWTcyVHVnbFV0?= =?utf-8?B?d0VQMWdTOVRzTG9HM3ZhYURYTEtvcG9VQTdBM2RHTVVCdjJRQTd6ZzF0R25x?= =?utf-8?B?cjMzeXVzcEYrVUJrRW1ORUw4NlhrUjBjVWdIeHdkaExqbmJCNVk0eGd2cXVM?= =?utf-8?B?TFVKYmRlS1N2QWNuM3NsVENHYzJGaGlFTURjYU1wSXd0MlhXSHo2WFI3OVEx?= =?utf-8?Q?9xdIk4y2wcHEqQZn+I+Rpff04?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 323ae053-ff16-4ab6-ed6b-08db09c43843 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 11:04:16.8721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CTCkqMf3p5uC1MngjxNPI/LUEZKAOYh86abI8TcdL15rijwlSAS0TgGkoHNC4wSR X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6626 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/8/2023 11:00 AM, Ferruh Yigit wrote: > On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >>>> +RTE_TRACE_POINT( >>>> + rte_ethdev_trace_set_mc_addr_list, >>>> + RTE_TRACE_POINT_ARGS(uint16_t port_id, >>>> + const struct rte_ether_addr *mc_addr_set, uint32_t >>> nb_mc_addr, >>>> + int ret), >>>> + rte_trace_point_emit_u16(port_id); >>>> + rte_trace_point_emit_ptr(mc_addr_set); >>> What about recording this as blob? >>> But 'mc_addr_set' is array of addresses, so length needs to be >>> 'RTE_ETHER_ADDR_LEN * nb_mc_addr'. >> The mc_addr_set pointer can be NULL in rte_eth_dev_set_mc_addr_list. In that case the >> blob function will give seg fault. Hence I think blob cannot be used here. > Does it make sense to make 'rte_trace_point_emit_blob()' accept NULL and > fill all array with 0 in that case to cover this kind of cases? btw, 'rte_trace_point_emit_blob()' already checks for NULL, so expect it won't give segmentation fault, but won't record the value. Not sure if not recording the value cause problem later when parsing the trace file.