From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7D8ACA0556;
	Mon, 17 Oct 2022 10:32:26 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0AA2940143;
	Mon, 17 Oct 2022 10:32:26 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 90856400D7
 for <dev@dpdk.org>; Mon, 17 Oct 2022 10:32:24 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1957583;
 Mon, 17 Oct 2022 11:32:24 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1957583
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1665995544;
 bh=shePKdEK4AwDZq3x8d4F+48kCo6KpPE1CLh61OLDt90=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=ycG5Qhs19uw9OMBgoGXzqthTQU4MtoKNDU8JiKGDWggm67wzEeq/wtsjGO6HV1Rmk
 dekRAFYeRU9h5mhlUJAyfaJFFW5QYqiZwW4u885zR3Ac/gcy77s+lAiHlizFexSLXt
 nYoBBeIOwV7xBacD3ABuZ7eMhQfu+VBTPz0/50cA=
Message-ID: <1ab79c80-ed69-8a18-5742-0039e10faecf@oktetlabs.ru>
Date: Mon, 17 Oct 2022 11:32:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD
Content-Language: en-US
To: Hanumanth Pothula <hpothula@marvell.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
Cc: dev@dpdk.org, jerinj@marvell.com, ndabilpuram@marvell.com
References: <20220802175151.2277437-1-hpothula@marvell.com>
 <20221006183522.1330826-1-hpothula@marvell.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221006183522.1330826-1-hpothula@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/6/22 21:35, Hanumanth Pothula wrote:
> Presently, Rx metadata is sent to PMD by default, leading
> to a performance drop as processing for the same in rx path
> takes extra cycles.
> 
> Hence, introducing command line argument, 'nic-to-pmd-rx-metadata'
> to control passing rx metadata to PMD. By default it’s disabled.
> 
> Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

> 
> v3:
> - Updated run_app.rst with the new command line argument,
>    nic-to-pmd-rx-metadata.
> - Updated commit text.
> v2:
> - taken cared alignment issues
> - renamed command line argument from rx-metadata to nic-to-pmd-rx-metadata
> - renamed variable name from rx-metadata to nic_to_pmd_rx_metadata

Applied to dpdk-next-net/main, thanks.