From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org
Cc: Dept-EngDPDKDev@qlogic.com,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 04/22] qede/base: update base driver
Date: Fri, 30 Sep 2016 17:44:56 +0100 [thread overview]
Message-ID: <1ac6d74c-cc78-4efd-275c-9645952fb8a0@intel.com> (raw)
In-Reply-To: <1475219169-8774-5-git-send-email-rasesh.mody@qlogic.com>
Hi Rasesh,
On 9/30/2016 8:05 AM, Rasesh Mody wrote:
> This patch updates the base driver and incorporates necessary changes
> required to bring in the new firmware 8.10.9.0.
>
> In addition, it would allow driver to add new functionalities that might
> be needed in future.
>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
> doc/guides/nics/features/qede.ini | 2 +
> doc/guides/nics/features/qede_vf.ini | 2 +
> doc/guides/nics/qede.rst | 15 +-
> drivers/net/qede/Makefile | 4 +
> drivers/net/qede/base/bcm_osal.c | 21 +
> drivers/net/qede/base/bcm_osal.h | 10 +
> drivers/net/qede/base/common_hsi.h | 1257 ++++++++++++++++++---
> drivers/net/qede/base/ecore.h | 172 ++-
> drivers/net/qede/base/ecore_chain.h | 31 +-
> drivers/net/qede/base/ecore_cxt.c | 371 +++++-
> drivers/net/qede/base/ecore_cxt.h | 52 +-
> drivers/net/qede/base/ecore_cxt_api.h | 15 -
> drivers/net/qede/base/ecore_dcbx.c | 587 +++++++++-
> drivers/net/qede/base/ecore_dcbx.h | 18 +-
> drivers/net/qede/base/ecore_dcbx_api.h | 128 ++-
> drivers/net/qede/base/ecore_dev.c | 1627 ++++++++++++++++++++-------
> drivers/net/qede/base/ecore_dev_api.h | 129 ++-
> drivers/net/qede/base/ecore_gtt_reg_addr.h | 10 +
> drivers/net/qede/base/ecore_hsi_common.h | 1146 ++++++++++++++-----
> drivers/net/qede/base/ecore_hsi_eth.h | 991 ++++++++++++----
> drivers/net/qede/base/ecore_hw.c | 214 ++--
> drivers/net/qede/base/ecore_hw.h | 47 +-
> drivers/net/qede/base/ecore_hw_defs.h | 33 +-
> drivers/net/qede/base/ecore_init_fw_funcs.c | 327 ++++--
> drivers/net/qede/base/ecore_init_fw_funcs.h | 182 ++-
> drivers/net/qede/base/ecore_init_ops.c | 5 +-
> drivers/net/qede/base/ecore_init_ops.h | 14 +-
> drivers/net/qede/base/ecore_int.c | 313 +++---
> drivers/net/qede/base/ecore_int.h | 19 +-
> drivers/net/qede/base/ecore_int_api.h | 11 +
> drivers/net/qede/base/ecore_iov_api.h | 473 ++------
> drivers/net/qede/base/ecore_iro.h | 222 ++--
> drivers/net/qede/base/ecore_iro_values.h | 108 +-
> drivers/net/qede/base/ecore_l2.c | 407 +++----
> drivers/net/qede/base/ecore_l2.h | 57 +-
> drivers/net/qede/base/ecore_l2_api.h | 18 +-
> drivers/net/qede/base/ecore_mcp.c | 707 +++++++++---
> drivers/net/qede/base/ecore_mcp.h | 85 +-
> drivers/net/qede/base/ecore_mcp_api.h | 194 +++-
> drivers/net/qede/base/ecore_proto_if.h | 59 +
> drivers/net/qede/base/ecore_rt_defs.h | 639 +++++------
> drivers/net/qede/base/ecore_sp_api.h | 5 +-
> drivers/net/qede/base/ecore_sp_commands.c | 83 +-
> drivers/net/qede/base/ecore_sp_commands.h | 30 +
> drivers/net/qede/base/ecore_spq.c | 181 +--
> drivers/net/qede/base/ecore_spq.h | 26 +-
> drivers/net/qede/base/ecore_sriov.c | 1596 ++++++++++++++++----------
> drivers/net/qede/base/ecore_sriov.h | 149 +--
> drivers/net/qede/base/ecore_vf.c | 736 +++++++-----
> drivers/net/qede/base/ecore_vf.h | 224 +---
> drivers/net/qede/base/ecore_vf_api.h | 93 +-
> drivers/net/qede/base/ecore_vfpf_if.h | 165 ++-
> drivers/net/qede/base/eth_common.h | 387 ++++---
> drivers/net/qede/base/mcp_public.h | 629 +++++++++--
> drivers/net/qede/base/nvm_cfg.h | 623 ++++++++--
> drivers/net/qede/base/reg_addr.h | 36 +
> drivers/net/qede/qede_eth_if.c | 1 +
> drivers/net/qede/qede_main.c | 20 +-
> drivers/net/qede/qede_rxtx.h | 4 +
> 59 files changed, 10857 insertions(+), 4853 deletions(-)
Thank you for the update, base driver patch update now reduced from
"14653 insertions(+), 8536 deletions(-)" to
"10857 insertions(+), 4853 deletions(-)"
But this is still to big for reviewing, specially there are some low
hanging fruits for cleanup, like big chunk of comment updates or
whitespace updates or non base driver codes in the patch.
If the expectation is that somebody non maintainer review the code,
understand it and highlight any possible defects, I believe this patch
is too big and needs to be split more into logical pieces,
but since this is a driver code and a little special, and it may not be
possible to completely understand the code without knowing underlying
hardware, I am not sure how to proceed and adding Bruce and Thomas to cc
for guidance.
Thanks,
ferruh
next prev parent reply other threads:[~2016-09-30 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 7:05 [dpdk-dev] [PATCH v2 00/22] qede: update qede pmd to 1.2.2.1 and enable by default Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 01/22] qede/base: add new files and shuffle the code Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 02/22] qede/base: formatting changes Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 03/22] qede: use FW CONFIG defines as needed Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 04/22] qede/base: update base driver Rasesh Mody
2016-09-30 16:44 ` Ferruh Yigit [this message]
[not found] ` <BLUPR0701MB157207202A7D8EB817D33DA59FC10@BLUPR0701MB1572.namprd07.prod.outlook.com>
2016-10-05 16:29 ` Thomas Monjalon
2016-10-10 23:31 ` Mody, Rasesh
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 05/22] qede/base: add the driver support for the MFW crash dump Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 06/22] qede: enable support for unequal number of RX/TX queues Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 07/22] qede: fix port (re)configuration issue Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 08/22] qede/base: allow MTU change via vport-update Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 09/22] qede: add missing 100G link speed capability Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 10/22] qede: remove unused/dead code Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 11/22] qede: fixes for VLAN filters Rasesh Mody
2016-09-30 7:05 ` [dpdk-dev] [PATCH v2 12/22] qede: add enable/disable VLAN filtering Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 13/22] qede: fix RSS related issues Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 14/22] qede:add scatter gather support Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 15/22] qede/base: change rx tx queue start APIs Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 16/22] qede/base: add support to initiate PF FLR Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 17/22] qede: skip slowpath polling for 100G VF device Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 18/22] qede: fix driver version string Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 19/22] qede: add support for queue statistics Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 20/22] qede: remove external dependency and enable by default Rasesh Mody
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 21/22] doc: update qede pmd documentation Rasesh Mody
2016-09-30 15:11 ` Mcnamara, John
2016-09-30 7:06 ` [dpdk-dev] [PATCH v2 22/22] qede: update driver version Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ac6d74c-cc78-4efd-275c-9645952fb8a0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@qlogic.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).