From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit
Date: Wed, 30 Nov 2016 14:54:14 +0000 [thread overview]
Message-ID: <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> (raw)
In-Reply-To: <1479768194-6255-1-git-send-email-thomas.monjalon@6wind.com>
On 11/21/2016 10:43 PM, Thomas Monjalon wrote:
> Add a check for commits fixing a released bug.
> Such commits are found thanks to scripts/git-log-fixes.sh.
> They must be sent CC: stable@dpdk.org.
> In order to avoid forgetting CC, this mail header can be written
> in the git commit message.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
I think this is useful, thanks for the patch.
> ---
> scripts/check-git-log.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
> index 5f8a9fc..4f98a7a 100755
> --- a/scripts/check-git-log.sh
> +++ b/scripts/check-git-log.sh
> @@ -47,12 +47,14 @@ if [ "$1" = '-h' -o "$1" = '--help' ] ; then
> exit
> fi
>
> +selfdir=$(dirname $(readlink -e $0))
> range=${1:-origin/master..}
>
> commits=$(git log --format='%h' --reverse $range)
> headlines=$(git log --format='%s' --reverse $range)
> bodylines=$(git log --format='%b' --reverse $range)
> fixes=$(git log --format='%h %s' --reverse $range | grep -i ': *fix' | cut -d' ' -f1)
> +stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut -d' ' -f2)
This breaks the "check-git-log.sh -N" usage, since "-N" is not a valid
range for git-log-fixes.sh.
Generates warning:
.../scripts/git-log-fixes.sh: illegal option -- 6
usage: git-log-fixes.sh [-h] <git_range>
> tags=$(git log --format='%b' --reverse $range | grep -i -e 'by *:' -e 'fix.*:')
> bytag='\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by:'
>
> @@ -191,3 +193,10 @@ bad=$(for fixtag in $fixtags ; do
> printf "$fixtag" | grep -v "^$good$"
> done | sed 's,^,\t,')
> [ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n"
> +
> +# check CC:stable for fixes
> +bad=$(for fix in $stablefixes ; do
> + git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' ||
> + git log --format='\t%s' -1 $fix
> +done)
> +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n"
This is good for developer, but since "CC: xx" tags removed when patch
applied, this will generate warnings when run against existing history.
I don't know what can be done for this.
Or should we keep CC: tags in commit log perhaps?
>
next prev parent reply other threads:[~2016-11-30 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 22:43 Thomas Monjalon
2016-11-30 14:54 ` Ferruh Yigit [this message]
2016-11-30 15:09 ` Thomas Monjalon
2016-11-30 15:26 ` Bruce Richardson
2016-11-30 15:31 ` Thomas Monjalon
2016-11-30 15:36 ` Bruce Richardson
2017-01-16 9:51 ` Yuanhan Liu
2017-01-16 10:37 ` Thomas Monjalon
2017-01-16 11:19 ` Yuanhan Liu
2017-01-16 14:26 ` Thomas Monjalon
2017-01-16 14:46 ` Yuanhan Liu
2017-01-16 10:38 ` Ferruh Yigit
2017-01-16 10:54 ` Yuanhan Liu
2016-12-01 13:43 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-12-01 15:00 ` Ferruh Yigit
2016-12-01 15:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b249c77-5685-8492-6f6b-3478a2731267@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).