From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org
Cc: arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue
Date: Fri, 9 Oct 2020 22:01:39 +0100 [thread overview]
Message-ID: <1b2fba84-97bb-8362-7fc5-a814690290ce@intel.com> (raw)
In-Reply-To: <e525afda-830c-fa5c-362d-d4ca2bf34a22@redhat.com>
On 10/8/2020 10:10 AM, Kevin Traynor wrote:
> On 07/10/2020 22:48, Thomas Monjalon wrote:
>> As described in doc/guides/prog_guide/poll_mode_drv.rst,
>> the naming scheme for the xstats is parts separated with underscore:
>> * direction
>> * detail 1
>> * detail 2
>> * detail n
>> * unit
>> where detail 1 can be "q" followed with a queue number.
>> It means the name of the stats per queue should be rx_qN_* or tx_qN_*.
>>
>> The second underscore was missing so far.
>> Fixing the basic xstat names may be considered an API change,
>> that's why it should not be backported.
>>
>> While fixing this mistake, some examples of the naming scheme
>> are given as part of the API documentation of rte_eth_xstat_name.
>> More proposals about standardizing statistics:
>> http://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
>>
>> Fixes: bd6aa172cf35 ("ethdev: fetch extended statistics with integer ids")
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2020-10-09 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 21:48 Thomas Monjalon
2020-10-08 9:09 ` Bruce Richardson
2020-10-08 9:10 ` Kevin Traynor
2020-10-08 10:29 ` Asaf Penso
2020-10-09 21:00 ` Ferruh Yigit
2020-10-09 21:01 ` Ferruh Yigit [this message]
2020-10-08 15:41 ` Ferruh Yigit
2020-10-09 8:32 ` Power, Ciara
2020-10-09 8:36 ` Pattan, Reshma
2020-10-09 9:02 ` David Marchand
2020-10-09 9:08 ` Pattan, Reshma
2020-10-09 16:53 ` Kevin Laatz
2020-10-09 19:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b2fba84-97bb-8362-7fc5-a814690290ce@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).