From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94CD6A04DE; Fri, 23 Oct 2020 12:41:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1AD4A93E; Fri, 23 Oct 2020 12:41:52 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 6A5F6A904; Fri, 23 Oct 2020 12:41:50 +0200 (CEST) IronPort-SDR: 4H4Ez19RVmw0NCLJKMyfoBjiGiM3cgv7IyRIFhFmiLICJprs3SGrDho5qQt/GV8eqF/gOBv4Sy DW6qzEBEjljA== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="231849120" X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="231849120" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 03:41:44 -0700 IronPort-SDR: SqjcfJykJb6o2z+QMlS598DALbgFG3WVrdthApMQd4DROChg3ZlWXC3PvoYoMIyF6W6h1S+qaZ In6Cs3ctjqFg== X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="534353592" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.253]) ([10.213.224.253]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 03:41:42 -0700 To: Yuying Zhang , dev@dpdk.org, qi.z.zhang@intel.com, beilei.xing@intel.com Cc: stable@dpdk.org References: <20200920152813.674261-1-yuying.zhang@intel.com> <20201019022025.1748497-1-yuying.zhang@intel.com> From: Ferruh Yigit Message-ID: <1b5954fa-aff1-2694-c205-551b00a7773a@intel.com> Date: Fri, 23 Oct 2020 11:41:36 +0100 MIME-Version: 1.0 In-Reply-To: <20201019022025.1748497-1-yuying.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2020 3:20 AM, Yuying Zhang wrote: > i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual > channel commands safely in multi-process mode and multi-thread mode. > However, it returns -1 when one process or thread is pending. Add > rte_spinlock_trylock() to handle this issue in concurrent scenarios. > Should '_atomic_set_cmd()' removed, since spinlock it added? > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org > > Signed-off-by: Yuying Zhang <...>