DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: john.mcnamara@intel.com, reshma.pattan@intel.com,
	bruce.richardson@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/7] autotest: fix invalid code on reports
Date: Thu,  7 Jun 2018 22:01:56 +0100	[thread overview]
Message-ID: <1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1528404133.git.anatoly.burakov@intel.com>
In-Reply-To: <cover.1528404133.git.anatoly.burakov@intel.com>

There are no reports defined for any test, so this codepath was
never triggered, but it's still wrong because it's referencing
variables that aren't there. Fix it by passing target into the
test function, and reference correct log variable.

Fixes: e2cc79b75d9f ("app: rework autotest.py")
Cc: stable@dpdk.org

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 test/test/autotest_runner.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index b09b57876..bdc32da5d 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -41,7 +41,7 @@ def wait_prompt(child):
 # quite a bit of effort to make it work).
 
 
-def run_test_group(cmdline, test_group):
+def run_test_group(cmdline, target, test_group):
     results = []
     child = None
     start_time = time.time()
@@ -128,14 +128,15 @@ def run_test_group(cmdline, test_group):
             # make a note when the test was finished
             end_time = time.time()
 
+            log = logfile.getvalue()
+
             # append test data to the result tuple
-            result += (test["Name"], end_time - start_time,
-                       logfile.getvalue())
+            result += (test["Name"], end_time - start_time, log)
 
             # call report function, if any defined, and supply it with
             # target and complete log for test run
             if test["Report"]:
-                report = test["Report"](self.target, log)
+                report = test["Report"](target, log)
 
                 # append report to results tuple
                 result += (report,)
@@ -343,6 +344,7 @@ def run_all_tests(self):
             for test_group in self.parallel_test_groups:
                 result = pool.apply_async(run_test_group,
                                           [self.__get_cmdline(test_group),
+                                           self.target,
                                            test_group])
                 results.append(result)
 
@@ -367,7 +369,7 @@ def run_all_tests(self):
             # run non_parallel tests. they are run one by one, synchronously
             for test_group in self.non_parallel_test_groups:
                 group_result = run_test_group(
-                    self.__get_cmdline(test_group), test_group)
+                    self.__get_cmdline(test_group), self.target, test_group)
 
                 self.__process_results(group_result)
 
-- 
2.17.1

  parent reply	other threads:[~2018-06-07 21:02 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 21:01 [dpdk-dev] [PATCH 0/7] Make unit tests great again Anatoly Burakov
2018-06-07 21:01 ` [dpdk-dev] [PATCH 1/7] autotest: fix printing Anatoly Burakov
2018-06-07 21:01 ` Anatoly Burakov [this message]
2018-06-07 21:01 ` [dpdk-dev] [PATCH 3/7] autotest: make autotest runner python 2/3 compliant Anatoly Burakov
2018-06-07 21:01 ` [dpdk-dev] [PATCH 4/7] autotest: visually separate different test categories Anatoly Burakov
2018-06-07 21:01 ` [dpdk-dev] [PATCH 5/7] autotest: improve filtering Anatoly Burakov
2018-06-07 21:02 ` [dpdk-dev] [PATCH 6/7] autotest: remove autotest grouping Anatoly Burakov
2018-06-07 21:02 ` [dpdk-dev] [PATCH 7/7] autotest: properly parallelize unit tests Anatoly Burakov
2018-06-12 13:07 ` [dpdk-dev] [PATCH 0/7] Make unit tests great again Thomas Monjalon
2018-06-13  8:38   ` Burakov, Anatoly
2018-06-13 10:29     ` Bruce Richardson
2018-07-13 16:19 ` [dpdk-dev] [PATCH v2 00/10] " Reshma Pattan
2018-07-13 16:19 ` [dpdk-dev] [PATCH v2 01/10] autotest: fix printing Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 02/10] autotest: fix invalid code on reports Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 03/10] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 04/10] autotest: visually separate different test categories Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 05/10] autotest: improve filtering Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 06/10] autotest: remove autotest grouping Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 07/10] autotest: properly parallelize unit tests Reshma Pattan
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest Reshma Pattan
2018-07-13 16:41   ` Burakov, Anatoly
2018-07-16 13:29     ` Pattan, Reshma
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 09/10] autotest: update result for skipped test cases Reshma Pattan
2018-07-13 16:42   ` Burakov, Anatoly
2018-07-13 16:20 ` [dpdk-dev] [PATCH v2 10/10] mk: update make targets for classified testcases Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 0/9] Make unit tests great again Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 1/9] autotest: fix printing Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 2/9] autotest: fix invalid code on reports Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 5/9] autotest: improve filtering Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 6/9] autotest: remove autotest grouping Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-16 15:16   ` Burakov, Anatoly
2018-07-17  9:18     ` Pattan, Reshma
2018-07-17  9:23       ` Burakov, Anatoly
2018-07-17  9:45         ` Pattan, Reshma
2018-07-17 10:10           ` Burakov, Anatoly
2018-07-16 14:12 ` [dpdk-dev] [PATCH v3 9/9] mk: update make targets for classified testcases Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 0/9] Make unit tests great again Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 1/9] autotest: fix printing Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 2/9] autotest: fix invalid code on reports Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 5/9] autotest: improve filtering Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 6/9] autotest: remove autotest grouping Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-17 10:39 ` [dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases Reshma Pattan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b90d1177e1bec6ba4f862ad59e888f6add0480f.1528404133.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).