DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kamil Rytarowski <krytarowski@caviumnetworks.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, <maciej.czekaj@caviumnetworks.com>,
	<zyta.szpak@semihalf.com>, <slawomir.rosek@semihalf.com>,
	<rad@semihalf.com>,  Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: Support VFs on the different PCI domains
Date: Wed, 12 Oct 2016 19:07:03 +0200	[thread overview]
Message-ID: <1ba82bb5-3660-847e-9385-073b305c5887@caviumnetworks.com> (raw)
In-Reply-To: <CALwxeUukaBxhsDfhM8hPnYOmc2OJN6BX6vy5MCt5HDcMiWTzdw@mail.gmail.com>



W dniu 11.10.2016 o 18:52, David Marchand pisze:
> On Tue, Oct 11, 2016 at 3:49 PM, Kamil Rytarowski
> <krytarowski@caviumnetworks.com> wrote:
>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
>> index 382c959..01d5fb0 100644
>> --- a/lib/librte_ether/rte_ethdev.c
>> +++ b/lib/librte_ether/rte_ethdev.c
>> @@ -225,7 +225,7 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size,
>>   {
>>          int ret;
>>
>> -       ret = snprintf(name, size, "%d:%d.%d",
>> +       ret = snprintf(name, size, "%d:%d:%d.%d", pci_dev->addr.domain,
>>                          pci_dev->addr.bus, pci_dev->addr.devid,
>>                          pci_dev->addr.function);
>>          if (ret < 0)
> This patch is obsolete since this part has been moved to eal.
>
> Can you test with current master branch if there is still an issue ?
> Thanks.
>
>

I've tested DPDK master without this PCI domain patch and everything 
seems to work.

Thank you.

      reply	other threads:[~2016-10-12 17:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 13:49 Kamil Rytarowski
2016-10-11 16:52 ` David Marchand
2016-10-12 17:07   ` Kamil Rytarowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba82bb5-3660-847e-9385-073b305c5887@caviumnetworks.com \
    --to=krytarowski@caviumnetworks.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=kamil.rytarowski@caviumnetworks.com \
    --cc=maciej.czekaj@caviumnetworks.com \
    --cc=rad@semihalf.com \
    --cc=slawomir.rosek@semihalf.com \
    --cc=zyta.szpak@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).