From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CCA441C53; Thu, 9 Feb 2023 16:13:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECB1E410EA; Thu, 9 Feb 2023 16:13:45 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) by mails.dpdk.org (Postfix) with ESMTP id 94C5D40EDC for ; Thu, 9 Feb 2023 16:13:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGd3vxB1y05CLPfoSuZaO8psKoF3mXPqkrrFKuiMgXFV0dXiiAFOUs94PNvd661nzjHmwPa/ToeurJBN199BPcYY12ScXvUu8/XvHYglFR70CvWgyo9Sg2L3RPblNrJ+Fc284AHEQkhw+VupvqD5o7cQaKmZ8Y/9sgbYYj8RyELwgQsjmM33mzpQHQQvjAVGx44yl4DOFO2CDWk8z0BJbKhrR04/SLQmTx66SQlv+m21dNnaNpBRjuUDNvTMEsgkzWR8BOnElHbD4GSZRBHBzfXvIe9XX8SKJ6wesepu5OGzSKIVu3oVMN3ikcotl5EdfkDDuumVV114rfnguT0hlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HmSJj4/nulqTnWfVOG24YBSX3Iqtcm4f0z0F521bw1M=; b=agZGG9TK19V387tEgqRJdiusteylV4xDtIpZag6jGnH87nnqGNCBYkz6XCqeeicKFSN1yipyrE91XIQYx4bHZUZ4fPsMV+TyfkLUlS6M+REjqfbs8PD/8T/muSswSPDvVUCf0DS5xsylPBBoUvIHYgzpUUf0OrYSzUdf8AacJHE0diI4YrajOGHb+B9IgtJmZ8o98rcpqTW8qr538ZSd5JRkw2BP2mWKtjEZGKlCZr7xgS6bvrPa8Ip0b6keo6Qmyf4DePkVtBURx/EmkRmms1/K7PPBg2N5njw8e7nPw5BPLetoiNSzRkkiATpq1UnYTu2uKcIvdnBVfzP15qz0UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HmSJj4/nulqTnWfVOG24YBSX3Iqtcm4f0z0F521bw1M=; b=xwUt7SW8i7NN5Dgchtn5wzVk5GUHoWL+YYXLaFJpvfX2JgwDecE3xZlwJWRk4oyyI3aZl7/GkkTm/78Ke/0OTaPHhZSPlaZ3sJuQ9R1q8HzTTeggA00QUgDRUgNr76VVxp6TKBB+iJ1kpISWYib6iZl+rVwbfFoeWmDuEGaoQ6E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB7722.namprd12.prod.outlook.com (2603:10b6:208:432::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:13:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%6]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 15:13:42 +0000 Message-ID: <1bb231e1-ff88-38d3-9e98-0b110a4b9927@amd.com> Date: Thu, 9 Feb 2023 15:13:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 1/2] ethdev: add query and update sync and async function calls Content-Language: en-US To: Gregory Etelson , dev@dpdk.org, Andrew Rybchenko Cc: matan@nvidia.com, rasland@nvidia.com, Ori Kam , Thomas Monjalon References: <20221221073547.988-1-getelson@nvidia.com> <20230202134750.10418-1-getelson@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230202134750.10418-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0048.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::36) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB7722:EE_ X-MS-Office365-Filtering-Correlation-Id: 5886a652-7391-4af6-2682-08db0ab03b1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lsL3eWtcuJ1RSqw9g6q8dNqmDR6Wyiz4BZNE5wC6gBQj0pEnIQzgxoKG11+srBunaAcvBWSLykih9JQ3mPIdH4Fi6t/3wGoUNeZp3aIeAnmRrDf+zTwVkC/7ZLEK1iCjvJIB9a+L9FplAPvnPOy1qzTRths07mxrBdGD/XMUS23OlJuN4U5sAcK7yogKzXCP2XyV6Z27pDTQs42AY3GLNjkEVE/nBVG3Whe68QLrY3riNp/l44/qatgq1y60sB3YHcLPLzusqY9Ncd3OOrm5R++QvKGpuGOyXQzJX92p2j4pPlEaBJA7rpMT0Be3EVWuaFVnM4ZIHORua+n1NA2lzKdFDxCH3Ubc5CYPL2Xfcnf4cUAl9jlda5JuevDaYhM34oS+V41OUKxHyxdr7fQGIZT4egA4rOMl9vTwplzqqr4CPUBXZs2H3RIlKd/K0GpltN0Zkbtc7y/+w/s+jyJynjpkkzw2jyplAptlxYCXjDLt+Sr7Am9L1ri3ufPU2f2ZylJPCwRmLOpBqYvPM5YKR7EFiDQbt5ALMy/oSVdGwietvDvmoyTGDa6MMOk7jH5S/6F/Jn61E8kdxNdleJ7Mv/XEGIJegwbrQ3DhEkCnMnDPQYVW2G75CPYan5SGBm8Y/0UJsP03bQ9eOamBmpzhLREuQL7TT38nIrkCKqTsEyO6SePRHKMYnkSHVow5f/bPEbiJSEI5FMYWtdjFTuzLdyGNOddUXxvRnBNMsMNBO8I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(346002)(136003)(376002)(396003)(39860400002)(451199018)(36756003)(83380400001)(31686004)(38100700002)(26005)(6506007)(6512007)(186003)(6666004)(110136005)(54906003)(2906002)(53546011)(478600001)(6486002)(316002)(8936002)(41300700001)(5660300002)(2616005)(31696002)(86362001)(15650500001)(44832011)(66476007)(66556008)(66946007)(8676002)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlVheDlldzZRVmNhbnp0MlJ0TU5LalFGYVlBcDJQNlpHcGQrSGc0Skh6M2Vk?= =?utf-8?B?eEg3V3kwaHFGUm5LWFU5OEM3ejJnajBibE5XVUVBc2ZScll1N1BGUnBwN0RM?= =?utf-8?B?M1ZLMWpEUnpudEtabzVFdmwrUE5FQmVkcmdiaCtBZG9xVExDVW5NQURzaGpj?= =?utf-8?B?cS8yQWVWcTZUWWEyZXhMSEpzUTdZdytJbVUwanJQZmxpT0w3UnptbDc1SkZO?= =?utf-8?B?SWpNZHZET3hyYVF6U0xjQXBZSk9HeWxSZnhzVFVHK2hGRDVvSTdkU1VCVEFl?= =?utf-8?B?eHNBWVc5RVRhVC9qTTZZc2EvelordWdWSkZ6MWFnS1YxY1NjR1NFNDUycnMx?= =?utf-8?B?amlFWEwvaFQ3TlBmWm5nYVRZSUppUWdjZVd2MzFEZ09uVklxSXltbzdDY3J1?= =?utf-8?B?WkVjOXlGdEhQVExNUjB5RHBhRG14YXBqT0tGN0hBVVQ2Q0dvWE5wL2loc1BR?= =?utf-8?B?N1NVaUdOdzJtMCtRY0k2QlQ0UStmRDZXZ2RCTm1kRDZPS1lXTFBWQWJmaXJh?= =?utf-8?B?bzVvTHArSlIwc0NhUzdHSlpHaVUyNWZpMDgxSjJrNDhTZTgyc3Q5aktBaTNl?= =?utf-8?B?TDh2SXlreEtZQy9vSlBtY2VHZ0VLRERVYUdGRlVNaDRwZVpQcTVxMkpjcEln?= =?utf-8?B?SjQ5c0R1VzRyQzJpM0hwZUtrMy91MWczSnhkK3lUSVRRZjNPdEl4ZitWOGs4?= =?utf-8?B?bjBBY0UwTkkvWmZuamptWlEvOGZRanlOdDR5UHh2TlJXMXdWajVhZEZZSnpl?= =?utf-8?B?bTgrenlpcjJVVnF2SzJ5OE1RbUdBN09KSDhvS29hbEV3TE0xOHVJUGlMQnNw?= =?utf-8?B?N0hMMk5DdFBuTmk4alFMcmFMcEQxTzZsblNmVjd0OHFDYWtMK3liQ25HeC9N?= =?utf-8?B?b1hGVklaQi9tem5IbVJ6MzFERlRiWWFEdkZRdnQ3SEpxTzg0Mm9tdXdNNjJD?= =?utf-8?B?QXNWNGJwenNjRE9SR1pLNXZjYzVaaWQ4azYxSjV3V0pFdlI1SFhMMHZrU0hr?= =?utf-8?B?TW53UHMxdHkrL2o5TWFtMHBmbmdXOG9OMVNKMnM1QUhiY3JycnJGdFdJckEw?= =?utf-8?B?ZzcyVGVQZzlZbkYwNVpWS0EzY0Y0dkhXRGlqcDhTbDRuL0tiaG9UTkFXVnR0?= =?utf-8?B?b2Z3VTZER3JKVCt4blpxY3NQVTVZWTZmaFVFWS9RU0d1aDk5dGhKOHlid3Fs?= =?utf-8?B?K25mdWlGbHRQd1Z6NGcwTE9CTGxsbGtBMnhoTmFlVUdGUUVtUy9SaE9ybE9u?= =?utf-8?B?YmYwT1cvTFNSTTdDSTFjUnh3YURBakhXYXlXbzlETmR3VXRDS2VYQmlGMTBo?= =?utf-8?B?SFhDTndvZS95NTFDSUl0MDJEWUNwNG16Z0FNbUI3Y2x4M2FtaFJPUDA3dU15?= =?utf-8?B?aTNDd25xeURnMFF0dFltaEt5TTZVY1ZJM0xzNUw0VFg5QnNqaU5jYzkwSkw1?= =?utf-8?B?U0RRVjdpNndtTGlkRzdCSGtmc2FHTk4yODRoRkNsTTZDdW9mQnJrZnZJa1d6?= =?utf-8?B?U0NDU29Sako1a0RmOVpVMHJ0bXREVkRqTFBEck9yZ2FybGcyR1U2b3YzOGtB?= =?utf-8?B?alZzWjRNM2NFeTc2dFNBbUdRVGROTE1yZ1VHdUttakEvandFcGRTSTV6QTBU?= =?utf-8?B?VUVObUpTSFlURU4rK1lhdjY2WUZPSGFnbndnWkpJd2lSZUlnMUEvMWN6cnow?= =?utf-8?B?TzJ4bUZKZmxUOW5MUWdRTW1oQU5zU3JaL25Jd3ZuY1VZQWJIY1ZybHdxMnp1?= =?utf-8?B?T2llVmFzQ2ZONjFKTWVUSmlON0szUnArUFlRS29ldENuQmVOQmZGSDJLVTh0?= =?utf-8?B?YkUxcEdDYm9DbFpXQmhvVXNydUpVeFY4Rk0rVUFKMHhyQjJUWDE1aUo1OU04?= =?utf-8?B?MUQxM0xKRnUvcHA1OUlqbU0rR05XdmdJd2JqZDU1dWlxMGswSENHa1h0YWkr?= =?utf-8?B?TVBhYjlzSkZRRlo4bFFYWGUvMFNuZXNOaVlCTXFQZU5kZUxjeExwYW0wREhL?= =?utf-8?B?WFJqN09GV0JhWVk3d2cyNm9PMXkvaUZlN2wycVprU1FoZ2xzcWVQQXNVWnB1?= =?utf-8?B?SWpGUFBDN1g2ejFzSVVCdzhxOVdVRmpXL0M2cjcyaE9mWTBKZkxYeWc4WGdF?= =?utf-8?Q?4qi/Whp3cyI9HLHaU6iKiw19h?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5886a652-7391-4af6-2682-08db0ab03b1c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:13:42.7779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qGE1k7cclFCgXYEHPoeDJXZZMPRJr7z2WtrpD/oiZqbCZQ+yamYdcYRTQrt7buPL X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7722 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2023 1:47 PM, Gregory Etelson wrote: > Current API allows either query or update indirect flow action. > If indirect action must be conditionally updated according to it's > present state application must first issue action query then > analyze returned data and if needed issue update request. > When the update will be processed, action state can change and > the update can invalidate the action. > > Add `rte_flow_action_handle_query_update` function call, > and it's async version `rte_flow_async_action_handle_query_update` > to atomically query and update flow action. > > Application can control query and update order, if that is supported > by port hardware, by setting `qu_mode` parameter to > RTE_FLOW_QU_QUERY_FIRST or RTE_FLOW_QU_UPDATE_FIRST. > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > --- > v2: Remove RTE_FLOW_QU_DEFAULT query-update mode. > v3: Update release release notes. > Fix doxygen errors. > v4: Add returned errno codes. > v5: Update the patch description. > Fix typos. > v6: Resolve merge conflict with the main branch. > v7: Update documentation. > v8: Style fixes. > v9: Add parameters validation. > v10: Code update. it seems there were some comments from Andrew to previous version, are they resolved now? @Andrew, do you have any objection/comment on this version?