From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E02322C60 for ; Wed, 22 Aug 2018 15:35:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2018 06:34:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,274,1531810800"; d="scan'208";a="256313449" Received: from nikhilr-mobl1.amr.corp.intel.com (HELO [10.252.84.201]) ([10.252.84.201]) by fmsmga005.fm.intel.com with ESMTP; 22 Aug 2018 06:34:58 -0700 To: Jerin Jacob Cc: olivier.matz@6wind.com, dev@dpdk.org References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com> <1534479652-80182-2-git-send-email-nikhil.rao@intel.com> <20180819104534.GB11085@jerin> <20180821091139.GA13834@jerin> From: "Rao, Nikhil" Message-ID: <1bb4dab2-cd67-e5a9-5a3e-fb3cce93a8c2@intel.com> Date: Wed, 22 Aug 2018 19:04:55 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180821091139.GA13834@jerin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 13:35:01 -0000 On 8/21/2018 2:41 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Tue, 21 Aug 2018 14:22:15 +0530 >> From: "Rao, Nikhil" >> To: Jerin Jacob >> CC: olivier.matz@6wind.com, dev@dpdk.org, nikhil.rao@intel.com >> Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for >> eth Tx adapter >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 >> Thunderbird/60.0 >> >> External Email >> >> On 8/19/2018 4:15 PM, Jerin Jacob wrote: >>> -----Original Message----- >>>> Date: Fri, 17 Aug 2018 09:50:50 +0530 >>>> From: Nikhil Rao >>>> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com >>>> CC: dev@dpdk.org, Nikhil Rao >>>> Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx >>>> adapter >>>> X-Mailer: git-send-email 1.8.3.1 >>>> >>>> >>>> The caps API allows the application to query if the transmit >>>> stage is implemented in the eventdev PMD or uses the common >>>> rte_service function. The PMD callbacks support the >>>> eventdev PMD implementation of the adapter. >>>> >>>> Signed-off-by: Nikhil Rao >>>> --- >>>> + >>>> static inline int >>>> rte_event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues) >>>> { >>>> @@ -1275,6 +1300,15 @@ int rte_event_dev_selftest(uint8_t dev_id) >>>> return RTE_EVENT_MAX_DEVS; >>>> } >>>> >>>> @@ -1295,6 +1329,9 @@ struct rte_eventdev * >>>> >>>> eventdev = &rte_eventdevs[dev_id]; >>>> >>>> + if (eventdev->txa_enqueue == NULL) >>> >>> Is this check required, it will be always NULL. Right? if so, >>> Can't we write eventdev->txa_enqueue directly? >>> >>>> + eventdev->txa_enqueue = rte_event_tx_adapter_enqueue; >>>> + >>> >> >> The thought was that if the PMD supports txa_enqueue then it wouldn't be >> NULL. > > > Yes that's true. But in rte_event_pmd_allocate(), eventdev->txa_enqueue > it will be NULL. Right? Do we need to add the if (eventdev->txa_enqueue == NULL) check? OK, got it. Nikhil