DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, beilei.xing@intel.com
Cc: ting.xu@intel.com, dev@dpdk.org, Maciej Rabeda <maciej.rabeda@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] common/iavf: replace macro for MAC address length
Date: Thu, 15 Oct 2020 22:04:50 +0100
Message-ID: <1bc0e966-3c4d-9bf3-446a-c27fe9c18e51@intel.com> (raw)
In-Reply-To: <20201015004325.1016100-2-qi.z.zhang@intel.com>

On 10/15/2020 1:43 AM, Qi Zhang wrote:
> Replace ETH_ALEN with VIRTCHNL_ETH_LENGTH_OF_ADDRESS.
 >

Why? They have same value, righ? Can you please put the reason, and impact if 
any to the commit log.

> 
> Signed-off-by: Maciej Rabeda <maciej.rabeda@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>   drivers/common/iavf/virtchnl.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index 81eabd73be..a5a300afe3 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -624,8 +624,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_tc_info);
>    */
>   
>   struct virtchnl_l4_spec {
> -	u8	src_mac[ETH_ALEN];
> -	u8	dst_mac[ETH_ALEN];
> +	u8	src_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
> +	u8	dst_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS];
>   	/* vlan_prio is part of this 16 bit field even from OS perspective
>   	 * vlan_id:12 is actual vlan_id, then vlanid:bit14..12 is vlan_prio
>   	 * in future, when decided to offload vlan_prio, pass that information
> 


  reply	other threads:[~2020-10-15 21:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  0:43 [dpdk-dev] [PATCH 0/3] iavf update base code Qi Zhang
2020-10-15  0:43 ` [dpdk-dev] [PATCH 1/3] common/iavf: replace macro for MAC address length Qi Zhang
2020-10-15 21:04   ` Ferruh Yigit [this message]
2020-10-15  0:43 ` [dpdk-dev] [PATCH 2/3] common/iavf: add support for VFs with >16 queue pairs Qi Zhang
2020-10-15  0:43 ` [dpdk-dev] [PATCH 3/3] common/iavf: update version Qi Zhang
2020-10-15 21:06   ` Ferruh Yigit
2020-10-15  8:42 ` [dpdk-dev] [PATCH 0/3] iavf update base code Xing, Beilei
2020-10-15 15:28   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bc0e966-3c4d-9bf3-446a-c27fe9c18e51@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=maciej.rabeda@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git