From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3741AA04DB; Thu, 15 Oct 2020 23:05:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98A651DE08; Thu, 15 Oct 2020 23:04:58 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 638141DE05 for ; Thu, 15 Oct 2020 23:04:57 +0200 (CEST) IronPort-SDR: qd7jnwOvUs2lZ9uup7QWN8pj9YHgbl/agtRfELj1z/4+3KN/lsh7ZB4uzVJCMubrN1h4zoH2lZ Xl4MaF4LCOnA== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="228101005" X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="228101005" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 14:04:55 -0700 IronPort-SDR: /fUsqHQYZphVfdmGI7d4iLZsmctpp6nEW/NuCdT2o71swX07y1vyhV1yLdU/Zrr3A2vJBvZJT1 0n8HLcL64byg== X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="464437972" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.84.112]) ([10.251.84.112]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 14:04:53 -0700 To: Qi Zhang , beilei.xing@intel.com Cc: ting.xu@intel.com, dev@dpdk.org, Maciej Rabeda References: <20201015004325.1016100-1-qi.z.zhang@intel.com> <20201015004325.1016100-2-qi.z.zhang@intel.com> From: Ferruh Yigit Message-ID: <1bc0e966-3c4d-9bf3-446a-c27fe9c18e51@intel.com> Date: Thu, 15 Oct 2020 22:04:50 +0100 MIME-Version: 1.0 In-Reply-To: <20201015004325.1016100-2-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] common/iavf: replace macro for MAC address length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2020 1:43 AM, Qi Zhang wrote: > Replace ETH_ALEN with VIRTCHNL_ETH_LENGTH_OF_ADDRESS. > Why? They have same value, righ? Can you please put the reason, and impact if any to the commit log. > > Signed-off-by: Maciej Rabeda > Signed-off-by: Qi Zhang > --- > drivers/common/iavf/virtchnl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h > index 81eabd73be..a5a300afe3 100644 > --- a/drivers/common/iavf/virtchnl.h > +++ b/drivers/common/iavf/virtchnl.h > @@ -624,8 +624,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_tc_info); > */ > > struct virtchnl_l4_spec { > - u8 src_mac[ETH_ALEN]; > - u8 dst_mac[ETH_ALEN]; > + u8 src_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS]; > + u8 dst_mac[VIRTCHNL_ETH_LENGTH_OF_ADDRESS]; > /* vlan_prio is part of this 16 bit field even from OS perspective > * vlan_id:12 is actual vlan_id, then vlanid:bit14..12 is vlan_prio > * in future, when decided to offload vlan_prio, pass that information >