From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AB65A034F; Fri, 4 Feb 2022 16:06:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13CD94013F; Fri, 4 Feb 2022 16:06:15 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6BE2F40041 for ; Fri, 4 Feb 2022 16:06:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643987173; x=1675523173; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=z98QQmXZ+301tnbjlos0hLWG9DBDHi1EOvce3QyAkEA=; b=ctJSoImJUMVVvByIQp+Tv11/e6SXHejXekhZyEt+tt02D2nXtIr2SrOb 1HU/w2O8TOrJH25ioJ7Gvr/hBYqbE66WetH7wwXAk7xix4gsmCKQX/sb5 Bpo8y2OmgHQw/AW6kCqyvouiRpNRIziIkFMuitqPJ5a1/u5MdBuiggKGw 7mKoARQF1RnDZ6vfxGxYbkEKuhmcTGmc8wfMXJ6h8WoOTKUUUbSaaywpD /DkLi7Nwwe8p3BSyP2XkHn0TuBtIVihnLm+4DFynJqBuKWxvHIuz3tzbf wvKrfTJm+l2ORZdeCDrOvnu+IbMBxTV3/NOg8APuvEGT2JjzLpYg9DJN0 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10247"; a="235780574" X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="235780574" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2022 07:06:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="483632552" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 04 Feb 2022 07:06:12 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 4 Feb 2022 07:06:11 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 4 Feb 2022 07:06:11 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 4 Feb 2022 07:06:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hgwhYm3c+FJ8TdzbQYMgfGwEk1o3zT2yjMIkRGBxx73ZxePIeY0fP8jdimay1NenXg19HQrGBtETnDNVtBbfR2iK8m13HG8aKYd8nbSq+p01dJNJzkBBGZgIBep80FNJ85XsaIJSjomAq7N//pl/oPaPE2rItZXTMVNoGzNitHtqLPEJyVtm/LV/Q1kqvXyA5qJeq2CSbPBKrcG0JwcXJThgigsc+EtO7OCi0U0UQlDjSl2KnpBBy4lefQiycaWr/cp0iaHVxxkk9z7poWgIRbrFiGLiHyG2gKTdgtucWqSe8235bZBUZq/ptSR3X+JK2V+0iagOI2DGDEjt+Pz8ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c/yDyELACRHalwlHGVDmD55ogyfu6g4RaMaBDfszxmI=; b=UtSN0xH3h90GAN00Blbad8hdK7vkBSytK7Pz+r+WVqMPdHh+H4M62uc1CMQofkQzijBsbstOL7iwEN+OH+APyNg4C04hf0kgFSQRpNuYYF3iz2xb29V8AgfpBBcO6PDmRgFbGJmnbf9720k18YkKfOD4N2kD2utWcQzifiMjiQWpMlsiVDh1EH3JletGHqrz1rKZKvFhpL1536Uk9GELJdt6ikXDWnv3sxyngnv7lpAwzvHsP7nn/PSqvhUNBQRysECM7mPf/WDRSVTXyS9R3Hp8oPwZx0r0wnGJAIna6eelXrIl3FGPlvyEnfdZmblBlraqOvaZp8xs6H2YFCq83g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3320.namprd11.prod.outlook.com (2603:10b6:a03:18::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Fri, 4 Feb 2022 15:06:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Fri, 4 Feb 2022 15:06:08 +0000 Message-ID: <1bd29fec-c118-5f57-3ae9-c68d8b2291fa@intel.com> Date: Fri, 4 Feb 2022 15:06:02 +0000 Content-Language: en-US To: Robert Sanford , CC: , , References: <1639592401-56845-2-git-send-email-rsanford@akamai.com> <1640116650-3475-1-git-send-email-rsanford@akamai.com> <1640116650-3475-2-git-send-email-rsanford@akamai.com> From: Ferruh Yigit Subject: Re: [PATCH v2 1/8] net/bonding: fix typos and whitespace X-User: ferruhy In-Reply-To: <1640116650-3475-2-git-send-email-rsanford@akamai.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0073.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc724ee5-4f94-4fc9-e1d1-08d9e7efdf5f X-MS-TrafficTypeDiagnostic: BYAPR11MB3320:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zVkUa+lr70eqWzlUDkpRyJzbbR+KJSi9C/uXFL8gCN16PSCJOV5bI/qPaobO8rIRQNlQS6hOIkuLLVOFJ0NaEAECg9B4F77kOr9xD4cRaneFjyiyeOUzhPJsiA3UerEKqmidEMcQ/I2ToK/RrUtDAMDT2XhUQY4PqqoQ/Q2yfJiHxXJmOzOjMo5jYUz2KEV0c2wWqms7nWxtYE7I2WbAcEYL8BeREUw5NB2EUzqiaAVnljJ9sEIIo6/0KJtQTMFIU5WeFi44GOXTGYLNGqa4vLrjhLy/0WZ6o45mFrJYVzqh7X57C84Is/RFTkTxbxjHicVZlQbhtT7yJr8v6oCaPvJfyVBCf0XVSwTTI8pYH+SKtqgnpAQcqx1MqlRTfey4EXMKGASeFXQGfvPG1vpZXMxgttIfGS7h7vksH+nTJ2UBhv+paOJ2Jg72Taktpd0KRDznhGoWpJ2N7jrJw5rlwYgXzdNxPkoNFbBlANMkktM2ngwisSLf0x8VG+vg6WVFV3hagNhU2gY6o/Jpf9FP2U2E18P58VJjWezJqjLgy/FnH5TCla1WuuJe9nvc88K6WTYuxuzmnJuCeI/dBnbLl1sfoHK7UgKsqu11qZK39SPWWZqkAYFj3tv6e0rHjEV8tp/OjLZTiW9fABJ16O87vSOiTgy2kMgVUisdozLWgxnDNRf6xuMoEfGBbDHJNAFlokTQ40njDPmBHb0Q0X0F+A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(82960400001)(5660300002)(31696002)(31686004)(66476007)(66946007)(66556008)(8936002)(26005)(186003)(83380400001)(2616005)(36756003)(55236004)(6486002)(6506007)(4326008)(6666004)(38100700002)(86362001)(316002)(53546011)(8676002)(508600001)(6512007)(2906002)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFRZdW1wUVBUUm5uVEY4TkFRUUdHd3pYbjllMW9xS3d5cUd6Q3F4eHlBM0lx?= =?utf-8?B?QVArL2lIODNHUGtuVWYwZXk1Uno2b3FtOUlQRnZBMXgyUk10OE01NkNnaW1w?= =?utf-8?B?QmFweUdtS01zdE4vZFBONjhZNDU4cWIwMmhkTENuakQ1c0tTVFRkNzg0SWRZ?= =?utf-8?B?VkxtejNpVDEzQWlPZHhROWJkNGNobzlZekRaZXVNYlBsd3phNFNxUVAzcXgv?= =?utf-8?B?cUtndHk1bFNUMEowR2N6d1JiZXhINjI4WDd3UklYMjU2a2F6bEc3RzU2TllP?= =?utf-8?B?UHRrejVHcWtIcjZPeWhHV3ZjNC9KcGJUUHBlUFgySTgxdktxenBKdFFzTlpl?= =?utf-8?B?SU9XdWN2V3hyL1FmTkFKdVZ5WXdZa0piOExsUmI3dU56U1E1VVpEbXl0dDJD?= =?utf-8?B?bmd3Qi9RQWdtcG5Qb3ZJazBxL1VXejJLa1NDU2N2RHpLTGpLU1R1NlNJZ2xO?= =?utf-8?B?elo0bkVleXQySjBjTlhtY1pjQzF6MkZSWi9FOVBEVzYzS3NBekxlZVlud2hi?= =?utf-8?B?Zkg3UHRxTWRNNE5kclQwUGNOckIwTnJKcEpSRVVVUHBoelcxdjFnSUh0VGVT?= =?utf-8?B?dVpHazhPUVNkMHpYcFU2eXlubGlZZXBMcUFFZ2tPZVVzQnROWWVpeS9vdnFh?= =?utf-8?B?Y2E5SWNwdTZhbHQ0QXNSbmI2R1llK05NcFIzdzRxeFlxTHFkVlprVG9CcGxC?= =?utf-8?B?N1dnR3VXbVBOZC9TYS9PUDFDYjR0d2RnYXV6ZjlWcGw5VlBxWmxFSHhrVVcr?= =?utf-8?B?T2lyakoweUhPQnpIWlM1Vms5TzVOR3NWdHRxVStMWEZoQW1mT3BnVkNmM1dl?= =?utf-8?B?bVZ5YU5oblVTbUtVdGZEODVyeXdyb0R5enF5cnowZ2pkQ2NPRG1iQzVhVktI?= =?utf-8?B?dHpoelJXcW1RNVJZam14amZQeUtaSXRvd01INXkrS2VORnVxWXFrWWZGTnA2?= =?utf-8?B?Y0hDMWhwQXhlZDRJem9XRlh2SzdvbGxFQ0ltUldXdU81WjVyb0Jza1h0Ni9S?= =?utf-8?B?RWhESkxuRlpwUER4Ri9lMDRxZ1JGTW56dFZZQ1ZDcWxSNzBEMHdHTFJqa0dt?= =?utf-8?B?NlpjT01WTVB4YWREZU1BYW52NnVPM3ozeGI2elRiMnpQQlFRVzlpSGhlbVBD?= =?utf-8?B?S056Mm5GQ1VYcVpFWVhOR01FaFJxV2QxZjRwMUwzL2hqbHVvMGIvYnZrUmFP?= =?utf-8?B?WWxrb2d1aTNPa04wcU9NU0I0bThMUjQzSHdKT3hsQ04zRzE5N3F2MUlFcHg3?= =?utf-8?B?d0dqeWJEb0tvZ2o5NzhZQnBCTnByKzVRT1hmeDJGc0ZLYk0wZGRrT2lpWFUx?= =?utf-8?B?bkxTL1NGeHowUFlMd3piQ1R6dVlLNXQzL3NvbTJyZUtxeUhPQ2xZMmVxSENH?= =?utf-8?B?WGZTSFZacW9SOFVFTE0wVThPWTA5b3UyM0ptMWhkSDRtb2YweDNpTWNjNEJV?= =?utf-8?B?ekZobUpDc3R5eE8yRXlqM1F0d01kUEttbkJRdUZUNWdQQW5IbTZMYzVLUmlP?= =?utf-8?B?azlCbzc1U3NleS9CRTFiV0t4Ync1T2lUbEZYWlV3MmtndC9HSFBzTDhQcEVG?= =?utf-8?B?cGd1bW5ELzNqaFRkcTZOR2xGb1oyRnc1eUpaOUVnSmFZRkRyaHRSREsyOGUv?= =?utf-8?B?NUlVcUdZeHVHY2I5ZzYxQlBIdUVIelhVWHB5ZjlFTjB1cURUa294ZlpSQThj?= =?utf-8?B?NmZ1M1kzVmFQTkFSTGo3MFIrM2QrRkY5UEx1VGhIUE1kVWUvOTZncXZ6VVho?= =?utf-8?B?RTBNbm8vTG55c25CRks0bW8wNUUzSmM3ZWM5VWdsNkFydUhtTVJyZjNUWnZT?= =?utf-8?B?VGlHdWpLSFZ0eGNEZ01tdUdJTVNrNTdMYzY1QUkzZEtJYnNOa2VOM2U0b2Ey?= =?utf-8?B?Z2lydWxLbzRRUmJHdEtXcWF2ZHBxaGZvdk5OVm5FbFR3UVZ2dlFRaWl5b25U?= =?utf-8?B?ZGRrYnRSWUZ5VTRIYkVHVE1oSi9BaWRXWk81dmhZT3RwdUpiOWhBYWhpd1I5?= =?utf-8?B?Zkp5aDZkV01jMklpNmxDTjdsUWdXV1hqTUNuSU9XS1d4MUZuQVhqb1ZVNjUy?= =?utf-8?B?ZGdYc28zb2R1NzVDaWFiVGF1Y1FTbmlvRUt1Y0lnbjRXZDYwVVgrMjBRb3ps?= =?utf-8?B?dlM5Z1lIa29QdHRwMVd4R25QWlJhNG16R0w4cEFaTDBFcXcwajBrQ1BwRTkv?= =?utf-8?Q?S4B+L+QgPDfwpTL3kD8gd+g=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dc724ee5-4f94-4fc9-e1d1-08d9e7efdf5f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 15:06:08.3562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GT2lIW+A1H5tNRhdzh4cipT3fE85HmB0bKAjUAstnn6ok3jURpLNK0eHITs5cr9HRN59bkBzvp/wTfm/nEfhKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3320 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/21/2021 7:57 PM, Robert Sanford wrote: > - Clean up minor typos in comments, strings, and private names. > - Fix whitespace in log messages and function formatting > (new line before open brace). > - Move closing C++ wrapper to the end of rte_eth_bond_8023ad.h. > > Signed-off-by: Robert Sanford > --- > app/test-pmd/cmdline.c | 4 ++-- > app/test/test_link_bonding_mode4.c | 28 +++++++++++++-------------- > drivers/net/bonding/eth_bond_8023ad_private.h | 12 ++++++------ > drivers/net/bonding/rte_eth_bond_8023ad.c | 22 ++++++++++----------- > drivers/net/bonding/rte_eth_bond_8023ad.h | 15 +++++++------- > drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++++----- > 6 files changed, 49 insertions(+), 45 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 6e10afe..9fd2c2a 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -630,8 +630,8 @@ static void cmd_help_long_parsed(void *parsed_result, > "set bonding mac_addr (port_id) (address)\n" > " Set the MAC address of a bonded device.\n\n" > > - "set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)" > - " Set Aggregation mode for IEEE802.3AD (mode 4)" > + "set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)\n" > + " Set Aggregation mode for IEEE802.3AD (mode 4)\n\n" ack > > "set bonding balance_xmit_policy (port_id) (l2|l23|l34)\n" > " Set the transmit balance policy for bonded device running in balance mode.\n\n" > diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c > index 351129d..2be86d5 100644 > --- a/app/test/test_link_bonding_mode4.c > +++ b/app/test/test_link_bonding_mode4.c > @@ -58,11 +58,11 @@ static const struct rte_ether_addr slave_mac_default = { > { 0x00, 0xFF, 0x00, 0xFF, 0x00, 0x00 } > }; > > -static const struct rte_ether_addr parnter_mac_default = { > +static const struct rte_ether_addr partner_mac_default = { ack <...> > diff --git a/drivers/net/bonding/eth_bond_8023ad_private.h b/drivers/net/bonding/eth_bond_8023ad_private.h > index 9b5738a..60db31e 100644 > --- a/drivers/net/bonding/eth_bond_8023ad_private.h > +++ b/drivers/net/bonding/eth_bond_8023ad_private.h > @@ -15,12 +15,12 @@ > #include "rte_eth_bond_8023ad.h" > > #define BOND_MODE_8023AX_UPDATE_TIMEOUT_MS 100 > -/** Maximum number of packets to one slave queued in TX ring. */ > +/** Maximum number of packets to one slave queued in RX ring. */ > #define BOND_MODE_8023AX_SLAVE_RX_PKTS 3 > /** Maximum number of LACP packets from one slave queued in TX ring. */ > #define BOND_MODE_8023AX_SLAVE_TX_PKTS 1 > /** > - * Timeouts deffinitions (5.4.4 in 802.1AX documentation). > + * Timeouts definitions (6.4.4 in 802.1AX documentation). There are multiple updates in the document reference, section 5 -> 6, since the old code is consistent about section 5, can it be because of document version change? If so should we document the document version to prevent same thing happen again? <...> > > -#ifdef __cplusplus > -} > -#endif > - > /** > * Configure a slave port to start collecting. > * > @@ -331,4 +327,9 @@ rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id); > int > rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id, > enum rte_bond_8023ad_agg_selection agg_selection); > + > +#ifdef __cplusplus > +} > +#endif > + This is not typo or whitespace, it seems we misplaced the cpp block, so this may result issues for cpp applications using this header, I wonder if we should have separate patch for fixes? > #endif /* RTE_ETH_BOND_8023AD_H_ */ > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index 84f4900..f6003b0 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -158,7 +158,8 @@ const struct rte_flow_attr flow_attr_8023ad = { > > int > bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev, > - uint16_t slave_port) { > + uint16_t slave_port) > +{ OK to typo fixes, but not sure about the syntax fixes, they corrupt the git history for little benefit, I think better to fix these when this code is changed for some other functional reason. What to you think to drop these changes? And overall perhaps this change can be split into more patches, that also helps backporting: - spelling error, typo, whitespace fixes - Document reference fix - ifdef __cplusplus fix