From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, yinan.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions
Date: Fri, 2 Jul 2021 09:40:45 +0200 [thread overview]
Message-ID: <1bea9752-44b3-ffc5-71af-eff4d13d7d61@redhat.com> (raw)
In-Reply-To: <1622189463-392610-3-git-send-email-jiayu.hu@intel.com>
On 5/28/21 10:11 AM, Jiayu Hu wrote:
> This patch is to add thread unsafe version for async register and
s/is to add/adds/
> unregister functions.
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> doc/guides/prog_guide/vhost_lib.rst | 12 +++
> lib/vhost/rte_vhost_async.h | 42 ++++++++++
> lib/vhost/version.map | 4 +
> lib/vhost/vhost.c | 161 +++++++++++++++++++++++++++---------
> 4 files changed, 178 insertions(+), 41 deletions(-)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
> index d18fb98..6b2745f 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -253,6 +253,12 @@ The following is an overview of some key Vhost API functions:
> vhost invokes this function to get the copy data completed by async
> devices.
>
> +* ``rte_vhost_async_channel_register_thread_unsafe(vid, queue_id, features, ops)``
> + Register a vhost queue with async copy device channel without
> + performing any locking.
> +
> + This function is only safe to call from within vhost callback functions.
I'm not sure with this, AFAICS .new_device() is called without the lock
held, so is that safe? Since .new_device() is the first time the app
gets required device info to use the Vhost API, that might not be an
issue, though.
next prev parent reply other threads:[~2021-07-02 7:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 8:11 [dpdk-dev] [PATCH 0/2] provide " Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 1/2] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-02 7:36 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-20 7:18 ` Maxime Coquelin
2021-07-20 7:45 ` Hu, Jiayu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-20 7:25 ` Maxime Coquelin
2021-07-21 6:16 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Xia, Chenbo
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-19 2:25 ` Xia, Chenbo
2021-07-19 7:20 ` Maxime Coquelin
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-19 2:27 ` Xia, Chenbo
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-16 6:03 ` Xia, Chenbo
2021-07-16 6:18 ` Hu, Jiayu
2021-07-16 6:27 ` Xia, Chenbo
2021-07-16 6:34 ` Hu, Jiayu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-16 6:54 ` Xia, Chenbo
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 2/3] vhost: rework async feature struct Jiayu Hu
2021-07-07 6:39 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions Jiayu Hu
2021-07-02 7:40 ` Maxime Coquelin [this message]
2021-07-05 1:35 ` Hu, Jiayu
2021-07-05 8:58 ` Maxime Coquelin
2021-07-06 8:36 ` Hu, Jiayu
2021-06-04 7:18 ` [dpdk-dev] [PATCH 0/2] provide " Maxime Coquelin
2021-06-04 7:24 ` Maxime Coquelin
2021-06-07 8:07 ` Hu, Jiayu
2021-06-07 13:20 ` Maxime Coquelin
2021-06-08 6:36 ` Hu, Jiayu
2021-06-29 5:36 ` Hu, Jiayu
2021-07-01 15:42 ` Maxime Coquelin
2021-07-02 0:53 ` Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bea9752-44b3-ffc5-71af-eff4d13d7d61@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).