From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B8EEAA49C; Fri, 12 Jan 2018 16:04:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 07:04:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,349,1511856000"; d="scan'208";a="9116034" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by fmsmga007.fm.intel.com with ESMTP; 12 Jan 2018 07:04:21 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org References: <1761335.2jqO9XcO2K@xps> From: "Burakov, Anatoly" Message-ID: <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com> Date: Fri, 12 Jan 2018 15:04:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1761335.2jqO9XcO2K@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 15:04:26 -0000 On 12-Jan-18 2:59 PM, Thomas Monjalon wrote: > 12/01/2018 15:17, Anatoly Burakov: >> proc_info app is compiled unconditionally on Linux, but it's >> actually dependent on librte_ethdev library, which prevents >> DPDK from building without librte_ethdev library enabled. >> >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info") >> Cc: maryam.tahhan@intel.com >> Cc: stable@dpdk.org > > nit: please insert a blank line here > >> Signed-off-by: Anatoly Burakov >> --- >> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd >> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info >> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y) >> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info >> +endif >> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > > What about pdump and testpmd? > > I guess a lot of things do not compile without ethdev, isn't it? > True, however one can still disable testpmd compilation with a config option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a new config option (i.e. CONFIG_RTE_PROC_INFO)? -- Thanks, Anatoly