From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B2CA09E9; Mon, 14 Dec 2020 10:57:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E57974F90; Mon, 14 Dec 2020 10:57:31 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DD3E74C7B for ; Mon, 14 Dec 2020 10:57:28 +0100 (CET) IronPort-SDR: L668tAUrQKl1e5ANFEXuVDqupUjmh/w+mGYL6CV4ZrXXbclGvOymVn3dAT6+m8K6a/bo79wgS0 Qkd8WLbTA0pQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="174826716" X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="174826716" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 01:57:25 -0800 IronPort-SDR: pJrTLX/jGl1HFq+ObP3pt+oq1jXZV7PXlRzyY47O1C22LTpR1vrKDECSKwzUFWZa4saiOldrpH NzJoKOzcQa8Q== X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="332646853" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.52]) ([10.213.201.52]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 01:57:23 -0800 To: Liron Himi , "bruce.richardson@intel.com" Cc: "dev@dpdk.org" , Akhil Goyal References: <20201202130529.7332-1-lironh@marvell.com> <20201202130529.7332-2-lironh@marvell.com> From: Ferruh Yigit Message-ID: <1c3fcb12-a6c7-d5ee-1a20-c57416ac3433@intel.com> Date: Mon, 14 Dec 2020 09:57:20 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/13/2020 8:06 PM, Liron Himi wrote: > > -----Original Message----- > From: Ferruh Yigit > Sent: Wednesday, 9 December 2020 12:50 > To: Liron Himi ; bruce.richardson@intel.com > Cc: dev@dpdk.org; Akhil Goyal > Subject: [EXT] Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers > > External Email > > ---------------------------------------------------------------------- > On 12/2/2020 1:05 PM, lironh@marvell.com wrote: >> From: Liron Himi >> >> With pkg-config support available within musdk library, meson option >> 'lib_musdk_dir' can be removed. >> PKG_CONFIG_PATH environment variable should be set appropriately to >> use the musdk library. >> >> Signed-off-by: Liron Himi >> Reviewed-by: Liron Himi >> --- >> drivers/common/mvep/meson.build | 14 +++++--------- >> drivers/crypto/mvsam/meson.build | 15 +++++---------- >> drivers/net/mvneta/meson.build | 19 +++++-------------- >> drivers/net/mvneta/mvneta_ethdev.h | 1 + >> drivers/net/mvpp2/meson.build | 15 +++++---------- >> meson_options.txt | 2 -- >> 6 files changed, 21 insertions(+), 45 deletions(-) >> > > Hi Liron, > > +1 to this change, but can you please make a new version to include > +build > related document changes into this same patch? > > Second patch updates document, both for this build related issues and other issues like new musdk version and supported features etc.. Instead you can move build related changes to this patch, and separate second patch for crypto and net, so that it can have proper commit logs for each and can be reviewed easier. > > [L.H.] the support for the pkg-config, which meson build relay on, requires newer musdk version. Can I create a platform doc for all Marvell ARMADA platforms? Not sure if a platform doc is required just to document external library dependency. But if there is more to add to platform document, can you sent it as separate patch so it can be reviewed without blocking this set?