From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3A70A1B1F2 for ; Wed, 12 Dec 2018 12:27:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 03:27:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,344,1539673200"; d="scan'208";a="117719941" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.93]) ([10.237.220.93]) by orsmga002.jf.intel.com with ESMTP; 12 Dec 2018 03:27:51 -0800 To: "tone.zhang" , dev@dpdk.org Cc: gavin.hu@arm.com, honnappa.nagarahalli@arm.com, Steve.Capper@arm.com, stephen@networkplumber.org, nd@arm.com References: <1542595044-27145-1-git-send-email-tone.zhang@arm.com> <1544613959-14349-1-git-send-email-tone.zhang@arm.com> From: "Burakov, Anatoly" Message-ID: <1c4528d9-7c19-c781-8d83-9e790dc81ffc@intel.com> Date: Wed, 12 Dec 2018 11:27:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <1544613959-14349-1-git-send-email-tone.zhang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] pci_vfio: Support 64KB kernel page_size with vfio-pci driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 11:27:54 -0000 On 12-Dec-18 11:25 AM, tone.zhang wrote: > With a larger PAGE_SIZE it is possible for the MSI table to very > close to the end of the BAR s.t. when we align the start and end > of the MSI table to the PAGE_SIZE, the end offset of the MSI > table is out of the PCI BAR boundary. > > This patch addresses the issue by comparing both the start and the > end offset of the MSI table with the BAR size, and skip the mapping > if it is out of Bar scope. > > The patch fixes the debug log as below: > EAL: Skipping BAR0 > > Signed-off-by: tone.zhang > Reviewed-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper > Reviewed-by: Anatoly Burakov > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly