From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E50742D15; Wed, 21 Jun 2023 16:42:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21C114068E; Wed, 21 Jun 2023 16:42:47 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2076.outbound.protection.outlook.com [40.107.212.76]) by mails.dpdk.org (Postfix) with ESMTP id 325684003C for ; Wed, 21 Jun 2023 16:42:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2TBU5bYiS1gmIQgNjR3D7FXsarAX24XPR63HBfV7CzqOa9GyM4SDvOF8NzGHjKys1KjDvPjudiU681+13AOoroQtKoPGwG9TJEPDoPRqQrHGu5c3EPWwz55qVkfdMMx24LebCRyv/OiWgKa3H25dOflTkuWFJS01rHkH1Q1LXndWh/daPlzQcrFP520pc5KgtUho5Ancqzxw0SQPKGDaa8FTg9GYF5MbbmfZgIRF3d8AytMy8sP/CDCvr29W9eIiLRBkGJHxlrjPjC+xD8gXWJ+xWfNUL1xelEmWhLSjzxV1r00Wh6Y92lnak9Ko1MCh1NpTTmm9kuwupZOKwKRnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f5WVDE3rPKmEuQc2RjvnmPG9soiTvjuci4JqdaSClxc=; b=BqbUaXJXmG6xqw4YEU/Wb8X8FPtl1Db8EVD0KT1/vas7Lp+Z+JDnphzZw9DBKHnYkbPJl6WzCUhGby4L5clUxP0kd8H0fv3HwbHV21av/o0JQV6SDtNRc44H2fh7Wp9eBYAOi1460pYftegHfqV+IiaCcA0g15rjfE6Qca6le+iwm4kOccG1w6xjRBBM3CfzZ+srlHs0UVEzpZUsf8UQ5n6jlC4TIcteVTUx5dp1zizY5ZY+jSTidd0n3eJKKAMGRV9QEbI4jofyHtHfOYswoXBWNXbGRhx89BTLqD6SpKF9Y+yY9BFMpWbqtjLOX8KWyoh5wPD5s7up4P3GLT4EeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f5WVDE3rPKmEuQc2RjvnmPG9soiTvjuci4JqdaSClxc=; b=hDkddH0RkSqgNnrXJgG5NuAHmnXS6t0KS9RrpiL1crhIgxlAEzOKl5lETycIYZNTn9SnaSgWhj7NZyxQtzxqiQXWdtqbxZo4dAQUX8Pqrg3k5juuEis3FhOE2DeJ4ugzZRdD22o7rwgsC1q3J/OtzKv+/pOcdqT5wS1PRZf2wFI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB9031.namprd12.prod.outlook.com (2603:10b6:208:3f9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Wed, 21 Jun 2023 14:42:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 14:42:44 +0000 Message-ID: <1c544eeb-5785-1619-3fa3-3ccc8cdfafac@amd.com> Date: Wed, 21 Jun 2023 15:42:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net/nfp: changes to link status reporting Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, James Hershaw , Long Wu References: <20230615032740.1247408-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230615032740.1247408-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0177.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB9031:EE_ X-MS-Office365-Filtering-Correlation-Id: 20cfffda-7e68-4424-3f5e-08db7265c5fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nvc5FCNgpxsvtmO7o7CQ52tRBQ8ibtfA+uap1kUTl/ctdp82qTfrMGx4MYUSaQWoUMkp80CsQbsfx+Y6LUfLD2J7QxdkR69NvdaBgUBmK5B9yguN8fT0IGj3dIdsIxxJRa/A/Z/pcF/nmHBa8jEO0vM+BvlBNby9o72hzAUm2d2/H5RoKjiIinJir4KNd+cj02ocM+YFFNEv/6C4GdTdC+XO/w6GIi74n+2RRFJY6iMr/U3bLrnQfAPhWb36XEgz7pijgrqcZal/KP0y3S5TBHSe8ZcYInUdGQlVuP/fju3CQfXEq94EvDinfJq6t9YjkAt+aLrjfd/mwqdOgXU/3z1QC7o0+Kle4fYKQs/xsiK6YBkfKqroxl75OvlonFp4rJgB0n2EwOtMDsnf90Kk8+u9m2di4hj6JiWKoW8Xampnozp7h6KLvhwKRn9sPAjQiQe+PB1DJdaMGdpxrMFgIbgfP52f+UwxbqdoUs1T/ReDYHqECXYzDN528co9+raoDAOyN/4w3Obf1k4/1LUeSTeP4RNg2nOSEmhysGwbnd7LlZ5RdVpd9Bh9nxh93YC24YNZHzW0moWH1xHO26Y8OaGgDtl/gYmjcfo3hYaUV4B7EADXGAfQjyO/w/sYCRSeW6zKK5xdNTDyO1L/Jqu/TA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199021)(8676002)(186003)(66556008)(8936002)(66476007)(5660300002)(66899021)(66946007)(54906003)(4326008)(26005)(316002)(6486002)(6666004)(41300700001)(478600001)(36756003)(53546011)(6512007)(38100700002)(6506007)(86362001)(31696002)(83380400001)(2906002)(31686004)(44832011)(2616005)(66574015)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXdZTnRlbDZhNHRHWTVRSS9VN2xybzdtR2xSSzQycmw1dEdqOW4vRmtkQ2g5?= =?utf-8?B?MmM0d0M5ek5SNXhsVWhDdTNwTXUzcUFWbHpGY2I2SFh2d25xNGprNGxJQTc5?= =?utf-8?B?Zk03cjVHdXFQaU9ORzljVktDeG5mSEUybFAydExaTnA3cnJWbXF5TUszOEQ4?= =?utf-8?B?OGxpanRmVTV6eFR4UjIxNzhoYlBtbEl5S1dIV1pEbWJ6NUFEcEFNSS9GRTY5?= =?utf-8?B?Znh5TCtXS1FrS25XSUZoT1Z0VnF1OEV0R1VrUEZITUtYZSsvN3R2MXhJYzJD?= =?utf-8?B?SXZyQVFManlvcHgySzZ5UG9GcFlnVTRISmVyNEFGRVhQY0JRSmVFYzNLSTlZ?= =?utf-8?B?cm9wT2FMQTczS29wT0t0eGRYS0lpekN1MTV0UTZ0SXlBTWVhWVh0MTkzUEFX?= =?utf-8?B?RHRUU1gwR2owZzNOeExqL0FkM3BiZVZqVmF5Q3AxL2xUdTJlWDgxV2tYenk2?= =?utf-8?B?RndhUy9hYnluQ2U3cGZqQVRXek1UbUorV3l2NXZVVDhZelBsWExIdk83VmhD?= =?utf-8?B?aEo4U0lSRHh4a1pNZzFOK2x0eitSQ3kydWgwWStPYVlNOEFLdnhwMGVQYnhO?= =?utf-8?B?UUR2aG1RLzVJL1E4bkJNN1EydW5rMTIrYWcwN2w4L1BSRFpRN3RkMlBIazVz?= =?utf-8?B?VGlwYjJuUUxrcVFwOU0zbUlDYzViWFRGclBUM0syaTU3b0lvWC9SVVp4aThG?= =?utf-8?B?UldYTWR3SEZuWkkrOXc4SWZTaVMzcitqbVZQendJWWRnTis0Wmt1a3pOSVlD?= =?utf-8?B?RWdkZCtNbXB5V0kxQVRkR2VTSEpzZ25LNTZCc1JFcnozU2VyTXdDMzZ4Wjk2?= =?utf-8?B?OHl1dk12dEw0K01veDFnVXNzeVBYbGV5dzVzN2N0aDBCQnBTVDF0aTFXZnR0?= =?utf-8?B?bHZFYTIzOGpIYTN3Q3VvVXlOdUdVLytKenk0VjJkK3o4eWN3Y1p0T0dxZzcx?= =?utf-8?B?MEhGc01IZWZYTllyTmFuSkJCbE9UeVhabkd0OUZwWTFjRjlYUVZpemg5OU5F?= =?utf-8?B?T0dmVi9mb0FjM1k1a0RqNXpzcS9Xd1dOYUdkdDNDbnU2Zm1idnZJNTdPVElN?= =?utf-8?B?TEY2aHhoY0thOHY3NDM4ZHhGSWxveWJOQWlWMnNDcFFVc0JwdWxyUERhOSs4?= =?utf-8?B?UHhwYTJPQ3pINmRvZTArSU96MmVyTFgxZGhmT1U1WEtTYUVFRVhNVDRSZWdk?= =?utf-8?B?V2VUci9Ia3pYQ2ZuK25oZm1NdjFmQkdUMnVIeU8vMVpuYWVKZlNzYjNpcmUw?= =?utf-8?B?UEVCclEwUnVERVZzQjRWZ0I1bzNtdWFWcTd6UjRJRjJ6MERvRHBGcXlLOERj?= =?utf-8?B?TWtzWnZRSXVnaFlvNllGdlg2R1FEbkNWV1QyQ2o4S1VEeFBUdGhhUm5pK3VM?= =?utf-8?B?MXI2VERsMWIrdWpLL2Z6SjdaTkM0NXdHZXNqOUlER2w5UTExY01MZmY4aExS?= =?utf-8?B?bEl6V2MydGZuMUlYaG84RVVXR2c5SklmMVdLY1dSSnJ2S3JmUDloeFpnc3R4?= =?utf-8?B?VmNDTFN0SXZEL0V3dTluUGh3cGVEQzdTTndYbm4xM1lwK3FKT2hIOWZFVWx5?= =?utf-8?B?dFpSZVorNHlUZGNEWVFzbEVxNmN5c2ZaZ05Kd20xR2ZhSnRVcTh3VUI0L0NK?= =?utf-8?B?c2pQeC9COWZ6d25UTng5Q3JwNVNVNEc1SXZ1dG1OcXdtSTNDaFVWVm1zcHJm?= =?utf-8?B?dkFLTTJRMlZoMFVSNlQvd3B6V1JmcURpVDFmR2drbDV0SENGWHZreUJ1MFAx?= =?utf-8?B?aXB3QTRDcnhXVFRBL29rUW9iQ0k4MG53bTlGUEIrVndwSVlyN2JhZUlBRzM1?= =?utf-8?B?VWQwWEFuM1dpdEh0SWJDWWg1am1BNUVKMWdERmNrYnBPV3R3UTB0TUt3R24r?= =?utf-8?B?YVBMdS9tcEtFNnJTQ3IxcEFLM29zTnFCVlhWT2RMRmpMdG1xTlB4aTZqNVdk?= =?utf-8?B?WmVNWi96eDN4V25GRk52WHo4WitjU3VrUG9JK3dzaDZGdXpSa1ZldXZpNmlR?= =?utf-8?B?ZmxIRmk0Q2ZkUVlDYUZObFhaK0daenYwYmpDSmFDMmRxR3hEbzI4SVc3V0Zh?= =?utf-8?B?Ri9yL2pFYk5LanZROWRkYzQ0b0ZkQTQ0ZjNmWTBlTXVpT2F2UVB3UFdiYitW?= =?utf-8?Q?J+bW3dj/NKfzFhSCbgPGVJr7E?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20cfffda-7e68-4424-3f5e-08db7265c5fa X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 14:42:44.4244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TrCYxZUCMter+fqmsz2POgf2xpkf55gUXNqLIiH+48x6p95NAFN3G0WTofCTFSJF X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9031 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/15/2023 4:27 AM, Chaoyong He wrote: > From: James Hershaw > > The NFP PMD driver retrieves the linkspeed by reading the > NFP_NET_CFG_STS_LINK register. This register is not set by all versions > of the firmware. Changes in this patch include: > > Addition of listener function to deal with control messages of type > NFP_FLOWER_CMSG_TYPE_PORT_MOD being received by the PMD. This ensures > that the up/down status of the port is updated when a version of > firmware is being used that does not write the link status to the > NFP_NET_CFG_STS register. > > Update the nfp_flower_repr_link_update() function to preferably read the > linkspeed from the port table, while keeping the old lookup method as a > fallback in case that is not supported. > > Signed-off-by: James Hershaw > Reviewed-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.