From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5984EA0524; Mon, 27 Jul 2020 06:25:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04F351BFC8; Mon, 27 Jul 2020 06:25:00 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C34332B8D for ; Mon, 27 Jul 2020 06:24:58 +0200 (CEST) IronPort-SDR: 7oaMvN9YSTJLPQmLwspfmthleCSKgjSdECPCqaOifMRAzj3L3f9Ml7lZTZjwlPp7I2A49kDrZN 1ORLc6XqhYSg== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="212479113" X-IronPort-AV: E=Sophos;i="5.75,401,1589266800"; d="scan'208";a="212479113" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2020 21:24:57 -0700 IronPort-SDR: Vlij1nSwOBlz3kMKi7q+iBV3XHpOcmxyKQn7xc+ZtoYzgUI0DbWEsx3Z+Ly23z6neg+2GXr7Fc FTQs63dKx5cA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,401,1589266800"; d="scan'208";a="327894790" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176]) ([10.67.68.176]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 21:24:55 -0700 To: Guinan Sun , dev@dpdk.org Cc: Beilei Xing , Damian Milosek References: <20200721074000.30449-1-guinanx.sun@intel.com> <20200721074000.30449-7-guinanx.sun@intel.com> From: Jeff Guo Message-ID: <1c657751-fb99-ff5f-8e82-1e8c0cc448fc@intel.com> Date: Mon, 27 Jul 2020 12:24:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721074000.30449-7-guinanx.sun@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 6/8] net/i40e/base: add disable unused ports capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, guinan On 7/21/2020 3:39 PM, Guinan Sun wrote: > This patch adds support for "Disable Unused Ports" functionality. "This patch adds support for disabling unused ports" is enough for reader i think. And use 2 verb is not good in title, "Support unused ports disabling" or other you want. > > Signed-off-by: Damian Milosek > Signed-off-by: Guinan Sun > --- > drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + > drivers/net/i40e/base/i40e_common.c | 6 ++++++ > drivers/net/i40e/base/i40e_type.h | 1 + > 3 files changed, 8 insertions(+) > > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h > index e1018ed49..c7686b0d3 100644 > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h > @@ -440,6 +440,7 @@ struct i40e_aqc_list_capabilities_element_resp { > #define I40E_AQ_CAP_ID_SDP 0x0062 > #define I40E_AQ_CAP_ID_MDIO 0x0063 > #define I40E_AQ_CAP_ID_WSR_PROT 0x0064 > +#define I40E_AQ_CAP_ID_DIS_UNUSED_PORTS 0x0067 Please double check if it is "0x0066" or "0x0067", if it is conform, please add my ACK for this patch at next version. > #define I40E_AQ_CAP_ID_NVM_MGMT 0x0080 > #define I40E_AQ_CAP_ID_FLEX10 0x00F1 > #define I40E_AQ_CAP_ID_CEM 0x00F2 > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c > index 85c22849e..65317f6c6 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -4021,6 +4021,12 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, > "HW Capability: wr_csr_prot = 0x%llX\n\n", > (p->wr_csr_prot & 0xffff)); > break; > + case I40E_AQ_CAP_ID_DIS_UNUSED_PORTS: > + p->dis_unused_ports = (bool)number; > + i40e_debug(hw, I40E_DEBUG_INIT, > + "HW Capability: dis_unused_ports = %d\n\n", > + p->dis_unused_ports); > + break; > case I40E_AQ_CAP_ID_NVM_MGMT: > if (number & I40E_NVM_MGMT_SEC_REV_DISABLED) > p->sec_rev_disabled = true; > diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h > index 0eeb55975..cf4134583 100644 > --- a/drivers/net/i40e/base/i40e_type.h > +++ b/drivers/net/i40e/base/i40e_type.h > @@ -425,6 +425,7 @@ struct i40e_hw_capabilities { > u32 enabled_tcmap; > u32 maxtc; > u64 wr_csr_prot; > + bool dis_unused_ports; > bool apm_wol_support; > enum i40e_acpi_programming_method acpi_prog_method; > bool proxy_support;