From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1701143CEC;
	Wed, 20 Mar 2024 02:16:40 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D776B4029F;
	Wed, 20 Mar 2024 02:16:39 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id ED93140298
 for <dev@dpdk.org>; Wed, 20 Mar 2024 02:16:37 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.19.88.105])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4TzrGp4WTpzNmGy;
 Wed, 20 Mar 2024 09:14:42 +0800 (CST)
Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84])
 by mail.maildlp.com (Postfix) with ESMTPS id 80F04140158;
 Wed, 20 Mar 2024 09:16:35 +0800 (CST)
Received: from [10.67.121.193] (10.67.121.193) by
 dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.35; Wed, 20 Mar 2024 09:16:35 +0800
Message-ID: <1c70bc43-27e0-4b40-8dee-f6355b6da30f@huawei.com>
Date: Wed, 20 Mar 2024 09:16:34 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] ethdev: support setting lanes
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <aman.deep.singh@intel.com>,
 <yuying.zhang@intel.com>, <thomas@monjalon.net>,
 <andrew.rybchenko@oktetlabs.ru>, <liuyonglong@huawei.com>,
 <fengchengwen@huawei.com>, <haijie1@huawei.com>, <lihuisong@huawei.com>
References: <20240312075238.3319480-1-huangdengdui@huawei.com>
 <20240312075238.3319480-2-huangdengdui@huawei.com>
 <20240318200241.34223049@hermes.local>
From: huangdengdui <huangdengdui@huawei.com>
In-Reply-To: <20240318200241.34223049@hermes.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.193]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml500011.china.huawei.com (7.185.36.84)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



On 2024/3/19 11:02, Stephen Hemminger wrote:
> On Tue, 12 Mar 2024 15:52:36 +0800
> Dengdui Huang <huangdengdui@huawei.com> wrote:
> 
>> -		ret = snprintf(str, len, "Link up at %s %s %s",
>> +		ret = snprintf(str, len, "Link up at %s %ulanes %s %s",
> 
> Don't you want a space after %u?
> 
> Could you make it so that lanes is only part of the message if non-default value
> is used?
Ok, I'll do it in the next version.