From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gandi.net (mail4.gandi.net [217.70.183.210]) by dpdk.org (Postfix) with ESMTP id 7B3552951 for ; Fri, 6 May 2016 17:51:29 +0200 (CEST) Received: from mfiltercorp2.gandi.net (mfiltercorp2.gandi.net [217.70.183.154]) by gandi.net (Postfix) with ESMTP id 6E256E3A04; Fri, 6 May 2016 17:51:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfiltercorp2.gandi.net X-Spam-Flag: NO X-Spam-Score: -101.556 X-Spam-Level: X-Spam-Status: No, score=-101.556 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_40=-0.001, RP_MATCHES_RCVD=-0.555, USER_IN_WHITELIST=-100] autolearn=disabled Received: from gandi.net ([IPv6:::ffff:217.70.183.210]) by mfiltercorp2.gandi.net (mfiltercorp2.gandi.net [::ffff:217.70.183.154]) (amavisd-new, port 10024) with ESMTP id 9xf_sJtKkBBm; Fri, 6 May 2016 17:51:28 +0200 (CEST) Received: from [217.70.181.31] (freeside.gandi.net [217.70.181.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by gandi.net (Postfix) with ESMTPSA id D61F5E39F7; Fri, 6 May 2016 17:51:28 +0200 (CEST) To: helin.zhang@intel.com References: <1441003305-24055-1-git-send-email-vladz@cloudius-systems.com> From: Nikita Kozlov Cc: dev@dpdk.org Message-ID: <1c73361e-b5da-8fc2-5953-30f60637c597@gandi.net> Date: Fri, 6 May 2016 17:51:28 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 15:51:29 -0000 Hello, On 09/ 1/15 07:34 AM, Zhang, Helin wrote: >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Monday, August 31, 2015 2:42 PM >> To: dev@dpdk.org >> Cc: Zhang, Helin; Ananyev, Konstantin; avi@cloudius-systems.com; Vlad >> Zolotarov >> Subject: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX >> >> HW requires it regardless the presence of the VLAN tag in the received frame. >> Otherwise Rx frames are being filtered out on the MTU-4 boundary. > Maximum packet length could have different meanings from MTU. I agree with > you to have it be regardless of vlan tag length. > >> Signed-off-by: Vlad Zolotarov >> --- >> drivers/net/i40e/i40e_rxtx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index >> eae4ab0..22aaeb1 100644 >> --- a/drivers/net/i40e/i40e_rxtx.c >> +++ b/drivers/net/i40e/i40e_rxtx.c >> @@ -3156,7 +3156,7 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq) >> rx_ctx.hsplit_0 = I40E_HEADER_SPLIT_ALL; >> else >> rx_ctx.hsplit_0 = I40E_HEADER_SPLIT_NONE; >> - rx_ctx.rxmax = rxq->max_pkt_len; >> + rx_ctx.rxmax = rxq->max_pkt_len + I40E_VLAN_TAG_SIZE; > It needs to take into account the double vlan case, and also VF case. > It seems it needs more code changes. Thank you for the contribution! I was wondering if this "bug" haven't been forgotten ? Even if it his not patched yet maybe it is worth an entry in the documentation ? > > Regards, > Helin > >> rx_ctx.tphrdesc_ena = 1; >> rx_ctx.tphwdesc_ena = 1; >> rx_ctx.tphdata_ena = 1; >> -- >> 2.1.0