From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 5D24B36E
 for <dev@dpdk.org>; Fri, 24 Mar 2017 12:00:50 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 24 Mar 2017 04:00:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,214,1486454400"; d="scan'208";a="80589239"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by fmsmga006.fm.intel.com with ESMTP; 24 Mar 2017 04:00:48 -0700
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
References: <dd51cd87-72b4-fa89-3dc1-b79c32df1355@intel.com>
 <1490340531-11403-42-git-send-email-rasesh.mody@cavium.com>
Cc: Dept-EngDPDKDev@cavium.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <1cabe096-47c2-401f-de66-524590fede83@intel.com>
Date: Fri, 24 Mar 2017 11:00:47 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490340531-11403-42-git-send-email-rasesh.mody@cavium.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 41/61] net/qede/base: add support for
 previous driver unload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Mar 2017 11:00:50 -0000

On 3/24/2017 7:28 AM, Rasesh Mody wrote:
> New driver/management fw load request sequence for handling previous
> driver unload.
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

Hi Rasesh,

Patch by patch build broken with this patch with following build error,
and fixed back with patch 50/61:

.../drivers/net/qede/base/ecore_mcp.c:624:2: error: signed shift result
(0xF00000000) requires 37 bits to represent, but 'int' only has 32 bits
[-Werror,-Wshift-overflow]
        ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FORCE,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro
'ECORE_MFW_SET_FIELD'
        (name) &= ~((field ## _MASK) << (field ## _SHIFT));             \
                    ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
.../drivers/net/qede/base/ecore_mcp.c:626:2: error: signed shift result
(0xF0000000000) requires 45 bits to represent, but 'int' only has 32
bits [-Werror,-Wshift-overflow]
        ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FLAGS0,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro
'ECORE_MFW_SET_FIELD'
        (name) &= ~((field ## _MASK) << (field ## _SHIFT));             \
                    ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
<...>