From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC802A0560; Tue, 18 Oct 2022 19:06:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6ACF4069C; Tue, 18 Oct 2022 19:06:04 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) by mails.dpdk.org (Postfix) with ESMTP id DD6AF40395 for ; Tue, 18 Oct 2022 19:06:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nInlXM6j5R1A0wpFF0wIU/V8k8UMwIwHc8MCdtSqAYbS3hZmQNDuHkGo2fykEoZqRFBbzmK+RJ2e0RCWnt22a+9ECeRDsgjObVTUx/bcD2/H80g+2DXXryVu0I26LXGfUfLyUFRaP1jMSaXSmiMc85FCuxnUmMUoayTi07GqodRTaK9ZWHVWreo/Abub3fwpwxmiAu159PHWZMvcGV5b9zags2XZ+bxtQLC2UTVKwWYRgqfjR1EaOhdWlmLp2MDLcHQ8sYWoD6DK0m0XoljpHN3Uv2StCa3vW6+LxRjkyLFA3j+lZM8dnTB+nLVY4uJb0AZ/h/kPnCKtZ3AvNH6Y5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1aIkg3Y/t4nOuN7TFLpTEwvod0QJ1SQd9ZeRM5jcxts=; b=hN//5ocCRLZ2q5M82J0Y9NEHg51TGqxw0BEowTxaFYOue74Pp/3oHRKBnpe8IKl72a3K9M+YACIPY+Dk90GCOkpPKWhVcLvg+XMfPWVGCzZ8dDtx1m4/5OB3QEvqWcJk9ueiJP/g7n9AeBuz0K/foXrmNXmO6BzWPyOhbLaodSVCIjdvhtyH0nei3XKTOLvQ1OJWP1t50nnvjiVM31W/XFSLB5xljYhM/tROGRSuyCC5CL+c9xjzijkV724bYzaGO2753TBmHl37dUQJQVIvGy/Nz6U25ObdgGlFIbd+bGCmpXyj4/enBEbZg9rpZZ79RpRa2vGpajx5MYAxNVSjsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1aIkg3Y/t4nOuN7TFLpTEwvod0QJ1SQd9ZeRM5jcxts=; b=mZyWlCV0xgSQNMMAhyYaF+bfMDt2/LIf482qjZVo2K9kTO73sXD5t4XbzQZz96yx4tYefaphaDKXHbEd0Jfpv6zDAbp0mHMteXQTkmpdBo8hozySckzQBMWS67vL2c4noFZVbrFvGcmlVxQRgO4Q3iIdNvs62ZGhpwAGTn/+p9o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB5328.namprd12.prod.outlook.com (2603:10b6:5:39f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 17:06:02 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 17:06:02 +0000 Message-ID: <1cd12529-96a3-039d-bc7a-bc1eb8fc62c9@amd.com> Date: Tue, 18 Oct 2022 18:05:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v1 00/35] net/ionic: updates for 22.11 release Content-Language: en-US To: Andrew Boyer , dev@dpdk.org Cc: R Mohamed Shah , Neel Patel , Allen Hubbe References: <20221007174336.54354-1-andrew.boyer@amd.com> <20221011005032.47584-1-andrew.boyer@amd.com> From: Ferruh Yigit In-Reply-To: <20221011005032.47584-1-andrew.boyer@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0427.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::31) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM4PR12MB5328:EE_ X-MS-Office365-Filtering-Correlation-Id: c3795ead-86a1-4912-ee77-08dab12b08fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O/obOFMFG+jMLNGMFhszLts8fpBikcHseViSTrdQ0snvy2F+47vPRaaAuEwIZuZCnDsrOgB0BaadojWNgZny/PbYtUbgjOOan+hzQSr2Ip9b6ltc5FsaRqR2BXR7xjvcIgNoJGO+6uAXENT8uVbe+QbM1n9qwwmhInnBLzYOOObdBl9c5vDYDA4DNucQ8NYm+DtTw1zYDfCmxaf/ZoGjaE6BQwlZ/DrJMmOof7bzZ+T9kTB0/AX98xQoiGLrl54tcEGbY3AcMc3yGKbYEk/W6Z9vRAEEFfj0enCcKxnScsLOQ0eCmw8Div51dy80+qaXzTaaZiGMsfUMz9Rit9WLrIcupxNPpB9PD401lSJddjVdMldE6vEE0q8nZQVGjcYy+bsDa3CbppzP9XABdxMXBZ39wGOoozIFKhbXMPDRSgdNHuFzA6gZHTl2ScD0xgQrEpLcMdjOeAEq5w0dqQilhaadnTGa3tHxinaNsAg2IYpcp99Mwvl9X7dXFjJBlstqpZixA42SzPR7wmckrs9w0ajUO18BuNN8TlAQgYx52jIzS9pfDVFWMX4MVUPokUcRrF1Lo88KzLWJJhygda3KOwGuRis+9kvDQbdSVycm/p6qa4m9z220rzdY32dqstgnpqSAIAzLixWq8M+OiuBpW0SpI8qZ0WHvUd66eXE643Fb5Dy+vDXOpRG1JNcdBbmVeBVF0ksa9+oIEimQOhhDJFMcEfs08d6wm4KwmfgYDTIuQX5UlCawQK6kOp81UXP/VLC1Itw3DBH4DBFaVe2RnKdvEgyCVMKxm1NyTGYHM4mQ4bapw6UHZk0D0LmHRCpX X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(86362001)(31696002)(36756003)(31686004)(38100700002)(2906002)(44832011)(186003)(15650500001)(5660300002)(53546011)(6512007)(2616005)(478600001)(83380400001)(6666004)(26005)(6506007)(4326008)(6486002)(966005)(316002)(54906003)(66946007)(66556008)(66476007)(41300700001)(8676002)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG5UOVVVazFmdXpLcTkzTzBJOGRtNk9WdUV0MFJ6cGlncFFYdGhoanRVbCtM?= =?utf-8?B?ajFYeXFMRnVlMmFUWE56NW9nVitVMy82YkNsREJFQ1BjL3FyVU8rREdFd1gw?= =?utf-8?B?OFFlK1JIa1VNczRqVzJWTlVCNjh0bWljaFVQa0pIRmxUME11RFozTkNGSC9q?= =?utf-8?B?U3Y2dkR6UURoeUs1Y0Q4d3AxKytuT3VWR1BPVm5DMk5rMytzRjFhY2E0dXlr?= =?utf-8?B?OTc5L21aQWZyRlNNYU1BR2tIaUlpWXZObWVTR1lPMDZ5QmNCa28xQ1RUNGNi?= =?utf-8?B?TW1kMnpuY2pkZU5JaXFXRmsydS9nVVNOVGJJamNpNG5BSmVrY0tmUGJSYlRp?= =?utf-8?B?ek5odnVWZVJSenRIdTl6K1k5dFFwYXhPcGJFQmVLaklKaURKUjdtdkxGSW9i?= =?utf-8?B?K0NGYmZtWHV4WDBmM1NvQlhqR3RlN3dSdnVjQmpJTHlkcmJmd3hjNUttbUxE?= =?utf-8?B?L1h2Q1NSV3pLeEJEM2VDTnZ5Y1VSTWVRajJtRmRJR3JzdGFFZXF0dVhNOGFH?= =?utf-8?B?V2VmUHAzZUNWUkRpeHc2aS9SU21kZmNTN252c1lCMzBrLzFGV0dvRDVjSUxh?= =?utf-8?B?U2haN3NoTjZxajFrRFJqQUUxcjdmMVY1M3ZqNTNGTHJzRXNlSEMrU3Vyd1lj?= =?utf-8?B?TGtZT2hxenpDYWx5V09qbmRiQndXSlkxT2psc0MrV1JPc3JBY1hvOXZJOThm?= =?utf-8?B?YjU1WVhRanh3UzkzTnJXTXA4ZXhQUUxQdUVZenhrUlEwakxRcXNyUitVbUxv?= =?utf-8?B?QVR5MHRjWlBwYVJLWHU0bkFoU3VQLzRsVEVkWWo3RjQ1NHYvZS9Edjlya0FV?= =?utf-8?B?YWt0Y2R4Ui83SU9NNWdlVk5HTWxzZ3pNTys2VXBFdllrZjZVRFNKMTFoOFBB?= =?utf-8?B?QnJuWXlDTGYwRUN0N0p2K0ZoaFNvUFp4TW5JckhycUpPSDlUWXlKaXI3Tkk4?= =?utf-8?B?VFZaeHR4anRJaTRpY1JZRVRDTjdNMzNmbklLbk1aNGxpbGNpeVVPMzN5ZXNW?= =?utf-8?B?Z2RJQmR3ekVFY3UvYkc0UUVzOE5HbU9GUDQ2WjBJYXBwMTl1Wnl0V2tXUTlB?= =?utf-8?B?NE05QWI3K1VXd25oOEZhZ3BkRTJLeitZSXg4cFVVRnZnbHhiTjlMQ2RPcGRs?= =?utf-8?B?ZEV0cThqeFlGNHcrbFV4OTI3Q2lRU0FxTDZ6bk9MczZxTzMrOGF2cW5zOXR4?= =?utf-8?B?QkJsQlJTTWFrZnhxY285K0k3V0JpRjEzZFlFVDdkWkk3YncxQzBSK0wwZFZn?= =?utf-8?B?UHNYeGdibGxPK1U5NmNzWDh6OWdhblBVS2Z3a0N0clE1TDZnbmRjYVdBSUxF?= =?utf-8?B?c3VvbVNLeDBUMmZzM1liRzZicUNYbVc0eHZuL2pPR2xFSWd3TXJaaVY5cmd5?= =?utf-8?B?NWF2K1VxeDVqdEU0NTlkTzFVd3hVUzZVUlBxZ2JHTkRlUHVjRUwzbGtrakxR?= =?utf-8?B?SnVUVS9EWGNyL1hqNERPejdLTWxKOVR1MDV4RDVXWS9kVWx0TlZTTzBma0xR?= =?utf-8?B?dGtFSTdXR2FKcmE4M2ZnOUpTR3Zuc1Z6dVpKSTEzem9OclRSbGpaaTYrajl2?= =?utf-8?B?UExtTmVianFrVkptemZyNWEyek0vOHYxdzV6UnllQlVtczJvWVk1S205d0pt?= =?utf-8?B?eFFoRmVQOTVkUkFkbDA5L3J0UFl0N3lQM0c2SmxUNTRpbStyQ0pSSVV0REZU?= =?utf-8?B?WkdUYVVrUTUvVVdKeVV3UnlBSDZWeW1kWTh6QWJzdFd0SHVMNVlqazlETS9F?= =?utf-8?B?aVRxYVc4MmFWVTduSWxKZm1uWlphOHo5TlladGV3cm5xbnExTzNnL0FNMFFP?= =?utf-8?B?RnJCZ05UZ0cwUHpyZXd6Z1lnbVEzWkhYRmt0OG9pN3J0VnFRU0xqMFhRekFj?= =?utf-8?B?cU1FelgzV3E2ckVXbEdzb0lxRFBxMDFQN3YyZ3JqWVgwNUZlM1B0Ni85NWxp?= =?utf-8?B?UmJwSHByTVRubG05Q2poMUErVUcweEVEWjNxV0J1V1RiU0VKMENVUlNidDhz?= =?utf-8?B?YnV5RmwzZDNOWHY2WHVnWnV3bVZ3MC9zSEdmVlJVS3owNnFDYmZleW1mMnhv?= =?utf-8?B?WVBQYjd1QkdZMWlNYXA3TTMyNkkxSVh2aDhDMFY0MlFpbzU5NnVFYUhoZmNi?= =?utf-8?Q?gfWts/FLmtVAvYuV5d7kBRZlZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3795ead-86a1-4912-ee77-08dab12b08fe X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 17:06:02.1481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JIOLhfTl5tLjW1VHwilsdw43TLa9H5w1mVMmNmT2IwfvFWDZGExbBOoHYNJFQx3z X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/2022 1:49 AM, Andrew Boyer wrote: > This patch series provides features and performance improvements > relevant for the upstream release of DPDK 22.11. > > There are some bits (like struct ionic_dev_intf) only useful > for drivers and device types which have not yet been upstreamed. > All of the changes are confined to the ionic PMD. > > Signed-off-by: Andrew Boyer > Signed-off-by: R Mohamed Shah > Signed-off-by: Neel Patel > Signed-off-by: Allen Hubbe > > --- > v1: > * Rebased to avoid conflicts in release notes > * Added missing links to product briefs in patch 6 > > Andrew Boyer (35): > net/ionic: fix up endianness for Rx and Tx handling > net/ionic: fix up endianness for RSS > net/ionic: fix to set the adapter name for logging > net/ionic: fix up the Rx filter save API > net/ionic: fix up reported error stats > net/ionic: update documentation and copyrights > net/ionic: update license terms to remove GPL > net/ionic: update MTU calculations > net/ionic: simplify code by removing doorbell map helper > net/ionic: remove unused identifiers > net/ionic: only allocate interrupts if required > net/ionic: move PCI-specific code to a separate file > net/ionic: only request notifyq interrupt if supported > net/ionic: replace void pointer with actual type > net/ionic: free all buffers during Rx queue stop > net/ionic: precalculate segment lengths on receive side > net/ionic: use a helper variable in packet Tx function > net/ionic: do one-time init of receive descriptors > net/ionic: overhaul receive side for performance > net/ionic: overhaul transmit side for performance > net/ionic: add support for mbuf fast free > net/ionic: do bulk allocations of receive mbufs > net/ionic: add a lookup table for packet type > net/ionic: add a lookup table for checksum flags > net/ionic: advertise supported packet types > net/ionic: add Rx descriptor status functions > net/ionic: add Tx descriptor status function > net/ionic: add Q-in-CMB option controlled by devarg > net/ionic: update array allocations to use calloc > net/ionic: add alignment and socket info in allocations > net/ionic: allow client to specify Tx free threshold > net/ionic: add optimized handlers for non-scattered Rx/Tx > net/ionic: use a helper variable for page size > net/ionic: retry init commands up to five times > net/ionic: add watchdogs to protect each queue type > Hi Andrew, I put some minor comments related to the copyright changes, rest looks good to me. And in this version each patch looks like a new series in patchwork, not sure what caused it, but can you please be sure all patches in series sent by single 'git send-email' command, if it didn't done this way already. And please use '--in-reply-to' for next version: https://doc.dpdk.org/guides/contributing/patches.html#sending-patches Thanks, ferruh