From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 759E010A3; Tue, 17 Jul 2018 11:23:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 02:23:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,365,1526367600"; d="scan'208";a="73001275" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2018 02:23:05 -0700 To: "Pattan, Reshma" , "thomas@monjalon.net" , "dev@dpdk.org" Cc: "Parthasarathy, JananeeX M" , "stable@dpdk.org" References: <1531750337-4708-9-git-send-email-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A373471@IRSMSX109.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: <1cf3a907-a8e4-6675-bdd0-31176c01a7ff@intel.com> Date: Tue, 17 Jul 2018 10:23:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A373471@IRSMSX109.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 09:23:09 -0000 On 17-Jul-18 10:18 AM, Pattan, Reshma wrote: > Hi, > >> -----Original Message----- >> From: Burakov, Anatoly >> Sent: Monday, July 16, 2018 4:16 PM >> To: Pattan, Reshma ; thomas@monjalon.net; >> dev@dpdk.org >> Cc: Parthasarathy, JananeeX M ; >> stable@dpdk.org >> Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list >> >> >>> + { >>> + "Name": "Set rxtx mode", >>> + "Command": "set_rxtx_mode", >>> + "Func": default_autotest, >>> + "Report": None, >>> + }, >>> + { >>> + "Name": "Set rxtx anchor", >>> + "Command": "set_rxtx_anchor", >>> + "Func": default_autotest, >>> + "Report": None, >>> + }, >>> + { >>> + "Name": "Set rxtx sc", >>> + "Command": "set_rxtx_sc", >>> + "Func": default_autotest, >>> + "Report": None, >>> + }, >> >> The above three tests don't look like autotests to me. I have no idea what >> they are for, but either they need a special function, or they need to be taken >> out. >> > > These commands needs to be run manually from test cmd prompt to various set rxtx mode, rxtx rate and rxtx direction . > These can be used to verify pmd perf test with vaiours set of above values. > > So this can be removed from autotest. We do have PMD perf tests in the script - do they call these functions? If they are required for PMD autotests, maybe PMD autotests deserve a special test function calling these commands before running the tests? (if they also work without these commands, then we can perhaps postpone this to 18.11) > >>> + "Name": "User delay", >>> + "Command": "user_delay_us", >>> + "Func": default_autotest, >>> + "Report": None, >>> + }, >> >> This doesn't look like autotests to me. I have no idea what it is for, but either >> it needs a special function, or it needs to be taken out. >> > This is autotest but the name does'nt have the autotest name in it. So I will retain this. OK. -- Thanks, Anatoly