From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71C11429A2; Fri, 21 Apr 2023 03:12:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08FC6410DD; Fri, 21 Apr 2023 03:12:43 +0200 (CEST) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 443CC40E6E for ; Fri, 21 Apr 2023 03:12:40 +0200 (CEST) Received: from loongson.cn (unknown [10.20.42.90]) by gateway (Coremail) with SMTP id _____8Axz_8G40FkccofAA--.49643S3; Fri, 21 Apr 2023 09:12:39 +0800 (CST) Received: from [10.20.42.90] (unknown [10.20.42.90]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxprwF40FkyzYyAA--.2524S3; Fri, 21 Apr 2023 09:12:37 +0800 (CST) Subject: Re: [PATCH 1/1] net/ixgbe: add a proper memory barrier for LoongArch To: qiming.yang@intel.com, wenjun1.wu@intel.com Cc: dev@dpdk.org, maobibo@loongson.cn References: <20230407085041.3966259-1-zhoumin@loongson.cn> From: zhoumin Message-ID: <1cfdd578-774d-f9e8-da23-4b7c29a370c5@loongson.cn> Date: Fri, 21 Apr 2023 09:12:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20230407085041.3966259-1-zhoumin@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: AQAAf8BxprwF40FkyzYyAA--.2524S3 X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjvJXoW7Aw48uw17Xw1rJw1fuw17KFg_yoW8XF4kpF s8Cr1IkryUXw47Cwn7X3yruFyfCF4Sqw4UCrWvyas8C34DX34qq34qgFy5JryDtr1Uu3WI vF47uw43GFZxZFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bxkYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AI xVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04 k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18 MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr4 1lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l IxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4 A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1wL05UUUUU== X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 7, 2023 at 4:50PM, Min Zhou wrote: > Segmentation fault has been observed while running the > ixgbe_recv_pkts_lro() function to receive packets on the Loongson > 3C5000 processor which has 64 cores and 4 NUMA nodes. > > Reason is the read ordering of the status and the rest of the > descriptor fields in this function may not be correct on the > LoongArch processor. We should add rte_rmb() to ensure the read > ordering be correct. > > We also did the same thing in the ixgbe_recv_pkts() function. > > Signed-off-by: Min Zhou > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index c9d6ca9efe..16391a42f9 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1823,6 +1823,9 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > staterr = rxdp->wb.upper.status_error; > if (!(staterr & rte_cpu_to_le_32(IXGBE_RXDADV_STAT_DD))) > break; > +#if defined(RTE_ARCH_LOONGARCH) > + rte_rmb(); > +#endif > rxd = *rxdp; > > /* > @@ -2122,6 +2125,9 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > if (!(staterr & IXGBE_RXDADV_STAT_DD)) > break; > > +#if defined(RTE_ARCH_LOONGARCH) > + rte_rmb(); > +#endif > rxd = *rxdp; > > PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_id=%u " Kindly ping. Any comments or suggestions will be appreciated. Min