From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB4C5A054A; Thu, 11 Feb 2021 14:33:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 226071CC38A; Thu, 11 Feb 2021 14:33:23 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C057D1CC344 for ; Thu, 11 Feb 2021 14:33:20 +0100 (CET) IronPort-SDR: H+J6RQdwJPzyjNdlESyioPZ9+plBIgJsuSBo87xP8QHdwvkPq/QUsXc2KfJRIGGe6Smchj40u+ t3bAjVgkLGfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="169911444" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="169911444" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 05:33:15 -0800 IronPort-SDR: He1fJO8HPguAN2RR6Ks+EBGVqpcdT+Q17hLfks+xHMSI4HGmtrSOMThmEsEWQRFnjFAGFuwYp2 5b1oKJ+1uCjg== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="397258087" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.21.217]) ([10.252.21.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 05:33:13 -0800 From: "Burakov, Anatoly" To: dev@dpdk.org, stephen@networkplumber.org Cc: Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam References: Message-ID: <1d0504f4-1a6e-d268-8c00-bc4189b333d3@intel.com> Date: Thu, 11 Feb 2021 13:33:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: detach memsegs on cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14-Sep-20 12:26 PM, Anatoly Burakov wrote: > Currently, we don't detach the shared memory on EAL cleanup, which > leaves the page table descriptors still holding on to the file > descriptors as well as memory space occupied by them. Fix it by adding > another detach stage that closes the internal memory allocator resource > references, detaches shared fbarrays and unmaps the shared mem config. > > Bugzilla ID: 380 > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2: > - Fixed checkpatch warnings > > Not backporting to stable because this fix isn't critical but is rather > "nice to have". > Hi Stephen, Could you please review this patch for next release? -- Thanks, Anatoly