From: Avi Kivity <avi@scylladb.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] eal: remove another use of register keyword
Date: Mon, 15 Jan 2018 20:18:41 +0200 [thread overview]
Message-ID: <1d4491fc-ef3b-72fc-2b60-7f48228e12a1@scylladb.com> (raw)
In-Reply-To: <1973968.l2YiJ7Szvs@xps>
On 01/15/2018 08:00 PM, Thomas Monjalon wrote:
> 15/01/2018 12:33, Avi Kivity:
>> The 'register' keyword does nothing, and has been removed in C++17.
>>
>> Remove it for compatibility, like commit 0d5f2ed12f9eb.
> Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword")
>
>> Signed-off-by: Avi Kivity <avi@scylladb.com>
> Applied, thanks.
>
> Note that "register" is used in some drivers too:
> git grep -l '\<register\>.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u
> drivers/bus/dpaa/
> drivers/crypto/dpaa2_sec/
> drivers/crypto/qat/
> drivers/event/sw/
> drivers/net/ark/
> drivers/net/avp/
> drivers/net/bnx2x/
> drivers/net/bnxt/
> drivers/net/e1000/
> drivers/net/i40e/
> drivers/net/ixgbe/
> drivers/net/qede/
> drivers/net/sfc/
> drivers/net/vhost/
>
I think those aren't a problem, since they aren't exposed to C++ programs.
prev parent reply other threads:[~2018-01-15 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 11:33 Avi Kivity
2018-01-15 18:00 ` Thomas Monjalon
2018-01-15 18:18 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4491fc-ef3b-72fc-2b60-7f48228e12a1@scylladb.com \
--to=avi@scylladb.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).