[dpdk-dev] [PATCH v1] eal: remove another use of register keyword

[dpdk-dev] [PATCH v1] eal: remove another use of register keyword

[Avi Kivity]

The 'register' keyword does nothing, and has been removed in C++17.

Remove it for compatibility, like commit 0d5f2ed12f9eb.

Signed-off-by: Avi Kivity <avi@scylladb.com>
---
 lib/librte_eal/common/include/arch/x86/rte_byteorder_64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/include/arch/x86/rte_byteorder_64.h b/lib/librte_eal/common/include/arch/x86/rte_byteorder_64.h
index 6289404a3..8c6cf285b 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_byteorder_64.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_byteorder_64.h
@@ -18,11 +18,11 @@
   * Do not use this function directly. The preferred function is rte_bswap64().
  */
 /* 64-bit mode */
 static inline uint64_t rte_arch_bswap64(uint64_t _x)
 {
-	register uint64_t x = _x;
+	uint64_t x = _x;
 	asm volatile ("bswap %[x]"
 		      : [x] "+r" (x)
 		      );
 	return x;
 }
-- 
2.14.3

Re: [dpdk-dev] [PATCH v1] eal: remove another use of register keyword

[Thomas Monjalon]

15/01/2018 12:33, Avi Kivity:
> The 'register' keyword does nothing, and has been removed in C++17.
> 
> Remove it for compatibility, like commit 0d5f2ed12f9eb.

Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword")

> Signed-off-by: Avi Kivity <avi@scylladb.com>

Applied, thanks.

Note that "register" is used in some drivers too:
git grep -l '\<register\>.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u
	drivers/bus/dpaa/
	drivers/crypto/dpaa2_sec/
	drivers/crypto/qat/
	drivers/event/sw/
	drivers/net/ark/
	drivers/net/avp/
	drivers/net/bnx2x/
	drivers/net/bnxt/
	drivers/net/e1000/
	drivers/net/i40e/
	drivers/net/ixgbe/
	drivers/net/qede/
	drivers/net/sfc/
	drivers/net/vhost/

Re: [dpdk-dev] [PATCH v1] eal: remove another use of register keyword

[Avi Kivity]

On 01/15/2018 08:00 PM, Thomas Monjalon wrote:
> 15/01/2018 12:33, Avi Kivity:
>> The 'register' keyword does nothing, and has been removed in C++17.
>>
>> Remove it for compatibility, like commit 0d5f2ed12f9eb.
> Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword")
>
>> Signed-off-by: Avi Kivity <avi@scylladb.com>
> Applied, thanks.
>
> Note that "register" is used in some drivers too:
> git grep -l '\<register\>.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u
> 	drivers/bus/dpaa/
> 	drivers/crypto/dpaa2_sec/
> 	drivers/crypto/qat/
> 	drivers/event/sw/
> 	drivers/net/ark/
> 	drivers/net/avp/
> 	drivers/net/bnx2x/
> 	drivers/net/bnxt/
> 	drivers/net/e1000/
> 	drivers/net/i40e/
> 	drivers/net/ixgbe/
> 	drivers/net/qede/
> 	drivers/net/sfc/
> 	drivers/net/vhost/
>

I think those aren't a problem, since they aren't exposed to C++ programs.