From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 582D3322C for ; Mon, 15 Jan 2018 19:18:44 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id b141so3619549wme.1 for ; Mon, 15 Jan 2018 10:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RdK+usPG8wmTzK24Num60lH2eIeB6jkcelD8jvzeszI=; b=FSDCANmh1plKf2B4WEu1qKje969eqX9UaFuG2+1XwBFbmI5vq2aSPYQXHKJtiWyADD H9D8hNgRL6Opzz/UXbGLl5CBnasENGJWlZtZIMoxJ8eyw5VKVKRFvTgZWA06kPKBbShA 2juJThjBFzKDpAJ+f84G9lQvh62wc0hEK5oee8pCcd3rBwHxu/QLaI4HN5t1lfvVhMaR pmnjNXXHeo4rhvKSweBH43zvac03fIESLplN/Qm2Lp03B2RfiZh5pihj/TAhg/l1+eRW WMKEB++g8ySRzF8r6wNtFg6+40nFnaKVeBWxFoIRH2NOXUZgseGVosjStYNNQrjdYnIh HEtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=RdK+usPG8wmTzK24Num60lH2eIeB6jkcelD8jvzeszI=; b=rHgTeXpZGFZSGWCm9wa1kwvCDhBSwDgn5YbD10XR/AFUIvOh5QNCR53WBxVdZVT5U9 /vEz+3Qjrl/+jMMu6RuhFBW/pdztlppslUuI1JBagjbTKNd81d6fcoYS1mny/qDzG4Wl DAXgzqa/qCohp55Udaq8O4VVwsdRMnipX1LmKC+Xjc/dUxrCrVYkTrHwvhsO4L37Ygyz oKXtmsZuBAirgjT5g0ryVnWimrJ4rA/LiBXec5tOq+0I2j2zWgA3Wy7OCjHyYpLe+k2o 7j8t2Bbw2WUUWDXohz2A/4MszJLI7FDd+aMCLF2HGpq8nUtvVZUgybOnwUGJlaJ0pJL4 oruw== X-Gm-Message-State: AKwxytfktro8KPvdFFaBhbzkpvFOJ+qWe948m1vfXavicGONu5QvlZa8 09ggeUPngCG+VKhze2inVu7IrA== X-Google-Smtp-Source: ACJfBot+wbcVuQ6AsGt/d5jo6LKTHdy+cEqJtQqU6KvMRD599XCc24q7/E0pf3G5G+hpubQNFjjw8Q== X-Received: by 10.28.111.90 with SMTP id k87mr10292835wmc.108.1516040323980; Mon, 15 Jan 2018 10:18:43 -0800 (PST) Received: from avi.cloudius-systems.com ([199.203.229.89]) by smtp.gmail.com with ESMTPSA id k125sm703250wmd.48.2018.01.15.10.18.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jan 2018 10:18:42 -0800 (PST) To: Thomas Monjalon Cc: dev@dpdk.org References: <20180115113323.24439-1-avi@scylladb.com> <1973968.l2YiJ7Szvs@xps> From: Avi Kivity Organization: ScyllaDB Message-ID: <1d4491fc-ef3b-72fc-2b60-7f48228e12a1@scylladb.com> Date: Mon, 15 Jan 2018 20:18:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1973968.l2YiJ7Szvs@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1] eal: remove another use of register keyword X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 18:18:44 -0000 On 01/15/2018 08:00 PM, Thomas Monjalon wrote: > 15/01/2018 12:33, Avi Kivity: >> The 'register' keyword does nothing, and has been removed in C++17. >> >> Remove it for compatibility, like commit 0d5f2ed12f9eb. > Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword") > >> Signed-off-by: Avi Kivity > Applied, thanks. > > Note that "register" is used in some drivers too: > git grep -l '\.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u > drivers/bus/dpaa/ > drivers/crypto/dpaa2_sec/ > drivers/crypto/qat/ > drivers/event/sw/ > drivers/net/ark/ > drivers/net/avp/ > drivers/net/bnx2x/ > drivers/net/bnxt/ > drivers/net/e1000/ > drivers/net/i40e/ > drivers/net/ixgbe/ > drivers/net/qede/ > drivers/net/sfc/ > drivers/net/vhost/ > I think those aren't a problem, since they aren't exposed to C++ programs.