DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: "lironh@marvell.com" <lironh@marvell.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Yuri Chipchev <yuric@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value
Date: Wed, 6 May 2020 11:19:11 +0000	[thread overview]
Message-ID: <1d68ef5a-b02b-2e77-56d7-5c1f76201de0@ericsson.com> (raw)
In-Reply-To: <20200506110959.23049-1-lironh@marvell.com>

On 2020-05-06 13:09, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
>
> number of enqueued events doesn't include events
> that were marked with RTE_EVENT_OP_RELEASE


You should have a complete sentence. "The returned number from 
rte_event_enqueue_*() wouldn't include events marked with 
RTE_EVENT_OP_RELEASE.", or something like that.


Other than that:

Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>


> Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
>   drivers/event/dsw/dsw_event.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> index e5e3597aa..611b36781 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
>   	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
>   			"accepted.\n", num_non_release);
>   
> -	return num_non_release;
> +	return (num_non_release + num_release);
>   }
>   
>   uint16_t



  reply	other threads:[~2020-05-06 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 11:09 lironh
2020-05-06 11:19 ` Mattias Rönnblom [this message]
2020-05-06 20:18 ` [dpdk-dev] [PATCH v2] " lironh
2020-05-07  6:09   ` Mattias Rönnblom
2020-05-14  7:15     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d68ef5a-b02b-2e77-56d7-5c1f76201de0@ericsson.com \
    --to=mattias.ronnblom@ericsson.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=lironh@marvell.com \
    --cc=stable@dpdk.org \
    --cc=yuric@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).