From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4278A09E4; Thu, 1 Apr 2021 18:28:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 384D7406FF; Thu, 1 Apr 2021 18:28:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EC50440696 for ; Thu, 1 Apr 2021 18:28:47 +0200 (CEST) IronPort-SDR: 4ilaeq8EV6FGJDxWfPIXHu4wC9iyKDGYq2LDNA0GdxAXrX25Z3AKamqZvc1U8TS28b1nHEO3DN tTIaZfZqW9sg== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="190049661" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="190049661" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 09:28:46 -0700 IronPort-SDR: +LsSAQlPxwbnXzFZtX7W1lEAXCVr2pDL+qOVO7BtGLfTFzxldzUllKxYB4Ck6ueVawHeaRIe/H JZU2sGnN99rw== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="456054518" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.245]) ([10.213.201.245]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 09:28:44 -0700 To: Keiichi Watanabe , "Kinsella, Ray" Cc: dev@dpdk.org, Dylan Reid , Chirantan Ekbote , Maxime Coquelin , Chenbo Xia , Neil Horman , David Marchand References: <20210322072257.2017227-1-keiichiw@chromium.org> <20210322072257.2017227-2-keiichiw@chromium.org> From: Ferruh Yigit X-User: ferruhy Message-ID: <1d758e29-e9cd-1adb-02c0-b23d26a4878d@intel.com> Date: Thu, 1 Apr 2021 17:28:39 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/2021 5:05 PM, Keiichi Watanabe wrote: > Thanks for the review! > Should I send the updated version of the patch series? Or, can I ask you to make > the follow up changes as a maintainer? > No new version is required, already updated in the next-net [1] repo. [1] https://git.dpdk.org/next/dpdk-next-net/ > Keiichi > > On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray > wrote: > > > > On 31/03/2021 17:45, Ferruh Yigit wrote: > > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: > >> Add rte_vhost_get_negotiated_protocol_features, which returns a set of > >> enabled protocol features. > >> > >> Signed-off-by: Keiichi Watanabe > > > > > <...> > > > >> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map > >> index 9183d6f2f..95c4c0990 100644 > >> --- a/lib/librte_vhost/version.map > >> +++ b/lib/librte_vhost/version.map > >> @@ -63,6 +63,7 @@ EXPERIMENTAL { > >>       rte_vhost_va_from_guest_pa; > >>       rte_vhost_extern_callback_register; > >>       rte_vhost_driver_set_protocol_features; > >> +    rte_vhost_get_negotiated_protocol_features; > >>       rte_vhost_set_inflight_desc_split; > >>       rte_vhost_set_inflight_desc_packed; > >>       rte_vhost_set_last_inflight_io_split; > > > > Added the release version that experimental API is added as comment in > next-net, like following: > > > > +++ b/lib/librte_vhost/version.map > > @@ -76,4 +76,7 @@ EXPERIMENTAL { > >         rte_vhost_async_channel_unregister; > >         rte_vhost_submit_enqueue_burst; > >         rte_vhost_poll_enqueue_completed; > > + > > +       # added in 21.05 > > +       rte_vhost_get_negotiated_protocol_features; > >  }; > > > > > > We are doing this already in many libraries [1], this helps us easily > observe how long an API is staying as experimental in a library. > > Good idea. > > > [1]: > https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407 > >