Re: [PATCH V1 1/2] app/testpmd: fix supported RSS offload display

["lihuisong (C)" <lihuisong@huawei.com>]

在 2022/4/29 15:27, David Marchand 写道:
> On Mon, Apr 25, 2022 at 11:26 AM Huisong Li <lihuisong@huawei.com> wrote:
>> @@ -773,20 +787,8 @@ port_infos_display(portid_t port_id)
>>          if (!dev_info.flow_type_rss_offloads)
>>                  printf("No RSS offload flow type is supported.\n");
>>          else {
>> -               uint16_t i;
>> -               char *p;
>> -
>> -               printf("Supported RSS offload flow types:\n");
>> -               for (i = RTE_ETH_FLOW_UNKNOWN + 1;
>> -                    i < sizeof(dev_info.flow_type_rss_offloads) * CHAR_BIT; i++) {
>> -                       if (!(dev_info.flow_type_rss_offloads & (1ULL << i)))
>> -                               continue;
>> -                       p = flowtype_to_str(i);
> This patch removes the only call to flowtype_to_str not under #if
> defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE).
>
> As reported by the CI, it breaks compilation when disabling net/i40e
> and net/ixgbe drivers because it results in a static unused symbol
> left behind.
>
> FAILED: app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o
> ccache gcc -Iapp/a172ced@@dpdk-testpmd@exe -Iapp -I../app -Ilib/ethdev
> -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
> -I../lib/eal/include -Ilib/eal/linux/include
> -I../lib/eal/linux/include -Ilib/eal/x86/include
> -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common
> -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry
> -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool
> -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter
> -Ilib/cmdline -I../lib/cmdline -Idrivers/bus/pci -I../drivers/bus/pci
> -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Ilib/bpf
> -I../lib/bpf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64
> -Wall -Winvalid-pch -Wextra -Werror -O2 -g -include rte_config.h
> -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral
> -Wformat-security -Wmissing-declarations -Wmissing-prototypes
> -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare
> -Wstrict-prototypes -Wundef -Wwrite-strings
> -Wno-missing-field-initializers -D_GNU_SOURCE -march=corei7
> -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ
> 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -MF
> 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o.d' -o
> 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -c
> ../app/test-pmd/config.c
> ../app/test-pmd/config.c:5506:1: error: ‘flowtype_to_str’ defined but
> not used [-Werror=unused-function]
> flowtype_to_str(uint16_t flow_type)
> ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
>
> Please fix by removing the unnecessary fwd declaration of this symbol,
> then moving flowtype_to_str function under the #if
> defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) check.
>
> I marked this patch as changes requested, thanks.
This is a little hidden. I'll fix it, thanks.
>
>