From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 351ED32A5 for ; Tue, 16 Oct 2018 10:37:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BD2B3001FF5; Tue, 16 Oct 2018 08:37:38 +0000 (UTC) Received: from [10.36.112.24] (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7134D7AE07; Tue, 16 Oct 2018 08:37:35 +0000 (UTC) To: Xiaolong Ye , dev@dpdk.org, Tiwei Bie , Zhihong Wang , Ferruh Yigit Cc: xiao.w.wang@intel.com References: <20181012085221.55769-1-xiaolong.ye@intel.com> From: Maxime Coquelin Message-ID: <1d8750aa-3a68-76e0-1f6c-d491d29414d5@redhat.com> Date: Tue, 16 Oct 2018 10:37:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181012085221.55769-1-xiaolong.ye@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 16 Oct 2018 08:37:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: add doxygen comment to vDPA header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 08:37:40 -0000 On 10/12/2018 10:52 AM, Xiaolong Ye wrote: > As APIs in rte_vdpa.h are public, we need to add doxygen comments > to all APIs and structures. > > Signed-off-by: Xiaolong Ye > --- > > changes from v1: > 1. add descriptions for all fields of structs > 2. add warning section for all __rte_experimental API > > > doc/api/doxy-api-index.md | 1 + > lib/librte_vhost/rte_vdpa.h | 96 +++++++++++++++++++++++++++++++------ > 2 files changed, 83 insertions(+), 14 deletions(-) > Applied to dpdk-next-virtio/master. Thanks, Maxime