From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79298A2EDB for ; Tue, 1 Oct 2019 15:36:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE0131B948; Tue, 1 Oct 2019 15:36:31 +0200 (CEST) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id E0734CFA6 for ; Tue, 1 Oct 2019 15:36:30 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4392B600074; Tue, 1 Oct 2019 13:36:29 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 1 Oct 2019 14:36:23 +0100 To: Simei Su , , , , CC: References: <1564102511-99609-1-git-send-email-simei.su@intel.com> <1569921733-10631-1-git-send-email-simei.su@intel.com> <1569921733-10631-2-git-send-email-simei.su@intel.com> From: Andrew Rybchenko Message-ID: <1d97be6e-b8fc-b02b-382e-e651deee6fb0@solarflare.com> Date: Tue, 1 Oct 2019 16:36:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1569921733-10631-2-git-send-email-simei.su@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24946.003 X-TM-AS-Result: No-8.693800-8.000000-10 X-TMASE-MatchedRID: cgbqQT5W8hfmLzc6AOD8DfHkpkyUphL9B4Id7CiQcz+8YDH/UBNnm0JX 5ipOV5R9THteaGAbFD6XFT8WJtp/J8WKJ8at6hW29FQh3flUIh6wqLgRdvwAikbtou1PeiP7ZpV YVTTLTSat2gtuWr1Lmk0sWlU8znGfVM0f8gR0I2a+hCRkqj3j058kBWlYDDNgmyiLZetSf8nJ4y 0wP1A6AKEwgORH8p/AjaPj0W1qn0TGVuWouVipckfqP4bMKHOT5C1NUHetCQJR6crQnilbuSmeC pga7EdMVYEefsx5FOdoLdpUXdLrgXB64/3FkeEHvLEXS6ptGp0N0tGFTsDwfoVyAlz5A0zC7xsm i8libwVi6nHReNJA8sM4VWYqoYnham2pp47lr+A= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.693800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24946.003 X-MDID: 1569936990-fVU8qNsEp_OB Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add symmetric toeplitz hash support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/19 12:22 PM, Simei Su wrote: > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash function. > To support symmetric hash by rte_flow RSS action, this patch adds > new hash function "Symmetric Toeplitz" which is supported by some hardware. > > Signed-off-by: Simei Su > Reviewed-by: Qi Zhang > Acked-by: Ori Kam Acked-by: Andrew Rybchenko > --- > lib/librte_ethdev/rte_flow.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 354cb1d..ca4e868 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1814,6 +1814,12 @@ enum rte_eth_hash_function { > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ > + /** > + * Symmetric Toeplitz: src, dst will be replaced by > + * xor(src, dst). For the case with src/dst only, > + * src or dst address will xor with zero pair. > + */ > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, > RTE_ETH_HASH_FUNCTION_MAX, > }; It looks like symmetric does not make sense in the case of src/dst only. The goal of symmetric function is to make it the same for both directions.