From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id B650D37A8
 for <dev@dpdk.org>; Thu,  8 Sep 2016 16:47:02 +0200 (CEST)
Received: from [37.164.124.82] (helo=[192.168.42.87])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bi0eJ-00062s-UQ; Thu, 08 Sep 2016 16:49:57 +0200
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Hiroyuki Mikita <h.mikita89@gmail.com>
References: <1473344895-18491-1-git-send-email-h.mikita89@gmail.com>
 <39302a3a-9662-7f75-db3b-e7dd4244c32f@intel.com>
Cc: dev@dpdk.org
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <1dbf4474-40de-428f-1d17-e73709e642b2@6wind.com>
Date: Thu, 8 Sep 2016 16:46:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <39302a3a-9662-7f75-db3b-e7dd4244c32f@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mempool: fix check flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Sep 2016 14:47:02 -0000

Hi Hiroki, Ferruh,

On 09/08/2016 04:44 PM, Ferruh Yigit wrote:
> On 9/8/2016 3:28 PM, Hiroyuki Mikita wrote:
>> fix check flags in case of single producer and single consumer
>>
>> Fixes: 449c49b9 ("mempool: support handler operations")
>>
>> Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
>> ---
>>  lib/librte_mempool/rte_mempool.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
>> index 2e28e2e..61bd63c 100644
>> --- a/lib/librte_mempool/rte_mempool.c
>> +++ b/lib/librte_mempool/rte_mempool.c
>> @@ -879,7 +879,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
>>  	 * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to
>>  	 * set the correct index into the table of ops structs.
>>  	 */
>> -	if (flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET))
>> +	if ((flags & MEMPOOL_F_SP_PUT) & (flags & MEMPOOL_F_SC_GET))
> 
> Isn't this always false?
> 
> What about:
> if ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET))
> 
>>  		rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL);
>>  	else if (flags & MEMPOOL_F_SP_PUT)
>>  		rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL);
>>
> 

Looks the same kind of patch was posted few hours before:
http://dpdk.org/dev/patchwork/patch/15686/

Regards,
Olivier