From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4454543709;
	Sat, 16 Dec 2023 11:01:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C185740691;
	Sat, 16 Dec 2023 11:01:33 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 40A2D402AA
 for <dev@dpdk.org>; Sat, 16 Dec 2023 11:01:33 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 877D366;
 Sat, 16 Dec 2023 13:01:32 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 877D366
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1702720892;
 bh=7xoQLu3X1xs8t/wzkw4Mv0P0zgQOLseF8Nd6yzGNdvI=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=LXJykg9YKGfSrAHL1coRs9v2IsDeXESejHSA1I7BWTSLzUfFUBO+DgbZ6v+HXs6V4
 55GRhhdIbyH0tXtT484l86Tbhy8PRSnwEjxLEcK4kt5CQvhdxM59UImHMAAUDKhtIL
 hCnMWZyYTDk5iCaaPZ9xyJPWJFwzCTkrB5V7bkrg=
Message-ID: <1dc7ef4e-aac0-4667-8f33-39a3598a6669@oktetlabs.ru>
Date: Sat, 16 Dec 2023 13:01:32 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 11/22] ethdev: replace strtok with reentrant version
Content-Language: en-US
To: Jie Hai <haijie1@huawei.com>, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>
Cc: lihuisong@huawei.com, fengchengwen@huawei.com
References: <20231113104550.2138654-1-haijie1@huawei.com>
 <20231114110006.91148-1-haijie1@huawei.com>
 <20231114110006.91148-12-haijie1@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20231114110006.91148-12-haijie1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/14/23 13:59, Jie Hai wrote:
> Multiple threads calling the same function may cause condition
> race issues, which often leads to abnormal behavior and can cause
> more serious vulnerabilities such as abnormal termination, denial
> of service, and compromised data integrity.
> 
> The strtok() is non-reentrant, it is better to replace it with a
> reentrant version.
> 
> Fixes: f38f62650f7b ("ethdev: add Rx queue telemetry query")
> Fixes: 9e7533aeb80a ("ethdev: add telemetry command for TM level capabilities")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>