From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5F7045C0A; Tue, 29 Oct 2024 13:00:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D166E4014F; Tue, 29 Oct 2024 13:00:54 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 563B840144 for ; Tue, 29 Oct 2024 13:00:53 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B41113D5; Tue, 29 Oct 2024 05:01:22 -0700 (PDT) Received: from [10.57.58.134] (unknown [10.57.58.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ECEFD3F73B; Tue, 29 Oct 2024 05:00:51 -0700 (PDT) Message-ID: <1dc9390f-5cec-45c9-b31e-643b06e837fa@arm.com> Date: Tue, 29 Oct 2024 12:00:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] dts: enable copying directories to and from nodes Content-Language: en-GB To: Patrick Robb Cc: dev@dpdk.org, Paul Szczepanek , =?UTF-8?B?VG9tw6HFoSDEjnVyb3ZlYw==?= References: <20240930160204.19582-1-tomas.durovec@pantheon.tech> <20241021134935.1210500-1-luca.vizzarro@arm.com> <20241021134935.1210500-5-luca.vizzarro@arm.com> From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29/10/2024 01:07, Patrick Robb wrote: > On Mon, Oct 21, 2024 at 9:49 AM Luca Vizzarro wrote: > + > +    @abstractmethod > +    def remove_remote_file(self, remote_file_path: str | PurePath, > force: bool = True) -> None: > +        """Remove remote file, by default remove forcefully. > + > +        Args: > +            remote_file_path: The file path to remove. > +            force: If :data:`True`, ignore all warnings and try to > remove at all costs. > +        """ > > > This is outside of the scope of this patch, but I figured I would > comment that we should use this to clean the dpdk-devbind.py file when > we re-add that functionality. I'm glad this method is added. :) Sounds good to me! > +    @abstractmethod > +    def create_remote_tarball( > +        self, > +        remote_dir_path: str | PurePath, > +        compress_format: TarCompressionFormat = > TarCompressionFormat.none, > +        exclude: str | list[str] | None = None, > +    ) -> PurePosixPath: > > > Does this have to be a PurePosixPath instead of a PurePath? I know > adding Windows support for DTS seems far out, but we should not add in > barriers to that now without good reason (though if there is a strong > practical reason why we want to do this now, then okay). I believe we > will have a PurePosixPath return in testbed_model/posix_session.py and a > PureWindowsPath return in testbed_model/windows_session.py (when it exists). Excellent catch! Quite missed this, we should be able to amend this to PurePath under os_session.py and keep PurePosixPath under posix_session.py > > Otherwise, I know we discussed this at the DTS call on Thurs, but thanks > for remaining .gz .xz agnostic. The choice to zip the tarball is taken under framework.testbed_model.sut_node:_copy_dpdk_tree