From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8518B42D16; Wed, 21 Jun 2023 18:53:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75DCF4068E; Wed, 21 Jun 2023 18:53:52 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 9B9D44003C for ; Wed, 21 Jun 2023 18:53:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csPJAgChqiGXITcQZgl9+bfgzCGA7BfJOz67iAceoa53sB5YDneTIoZcq3XvVFvgnBwbNvzO8ZEADFcqs2lUztQqbYxGh1mQIlTBFs98TCy3chOi6kRMuf/Izg7WYI7HejJMDJjWIsztB5eA0n3SQC/d5fy+ukK42rVoK6pNbd2SIqzLakWmJr1djPu6lTUtdM328yVlruvTxuN88J0qprpVbnJRGUii0DmA2gFAO4xO80O7M/8qEDeguDQ2zhCCWZkQag3gumD2ToxTsLatmdBW7TWF08f1fkZL25XQ8V+hMWef3mrEZh+zM2nEPBwnkc/nsCfJsTZrgnfYBDmnFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YNebrT5xxkpCLPESmCshi/Sxr+s6gz6ZPybPXLP6shA=; b=gnAK/Ke8C3oVVA+JPc+y1EF9wlSOtDR/Sjk8UYYNK1VuMaAaO7/eZSrlWLOtKmko8a05EblhIQGp0Hsm0/x35/BNchVNKjOta6FXO4/nXbMWdiOsoEsjYXxprdXPM4yX7XB9Fe2pLccpHqaWUGzID3nbx7UXilJnsnUDr+WNRAG4ru1aEUK/hImCyt6wFi5f3kjPyfXnDpMY0/CRHzeiY9BPMlpbT5MxTkd6Y2zWa4IQKW7dnR5UDBQuazATrLuwQCi57Jf5znVYcVVKC6fjy5mPilAVIyAuSi7Miaf/9hYjZsMJWVyzbfBrbg2noocxkeVYcXESx2a3EgehMjGBNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YNebrT5xxkpCLPESmCshi/Sxr+s6gz6ZPybPXLP6shA=; b=KzeXYNHi4ce1wS6V6F44GGhdjGkQZlSImkhLNdN5jMZy+c3GuhgvDhi6ECra0gJfj7LwJtC58u0NSe8tgTb5mej5S8YQjSAmc1nFiGpCj3VZYGkgpbSuust39V9eJRmpa56Xv6biXXrvHSPGKCOeLYL2FBUMIu3YTpWOKBI7lNY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Wed, 21 Jun 2023 16:53:49 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 16:53:49 +0000 Message-ID: <1dd8da6b-f5d0-da02-a18f-c869e95c15d0@amd.com> Date: Wed, 21 Jun 2023 17:53:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko References: <20230601195538.8265-1-ivan.malov@arknetworks.am> <20230607130245.8048-1-ivan.malov@arknetworks.am> From: Ferruh Yigit Subject: Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance In-Reply-To: <20230607130245.8048-1-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0261.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:375::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4488:EE_ X-MS-Office365-Filtering-Correlation-Id: 70693074-2c15-4853-5689-08db727815f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDL9+FcZQVarYCIgyvzNUKIQ9kxQZHLeMg/QaORhMKk9u80JdyReFLLmV2JZWl5Vg1QFTwKfPbXNYVxwsvmynylqSncqypHaSLgm5MoXpMUxpAOEl2bl/G4Lzcp0snN4mSTBNwoTrJjwE4E6XTg6OKdkzVcnc4ZlzfAIqRJvijYqMBcLEFx12ilh06RPonSQDZZeX594crPen6AIsiCw81xLMCRPX8xZ4G5nali8vCvNZYvTTpsUlMokRh3m47hPig/ysLpWFvVYvm2jubVEfTamjSYn2YgzjAIJHkb+Gn93AOxP3tiobEMpOIr/d6tpC0/OivLXctQmtnNmqkKCzZN4EodvwSW1ZGQPR4Rmiuv7XYE2AGT/FDdjTz1VvNFjNh6Mebu+emezCyh0dCdXyoi5zHtHHAOsQL0tpOuTl8tmj8cuZ1jHGTOfY5dgY8V66gc9kK7ETvn7y1hD6lh7szGLl8/YDLBPIn131K7NWtb13P6U7aHfSRynK3E69omQqFKF/urFwMuWgYvcfef+NCyR/KUPqzjLho2I6ayoSRd1r2iSfqQNm2debXrr9iCjZ4ltqodOjIRzTyohUmqdM+807ZzCsCbozLTOmoGuLLeETr806XByIgz3rtTP5mYtleCC3ozPDSpXJJZcVI5X+A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199021)(53546011)(31686004)(36756003)(44832011)(5660300002)(38100700002)(41300700001)(66476007)(8676002)(4326008)(8936002)(86362001)(31696002)(316002)(66946007)(6506007)(6486002)(2906002)(6512007)(186003)(26005)(478600001)(83380400001)(66556008)(2616005)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVhJN3VianRuMkxkZEVXMGdoR2ZRbWVjN2NkZ1ZndE0veDRBWHl6b0V1c3dQ?= =?utf-8?B?MGhBbENvZFdqb3UzRWI2a1gxbjdiU2s5K3Zib1JtckJ5cW9kMXJvNFhXQmdl?= =?utf-8?B?M3MrcS9sblBKNWsrczYwQm84OG9nSW9RdVpkc0RPanYyUVZiZlo2K04vd0du?= =?utf-8?B?S1liZDFwMVdVSFc2TlI3K3NTNkgveDlJTktSaUl3QWxZcEdUMkRsL0djNkgw?= =?utf-8?B?MG9RbUhiL2lPWVAyL2tHK0h6S0VUNkd4d21xWGlicVQzcFF6NmROZkxRYXVR?= =?utf-8?B?UXRnVzJPRFZtdit6blVEanpmazNIdktZaERZQ1Mzd3JCYkRwanovd2NxZ2po?= =?utf-8?B?aE90RWdibUxOdFZpcEY4aWRXU05nZzg1a0lucWc2WW9HRGowaDQ3Y2RCWmND?= =?utf-8?B?QnZGc0wveXlvOFRMdkgwTmtWY0JVMlpaeTI3OGMwcmJXMXh5MzNwZVkzVkRr?= =?utf-8?B?OFFUWGZJZDdmbXdmM2JNOWJSMnl6TTNSNE5pV3RFak01Qy8rVDMzU09nNXQr?= =?utf-8?B?R0pzN1VUOTdQaDQ1RnN0WVN3NVd4SlpObDNZTU5CR3p6NHFzNmxrL0lNakZT?= =?utf-8?B?STVQbFZXN2RRWjBmdGFmbkVZYjNxSVNMK2FnTHBGcUZYcGI1SGtwNE5jV2ZF?= =?utf-8?B?QWNWOUdCU1VVVzVpUmRVYjd4bEpFQ0E1MUhWcktpRWxudGxzQkkzSkUzV3Zx?= =?utf-8?B?Tm1kQXBPS1hDMTlYUzZ4ckZBazd3d2hHU3l5WmZJd01TbWNTLzBZaWZVek9C?= =?utf-8?B?dm5TRzZ3QVlUb2xwYmpOdWo3Z3dsVlhvbzNJcXY0LzJpY215T3FBci9kemJN?= =?utf-8?B?WFNXbERYS2dXc21CTnFZZUgzTDJRWDVzb0g1Qi9GSEdsZGI2Y21mMUVaUTNy?= =?utf-8?B?MHJjSnB1YkcxTlNpVEZvcHZ1OHlWeTVoWVpTMTdVS0RFSXZaMjlkT0pVa1BD?= =?utf-8?B?SEhoZ284ZHc2YlpNYis3bmZvQjJtV3Z2MlJZSStMR2hDTENFQnBPM3hJd2V1?= =?utf-8?B?UmpESDY2VG5HQnpCN2JHUnJ2aSswR2cyYjdFZyt1Q0pKZjV6QWZ2bW5xV21r?= =?utf-8?B?MFBMaStjd1g3eFN3ZVE0TUlDUmV6VDhuM3hjcHZBd1ZjZmRGK3VxZllBeG44?= =?utf-8?B?Rk03S2F6RVdwYU13eEV0TlBEaGZBUVFPUy9tNDFaa0Y5MkRJYUt1TTkzUmdR?= =?utf-8?B?QWs2SVNESGZyNDUwZ1pmZWlnMkNIb1VZYjhQaS9KTCswOU5tZWpEZTN1K0ds?= =?utf-8?B?ZkxRbFJETnF3and1ZSt0eXQrdkVYMlQxRWNad3JhbHpoRDBkYmRkYXZqQjhz?= =?utf-8?B?Uys2cnVkUHFxL2tGRDkyaUJ4VHk4SlM1QTY5MFpvMUZzVU5tYWtERmxsZFFy?= =?utf-8?B?ajB0NE5wM3JNNDRCZWwrOWRWQnQwR09veUVJSitiUWE0WWZyakkzM2VDRXhi?= =?utf-8?B?RlBiL0NNM1hDWjM2Wi9VRmp4SnppY0E0UzBkbytVUVVpMmVBSVkzNWZucjlQ?= =?utf-8?B?TGhnV1pQM05PUlRUTC9zZFBaYndza3IzVW1QR0g5Yk93MGtMT0Y3NGIvNHYx?= =?utf-8?B?dTZobERYR2V1Uno5ODRjRkRvYzN4VXd4S1Q1RGlDTW5QT3RNTWN6SEpYREpS?= =?utf-8?B?dkRSZ3VqcFhNR3BWZE4ycEVDWVhZcnBDUzU2N0V3WkpPVWdHUUtvcUFCK1pQ?= =?utf-8?B?RngzaU5rT1lXMHpYSjBaSDZkZ1N6Y1BqL25aYVhpdXdSTTRVNmFnQXpqL01t?= =?utf-8?B?cDYzSGRwNmRWVlNMKzg5SFZTOTJhYVpIYUtlWjUrenhpaWxLS3FLTFlhWHZx?= =?utf-8?B?M1dpR3gvOFJuR2x6RWNxaWwybHZQVnJNWjdId1U5bTdXSVgxMnlCVUFwWENt?= =?utf-8?B?V0pVNEFSOGVWb0tRb0ZraDlFa0hHd2ZyTkYvVlExaEhSTXZVeU9SZnpqWWk5?= =?utf-8?B?TjhJOEliSUxvUVc0NlVqWHVDdmRZRVBabTIyNXBVUTVWQ0RHcCtoWW9uaElO?= =?utf-8?B?TWhiVHdBVnY1cFkxaVY3QmdyUmZMaGdjd3lCa0xOMkxFQzNUckJvdnJjNlVR?= =?utf-8?B?VzBPYURQR3pHZFd4cDNLRm8vU3B1VDc4a002Y3N4Q2VYL3I3Q05ydjIvMlZI?= =?utf-8?Q?hTLzdCY8jnz0F7wIxJARJ9Sng?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70693074-2c15-4853-5689-08db727815f7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 16:53:49.5041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2HtEbLdiIb7Aawm4uwPMQ388GvaCVvXJX5Q8ouqWYl0QT8LibscREymUep2RHKln X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4488 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 2:02 PM, Ivan Malov wrote: > On EF100 hardware, match-action engine (MAE) can be equipped > with an assistance table for connection tracking (CT). In it, > an entry key is a set of exact match fields: an EtherType, a > pair of IP addresses, a L4 protocol ID and a pair of L4 port > numbers. An entry response can provide matching packets with > a mark value and additional data to be plumbed to NAT action. > In addition, an update to mark-and-sweep counter can be done. > > This table was designed with larger capacity in mind, > so moving the above match criteria out of an action > rule (AR) specification to a CT entry increases the > likelihood of reusing AR entries and improves the > total flow engine capacity. Make use of that. > > Changes in v2: > * Found and fixed my own mistake in [15/34] > * Fixed [16/34] as per 0-day robot report > * Added missing release notes to [27/34] > * Added missing release notes to [30/34] > > Changes in v3: > * Fixed release notes in [27/34] > * Rebased on dpdk to fix CI > > Changes in v4: > * Applied review notes in [05/34], [08/34], [09/34] and [10/34]. > > Denis Pryazhennikov (11): > common/sfc_efx/base: update MCDI headers > common/sfc_efx/base: detect MCDI Table Access API support > common/sfc_efx/base: add API to list HW tables > common/sfc_efx/base: add macro to get indexed QWORD field > common/sfc_efx/base: add API to get HW table desc > common/sfc_efx/base: add API to insert data to HW table > common/sfc_efx/base: add API to delete entry from HW table > net/sfc: add MCDI wrappers for BCAM tables > net/sfc: add functions to manipulate MCDI table fields > net/sfc: attach to HW table API > net/sfc: add API to manage HW Conntrack table > > Ivan Malov (23): > net/sfc: make entry pointer optional in MAE resource helpers > net/sfc: turn flow create/destroy methods into lock wrappers > net/sfc: let driver-internal flows use VF representor action > net/sfc: extend generic flow API to allow for internal flows > net/sfc: switch driver-internal flows to use generic methods > net/sfc: move MAE flow parsing method to MAE-specific source > net/sfc: move MAE counter stream start to action set handler > net/sfc: prepare MAE outer rules for action rule indirection > net/sfc: turn MAE flow action rules into shareable resources > common/sfc_efx/base: provide an API to clone MAE match specs > common/sfc_efx/base: add API to read back MAE match criteria > common/sfc_efx/base: match on conntrack mark in action rules > common/sfc_efx/base: add API to request MAE conntrack lookup > net/sfc: make use of conntrack assistance for transfer flows > common/sfc_efx/base: support NAT edits in MAE > net/sfc: add support for IPv4 NAT offload to MAE backend > net/sfc: rename SW structures used by transfer flow counters > net/sfc: rework MAE action rule counter representation in SW > net/sfc: support indirect count action in transfer flows > common/sfc_efx/base: rework MAE counter provisioning helpers > net/sfc: indicate MAE counter type in use for transfer flows > common/sfc_efx/base: support conntrack assistance counters > net/sfc: use conntrack assistance counters in transfer flows > Series applied to dpdk-next-net/main, thanks.