From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4F1BF237 for ; Mon, 11 Dec 2017 13:06:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 04:06:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1848548" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 04:06:56 -0800 To: Shahaf Shuler , dev@dpdk.org References: <20171123121941.144335-1-shahafs@mellanox.com> <20171123121941.144335-20-shahafs@mellanox.com> From: "Hunt, David" Message-ID: <1de13f98-42c8-0a53-7372-d0639ccd7ee1@intel.com> Date: Mon, 11 Dec 2017 12:06:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171123121941.144335-20-shahafs@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 29/39] examples/vm_power_manager: convert to new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 12:06:59 -0000 On 23/11/2017 12:19 PM, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. > > Signed-off-by: Shahaf Shuler > --- > examples/vm_power_manager/main.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c > index 399fbdd43..53d587d83 100644 > --- a/examples/vm_power_manager/main.c > +++ b/examples/vm_power_manager/main.c > @@ -74,7 +74,10 @@ static volatile bool force_quit; > > /****************/ > static const struct rte_eth_conf port_conf_default = { > - .rxmode = { .max_rx_pkt_len = ETHER_MAX_LEN } > + .rxmode = { > + .max_rx_pkt_len = ETHER_MAX_LEN, > + .ignore_offload_bitfield = 1, > + } > }; > > static inline int > @@ -84,6 +87,8 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool) > const uint16_t rx_rings = 1, tx_rings = 1; > int retval; > uint16_t q; > + struct rte_eth_dev_info dev_info; > + struct rte_eth_txconf txq_conf; > > if (port >= rte_eth_dev_count()) > return -1; > @@ -101,10 +106,13 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool) > return retval; > } > > + rte_eth_dev_info_get(port, &dev_info); > + txq_conf = dev_info.default_txconf; > + txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE; > /* Allocate and set up 1 TX queue per Ethernet port. */ > for (q = 0; q < tx_rings; q++) { > retval = rte_eth_tx_queue_setup(port, q, TX_RING_SIZE, > - rte_eth_dev_socket_id(port), NULL); > + rte_eth_dev_socket_id(port), &txq_conf); > if (retval < 0) > return retval; > } Looks good to me. Acked-by: David Hunt