From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 738B7A034F;
	Tue, 30 Mar 2021 12:20:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5BEE9140DD9;
	Tue, 30 Mar 2021 12:20:00 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by mails.dpdk.org (Postfix) with ESMTP id B1BC5140DCA
 for <dev@dpdk.org>; Tue, 30 Mar 2021 12:19:58 +0200 (CEST)
IronPort-SDR: v5iHd2JfYMEnhsPNn+lryKoD0JStpN0DGmDBpylCltdcdJJ6nKa2FEwvyQO+a/U3EnhxHgjruS
 yqurB6gfEzWA==
X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="211945494"
X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="211945494"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 30 Mar 2021 03:19:57 -0700
IronPort-SDR: CUX7Gl1VtBZPtVbQmNMcZGJXlRDinMUZGwDt4O8cH+Ug4hY7VvSZNBRGDgJE4ZRcmJGglw3VtS
 SxOTAJjYnSEA==
X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="418112252"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.213.217])
 ([10.213.213.217])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 30 Mar 2021 03:19:56 -0700
To: "Min Hu (Connor)" <humin29@huawei.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Xiaoyun Li <xiaoyun.li@intel.com>
References: <1614906276-34293-1-git-send-email-oulijun@huawei.com>
 <1617068905-5364-1-git-send-email-humin29@huawei.com>
 <CACZ4nhs9tQaOo-kQMp7evWF4_cyKgrFO5FJW-LNbvgob8JbDjg@mail.gmail.com>
 <cd99afdc-734d-530e-2cae-bfb3e214020b@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <1dfa9ed4-052e-22f1-a84a-c49303edbc00@intel.com>
Date: Tue, 30 Mar 2021 11:19:52 +0100
MIME-Version: 1.0
In-Reply-To: <cd99afdc-734d-530e-2cae-bfb3e214020b@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2021 7:41 AM, Min Hu (Connor) wrote:
> 
> 
> 在 2021/3/30 11:11, Ajit Khaparde 写道:
>> On Mon, Mar 29, 2021 at 6:48 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>>>
>>> From: Lijun Ou <oulijun@huawei.com>
>>>
>>> This patch adds multi-process support for testpmd.
>>> The test cmd example as follows:
>>> the primary cmd:
>>> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \
>>> --rxq=4 --txq=4 --num-procs=2 --proc-id=0
>>>
>>> the secondary cmd:
>>> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \
>>> --rxq=4 --txq=4 --num-procs=2 --proc-id=1
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Some minor nits below. Otherwise looks fine to me.
>> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>>
> Thanks Ajit.
> 
> Hi, Ferruh,
>      Should I send v9 to fix the grammar bugs in doc which Ajit point
> out or fix it in future?
> 

Hi Connor, if they are only outstanding issues, I can fix them while merging.

>>> ---
>>> v8:
>>> * Added warning info about queue numbers and process numbers.
>>>
>> :::snip::::
>>
>>> +*   ``--rxq=N``
>>> +
>>> +    Set the number of Rx queues per port to N. N is the sum of queues used 
>>> by primary
>>> +    and secondary process. Primary process and secondary process should have 
>>> separate
>>> +    queues, and each should occupy at least one queue. Where N should be the 
>>> multiple
>>> +    of number of processes.
>> of the number of processes.
>>
>>> +
>>> +*   ``--txq=N``
>>> +
>>> +    Set the number of Tx queues per port to N. N is the sum of queues used 
>>> by primary
>>> +    and secondary process. Primary process and secondary process should have 
>>> separate
>>> +    queues, and each should occupy at least one queue. Where N should be the 
>>> multiple
>>> +    of number of processes.
>> of the number of processes.
>>
>>> +
>>> +*   ``--num-procs=N``
>>> +
>>> +    The number of processes which will be used.
>>> +
>> :::: snip ::::
>>> +The number of rings should be a multiple of the number of processes. If not,
>>> +redundant queues will exist after queues are allocated to processes. After 
>>> RSS is
>>> +enabled, packet loss occurs when traffic is sent to all processes at the 
>>> same time.
>>> +Some traffic enters redundant queues and cannot be forwarded.
>>> +
>>> +Most dev ops is supported in primary and secondary process. While secondary 
>>> process
>> Most dev ops are supported in the primary and secondary process. While....
>>
>>> +is not permitted to allocate or release shared memory, so some ops are not 
>>> supported
>>> +as follows:
>>> +``dev_configure``
>>> +``dev_start``
>>> +``dev_stop``
>>> +``rx_queue_setup``
>>> +``tx_queue_setup``
>>> +``rx_queue_release``
>>> +``tx_queue_release``
>> :::: snip:::
>>