From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D35D643882; Wed, 10 Jan 2024 13:15:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54A6740298; Wed, 10 Jan 2024 13:15:31 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2051.outbound.protection.outlook.com [40.107.100.51]) by mails.dpdk.org (Postfix) with ESMTP id 6FD3340269 for ; Wed, 10 Jan 2024 13:15:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4lywenMfOxH4qL7QGA9V18aPbNNIt7zuTrxd2JGPDw2B40VO4Ni6rHrBktRezXGoCmr4Cn8DZY1Yi42Ci7q0HyCtLC3HjuDNilUQ1ZjE+S4qmwkIjKA6KxBRvNGBJBYYOuA78MoPpOoyvWIZQYYkWvPCE1ZOXv7solsiQMeJ/lrSoMRlcNqwnWcLf/xZsyFq9WSE/lC2QQPIO8mwteJW6fWGX/KPAHFZEpRpgWaJ+jXeSwepm9ntP8d1gf8p8DSJDGluT9LY2hGa/CwlXlEQ+Y2/gkhd4C0DPgJ2arAwyQ/Z9T7duDIaL4nUUhfbXqRfY2BBahkOAYxLClgAwOxCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HKI0ULNxJYpS58oVyrQqbI4nnp4odWg0jeDZG1EEmwI=; b=UKXPDHPlxYi9vEQjXf/e77EDpud9slmetIn53z8pYn4EyMLcSKEtJv+vw8Uv26zSmbXkY1lYjpBQWodQ3j8FTM8DolFmRjjSwGGSkzPnxVuRAaBWAjbnHgIOggoFE3GvEDm+XXJ74zRnkBLkQPfC0etpYnFdmHHuosEV6wP20kIKGknbZCmaEqqT00zpfWNKf6QXorm2bzKyVmapBb5tHpgL27w8itHe4AD7QIfB5RsTiKmzGH9yiEoGuWxp/ULP0J81C9eCy1iiA1EsSj2QiArDOZ06yAtS4G8qd+xQbqOL7TGmM+YFI9v9eAHxXAzGBnUKeAstU9jVHuz8Mie5yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HKI0ULNxJYpS58oVyrQqbI4nnp4odWg0jeDZG1EEmwI=; b=Op3grbQjRDgn2o7LOE/Jl8Qv+d25aGS9/Ws4glwjxDuhaJoaNV9aWXaaT8dr979PJM5OTZRe17DsyB+QIO23PZuES7zvojZQLueYmayEUPWjyn+45GZoS6iz98pW8fLZQBKESPMfNNL5MoUfbVp6AJ5jpuVdrtLU1cBz9QX0AGc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB9397.namprd12.prod.outlook.com (2603:10b6:8:1bd::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 12:15:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7181.018; Wed, 10 Jan 2024 12:15:26 +0000 Message-ID: <1dfc96a4-9471-4f2a-a835-72da95e6273e@amd.com> Date: Wed, 10 Jan 2024 12:15:19 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: add dump regs for telemetry Content-Language: en-US To: fengchengwen , Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Bruce Richardson Cc: lihuisong@huawei.com, liudongdong3@huawei.com References: <20231214015650.3738578-1-haijie1@huawei.com> <8632690b-5e85-43fb-9121-a8910074726d@amd.com> <359de0d6-90c4-aaea-f186-574d04a31c2a@huawei.com> <33d1d451-95ea-48fe-a6ec-b86976ba5130@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::28) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB9397:EE_ X-MS-Office365-Filtering-Correlation-Id: c442219b-de99-44ff-9c0e-08dc11d5d3e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YwbfX6Okzfsgh95GDm4ENKP63dntQbEqfNgF0PvHuNDkwIG9J2MFyxuMx/unJgvHxSHBTWrCj+ii/dwYKe+Zkxhhc3sXU1xw5TurDr3+9cCNv3VH5/3T3380a8kyJl5jVWEtJtQJ49Y7Veb6rl0O1GuelSV/1jjUBk8q9gM2yIEm/fYDpe+jSQLpEIXI2Yan0l6MDSzI/YHqCpkn0N1IjgJ3lbCUgwJVP47/Az623eDi32nDGIodfasq8ZHx/rLynVqPs3T1HZMpJTLGU5gP3Z3Ymzg9aK3b0CCswqYstbnVHkiFE2/VTM34LU/qFVUBIGC/xmM1zcjqZCSyWoCrlpiTNz+7hq6x5YGP/EJKjFzmd6DLMNqYB0VwQY4MXuZwo8YsTWcmqGIfailUtyBQoL9ZJgnmksl4Htg3PxPPinid+iDVFiiM7LxNG4/f4AoiifkAlsnSiTGbroh9x+5Ka2PlV1BiE4Kwf9OMosOa0bI8cg4ARyQtW7bN3dm2vKoPQ++T+WR1VxdIVS3hLPi4TdtOdJ2i1rM2sdk4rbZ1zSgSgQ+7GufUQQN909vwhLYPmqVJ8ep77rCG7o+eVCi4u7H93TujZENAiWND1oFPn2RnzJGlmuAl5ZzCfFOGDsvrvVfYgvDNfVHY/BXErLvaqA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(396003)(376002)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(5660300002)(44832011)(8936002)(6666004)(86362001)(31696002)(38100700002)(36756003)(83380400001)(6512007)(2616005)(6486002)(478600001)(26005)(6506007)(53546011)(8676002)(4326008)(41300700001)(110136005)(316002)(66946007)(66556008)(66476007)(31686004)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1dZUFZSZngwMHlGTyt4R1IwSm5DZk05NUNibDJkMmlJSndWM1N2bHQ4S0ZH?= =?utf-8?B?NGdyZDIyY1BLdGg5U096K21KSUVPK0RaOTJCSGZLV1RMN1ZsY0hub3c4ano1?= =?utf-8?B?UVNQYVZ4dlhvbXQvOURETXRucHFLQ3c0V3FiK3htQ0ZCRjJPZUlxeCtPNGM5?= =?utf-8?B?eGZ1T2x6SklWSTdWZnlhcGFKR2xqZ0tRaGxFUHFrM3h4bk0wQkxmU1lkdElC?= =?utf-8?B?QVFCdmp1ZGI2THM4Y3ErVyt3cFVieWNVbzh3QkdibUZGaldOK3o1dnFadzdo?= =?utf-8?B?c0JNMWphNm5OdGd1WHFGMm5zZDFhaEtBUndBWXR3MDFGZ3ptRENOU3RreHN4?= =?utf-8?B?Q1hnSk9OQnlVQ0FlWGRLbzFxZVNBRUl0SEMxSkVNTWZ2dXpJNmNtRytSUXc4?= =?utf-8?B?TTErbldmdkNPeU0xNGN4YjE1Y3h2dGZsb00vQVhZeGZTdkpmYzZRT1M2ekty?= =?utf-8?B?L2kwMVBya1BUaG5aUSt3aElYdnpRcE9xTUh6Q0pKeGZwYklYR3NWbEI4Z2Ex?= =?utf-8?B?bm8rclg4QlBXRXRjWCtZOE9uSVd3M0lrSTIzWFNsaGdYUEdWNDljWmRCd3lp?= =?utf-8?B?YTRGd1Nha0c1b2p5Q0Q0MGp3TU80T1AvSjZEUzQwOWpTWTJhM3VNTnFsTGVG?= =?utf-8?B?d29RWUdMUmVHREo3TEV0bXd2Syt1eG80bnE1MEJ4YlJheTdGQk1VL0l4RjJC?= =?utf-8?B?dXFPLzg1dVFQcmcxUWJvZ2dzMVVKWmdKeUtLZnpSVVNna0MxSVRwV1BCSVpO?= =?utf-8?B?REwzR0o1ZFEzNi9TTkZGWmI5OFBjdFVVYU5IYTJpU29XWDZZUHlaeFBUbU1J?= =?utf-8?B?RWozZlZhaWVuc2dZNmFEdkJ6YnZCd0ZIYUs5TUZvSGNkZ0V0M21ZMHZES2lG?= =?utf-8?B?NTUrdEFQb09hTFVuVXFMenJUejRINUJ4N05TeVVLSmVlOFExd1RIRmhkeUlT?= =?utf-8?B?cjY1UmE2Q2RDZUd5eDJOYmdhVUZlL2ZEa0xqWUNKK252ZkM5Wko2THBDMVhZ?= =?utf-8?B?dTRjc0thUVVSVzNlYUZQQlk0V0JmQnZqODRHSkJzNElnNHRKaEQwRWpZbVNt?= =?utf-8?B?V0hNeEJsTUZjbHVFWkQ0QUdMQkxRK2F1Z1ZzZi9hMHdxaEhpVGQyMXlVSUt5?= =?utf-8?B?bDJhZWo3eHBGOWNYUkNuaC9BMWtqUnJqejVwaU50WmhtOTFYS2xkZ1VkbU01?= =?utf-8?B?Vms2UGZZSk1KTTFCUDBUM1pBTEZuSm1nNWRZUVZ4c21FVGtJTUU5TXptUXhG?= =?utf-8?B?Y3FpNEczeTQ1VUpwQTMvQWJjSVh0SjF3TEdKQk9qc2cxbjB6MFM4RjhqVk1M?= =?utf-8?B?KzFhd3htbXRqMnpQR21xT0hKNEJGYjRxdDVBWFFsM2R1Mm9vN2pCekMzRGlp?= =?utf-8?B?cTVTemU1cjRiT0w2VVkzSjNIZjl5S2RWOEk4b3lGVzkyOWYwWGhJdzlYbzdH?= =?utf-8?B?MllDaHVUYmZzQ0UxR0w2dHBxclBKTkVJbzhTYjhhaWEyTENycUk2V09Ya1Zr?= =?utf-8?B?aW0vaERqcE5SZ3NpbVI5Ymh3QTJTdWs2cmRIYmQzR1J6TW9GUVducTRIN2I5?= =?utf-8?B?em9CY2JuZy80YXJxcVp6OE1wMWpoTlhsZmJkUEF2MjVMY0gyVmxlZExaUlZ1?= =?utf-8?B?NmFvOWh2V0RyS3owdm1KRW9CSXRtZVV6K1FwWlZyYTFWNjNuemprcVp4ZVdH?= =?utf-8?B?K1NqNEZrNUcyanZzRmcrbGhlRjZFUmpWd3Q3eE5HYmI1Z29JV1M4Zjd0Wlhp?= =?utf-8?B?OFBRbzBDZU1vcGZTMDg2ZW91cXpXY1ZFbzd5ZWxCbmRONHhTYUhFcGgyZWVX?= =?utf-8?B?WXYzUG1FRVdVQys2UmxZZWJDZTBsQWIrL3hMV2UrbVQ2WXhmZ3I0U2o4UE8y?= =?utf-8?B?UHhnQzg2MGJlN3JvMXpRaWZPWm83Y2N3aDN2Y1JlM0ZwRHM1OENjTFgzZklu?= =?utf-8?B?Sk1LSDFaM1RZUHJBZjdYNW1kaUtLUEtRYWNnb1pFOHd1S1VwWW5OU3RLQjBj?= =?utf-8?B?enhBN0FjWGxzNG80aGhrb3RKUzJCN1NWTjdPVEFYeFNINFlvWHQ2Uk1ZWmFZ?= =?utf-8?B?Rld2YzM3emt5eHRCTkhmM3lhbFNWMEk5bmtxTWpMMWd2MHBLbkZmdWtQSHFK?= =?utf-8?Q?5zi8Crwa65+ZG4Gfxhoa4J4WZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c442219b-de99-44ff-9c0e-08dc11d5d3e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 12:15:26.2327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FTnsLoOntQoliIr0is+ruuAxupo0tZ1/6YqMkhY6/uzcDXy8dcw8T2SZ5dW0lMTK X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9397 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/10/2024 1:38 AM, fengchengwen wrote: > Hi Ferruh, > > On 2024/1/10 2:06, Ferruh Yigit wrote: >> On 1/9/2024 2:19 AM, Jie Hai wrote: >>> On 2023/12/14 20:49, Ferruh Yigit wrote: >>>> On 12/14/2023 1:56 AM, Jie Hai wrote: >>>>> The ethdev library now registers a telemetry command for >>>>> dump regs. >>>>> >>>>> An example usage is shown below: >>>>> --> /ethdev/regs,test >>>>> { >>>>>    "/ethdev/regs": { >>>>>      "regs_offset": 0, >>>>>      "regs_length": 3192, >>>>>      "regs_width": 4, >>>>>      "device_version": "0x1080f00", >>>>>      "regs_file": "port_0_regs_test" >>>>>    } >>>>> } >>> >>>> >>>> Above code writes register data to a file. >>>> >>>> I am not sure about this kind of usage of telemetry command, that it >>>> cause data to be written to a file. >>>> >>>> My understanding is, telemetry usage is based on what telemetry client >>>> receives. >>>> What do you think just keep the 'reg_info' fields excluding data to the >>>> file? >>>> >>>> .Hi, Ferruh >>> >>> I tried to write all register information to telemetry data, >>> but gave up because some drivers had too many registers (eg.ixgbe) >>> to carry. Therefore, the writing data to file approach is selected. >>> >>> When we query a register, the register content is the key. >>> The information such as the width and length is only auxiliary >>> information. If the register data cannot be obtained, the auxiliary >>> information is optional. So I don't think register data should be removed. >>> >>> In my opinion, writing a file is a more appropriate way to do it. >>> I wonder if there's a better way. >>> >>> >> >> Is there a usecase to get register information from telemetry interface? > > Among the available tools: > 1, ethtool/proc-info: should use multi-process mechanism to connect to the main process > 2, telemetry: easier, lighter load, and it don't need re-probe the ethdev in the secondary process, > and also cost more resource, like hugepage, cores. > > From our users, they prefer use the second 'telemetry', so I think we should move > more status-query-points to telemetry. > > As for this question, I think it's okay to get register info from telemetry. > > > > Another question, we have some internal registers, which: > 1. Is not suitable expose by xstats, because they may includes configuration > 2. Is not suitable expose by dumps, because this dumps is hard to understand (because it only has value). > > So we plan to add some telemetry points in the driver itself, so we could display them like xstats: > "xxxx" : 0x1234 > "yyyy" : 0x100 > > Will the community accept this kind of telemetry points which limit one driver ? > Hi Chengwen, I see there is a usecase/requirement. With this patch, even using file, only register values are dumped and isn't it hard to find value of specific register? ("xxxx" : 0x1234) approach looks better, but instead of making this telemetry support for specific driver, what about making it in two steps. First add new dev_ops, (or update existing one), to get registers with "name: value" format, (in a way to allow empty name), or even perhaps "name: offset, value" format. And in second stage add telemetry support around it. (Name being optional lets us wrap exiting 'get_reg' dev_ops with new one) When adding dev_ops, it may get an additional 'filter' parameter, to get only subset of regs, like "mac*" to get regs name staring with "mac", this may help for the cases there are too many registers you mentioned. Anyway, we can discuss more about its design, but what do you think about first having a dev_ops for this?