DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver
Date: Thu, 28 May 2020 09:35:54 +0800
Message-ID: <1e08074e-7ee7-e5b7-ed54-d23e053b3b03@huawei.com> (raw)
In-Reply-To: <4d71561e-f99e-c772-73a3-d0fbc73b72b1@intel.com>

Hi, Ferruh Yigit


On 2020/5/27 23:36, Ferruh Yigit wrote:
> On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
>> This series are improvement and bugfixes for hns3 PMD driver.
>>
>> Chengchang Tang (2):
>>    net/hns3: replace PF vport id zero with private macro
>>    net/hns3: fix promiscuous config not clear for PF on uninit
>>
>> Lijun Ou (2):
>>    net/hns3: add RSS hash offload to port Rx configuration
>>    net/hns3: fix key length when configuring RSS
>>
>> Wei Hu (Xavier) (1):
>>    net/hns3: fix preparing sending packets less than 60 bytes
>>
> Series applied to dpdk-next-net/master, thanks.
>
> A minor modification done [1] to fix 32-bit build error [2].
>
>
> [1]
> diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
> index e3c239286a..c7851b235c 100644
> --- a/drivers/net/hns3/hns3_flow.c
> +++ b/drivers/net/hns3/hns3_flow.c
> @@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,
>          if (rss_flow_conf.key_len &&
>              rss_flow_conf.key_len > RTE_DIM(rss_info->key)) {
>                  hns3_err(hw,
> -                       "input hash key(%u) greater than supported len(%lu)",
> +                       "input hash key(%u) greater than supported len(%zu)",
>                          rss_flow_conf.key_len, RTE_DIM(rss_info->key));
>                  return -EINVAL;
>          }
>
>
>
> [2]
> In file included from .../drivers/net/hns3/hns3_flow.c:12:
> .../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’:
> .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of
> type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=]
>     16 |  rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \
>        |                                      ^~~~~~~~~~~
> .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’
>     20 |  PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args)
>        |  ^~~~~~~~~~~~~~~
> .../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’
>   1480 |   hns3_err(hw,
>        |   ^~~~~~~~
> .../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here
>   1481 |    "input hash key(%u) greater than supported len(%lu)",
>        |                                                   ~~^
>        |                                                     |
>        |                                                     long unsigned int
>        |                                                   %u
> cc1: all warnings being treated as errors
>
>
   Thank you very much!
Xavier


      reply	other threads:[~2020-05-28  1:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  9:21 Wei Hu (Xavier)
2020-05-22  9:21 ` [dpdk-dev] [PATCH 1/5] net/hns3: replace PF vport id zero with private macro Wei Hu (Xavier)
2020-05-22  9:21 ` [dpdk-dev] [PATCH 2/5] net/hns3: fix promiscuous config not clear for PF on uninit Wei Hu (Xavier)
2020-05-22  9:21 ` [dpdk-dev] [PATCH 3/5] net/hns3: fix preparing sending packets less than 60 bytes Wei Hu (Xavier)
2020-05-22  9:21 ` [dpdk-dev] [PATCH 4/5] net/hns3: add RSS hash offload to port Rx configuration Wei Hu (Xavier)
2020-05-22  9:21 ` [dpdk-dev] [PATCH 5/5] net/hns3: fix key length when configuring RSS Wei Hu (Xavier)
2020-05-22 11:20 ` [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver Ferruh Yigit
2020-05-23  1:33   ` Wei Hu (Xavier)
2020-05-27 15:36 ` Ferruh Yigit
2020-05-28  1:35   ` Wei Hu (Xavier) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e08074e-7ee7-e5b7-ed54-d23e053b3b03@huawei.com \
    --to=xavier.huwei@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git