From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3506AA00BE; Thu, 28 May 2020 03:36:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E574E1DA93; Thu, 28 May 2020 03:36:02 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id A167E1DA7D for ; Thu, 28 May 2020 03:36:01 +0200 (CEST) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D7147F0924AD67D30E37 for ; Thu, 28 May 2020 09:35:59 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Thu, 28 May 2020 09:35:54 +0800 To: Ferruh Yigit , References: <1590139278-11046-1-git-send-email-xavier.huwei@huawei.com> <4d71561e-f99e-c772-73a3-d0fbc73b72b1@intel.com> From: "Wei Hu (Xavier)" Message-ID: <1e08074e-7ee7-e5b7-ed54-d23e053b3b03@huawei.com> Date: Thu, 28 May 2020 09:35:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <4d71561e-f99e-c772-73a3-d0fbc73b72b1@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh Yigit On 2020/5/27 23:36, Ferruh Yigit wrote: > On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote: >> This series are improvement and bugfixes for hns3 PMD driver. >> >> Chengchang Tang (2): >> net/hns3: replace PF vport id zero with private macro >> net/hns3: fix promiscuous config not clear for PF on uninit >> >> Lijun Ou (2): >> net/hns3: add RSS hash offload to port Rx configuration >> net/hns3: fix key length when configuring RSS >> >> Wei Hu (Xavier) (1): >> net/hns3: fix preparing sending packets less than 60 bytes >> > Series applied to dpdk-next-net/master, thanks. > > A minor modification done [1] to fix 32-bit build error [2]. > > > [1] > diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c > index e3c239286a..c7851b235c 100644 > --- a/drivers/net/hns3/hns3_flow.c > +++ b/drivers/net/hns3/hns3_flow.c > @@ -1478,7 +1478,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev, > if (rss_flow_conf.key_len && > rss_flow_conf.key_len > RTE_DIM(rss_info->key)) { > hns3_err(hw, > - "input hash key(%u) greater than supported len(%lu)", > + "input hash key(%u) greater than supported len(%zu)", > rss_flow_conf.key_len, RTE_DIM(rss_info->key)); > return -EINVAL; > } > > > > [2] > In file included from .../drivers/net/hns3/hns3_flow.c:12: > .../drivers/net/hns3/hns3_flow.c: In function ‘hns3_config_rss_filter’: > .../drivers/net/hns3/hns3_logs.h:16:38: error: format ‘%lu’ expects argument of > type ‘long unsigned int’, but argument 7 has type ‘unsigned int’ [-Werror=format=] > 16 | rte_log(level, hns3_logtype_driver, "%s %s(): " fmt, \ > | ^~~~~~~~~~~ > .../drivers/net/hns3/hns3_logs.h:20:2: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ > 20 | PMD_DRV_LOG_RAW(hw, RTE_LOG_ERR, fmt "\n", ## args) > | ^~~~~~~~~~~~~~~ > .../drivers/net/hns3/hns3_flow.c:1480:3: note: in expansion of macro ‘hns3_err’ > 1480 | hns3_err(hw, > | ^~~~~~~~ > .../drivers/net/hns3/hns3_flow.c:1481:53: note: format string is defined here > 1481 | "input hash key(%u) greater than supported len(%lu)", > | ~~^ > | | > | long unsigned int > | %u > cc1: all warnings being treated as errors > > Thank you very much！ Xavier