From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C35D0A00C3;
	Mon,  3 Oct 2022 15:20:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A288D40DFB;
	Mon,  3 Oct 2022 15:20:11 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id F343440695
 for <dev@dpdk.org>; Mon,  3 Oct 2022 15:20:09 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7FD1166;
 Mon,  3 Oct 2022 16:20:09 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7FD1166
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664803209;
 bh=gVVIj4D4sqPsZyhlJr3V3nLUFDx2ik72Du/L5PeZwuk=;
 h=Date:From:Subject:To:Cc:References:In-Reply-To:From;
 b=r7wlWbYr3QNkjcrQ0r9BXZGDlBjgYiE887h/ocgUSQoXGPuYob5WjC79s3SeUBpwN
 S4DGJFW+Pb82KfvDwJiXidZw2zzi5djZH4FBgT0e707JTPOjP/efrI66wwRjEYrKtH
 LNcI9SWPZZ9I1NxGZ73X67Kf9ZNw1JSjF5vaeR00=
Message-ID: <1e255749-e444-31cc-f62d-829036bff2c1@oktetlabs.ru>
Date: Mon, 3 Oct 2022 16:20:09 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v2 01/14] net/idpf/base: introduce base code
To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
 jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, xiao.w.wang@intel.com
References: <20220803113104.1184059-1-junfeng.guo@intel.com>
 <20220905105828.3190335-1-junfeng.guo@intel.com>
 <20220905105828.3190335-2-junfeng.guo@intel.com>
Content-Language: en-US
Organization: OKTET Labs
In-Reply-To: <20220905105828.3190335-2-junfeng.guo@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/5/22 13:58, Junfeng Guo wrote:
> Introduce base code for IDPF (Infrastructure Data Path Function) PMD.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>

I'm OK to import base driver in one patch, but it should not be
the first patch with dead code which is not actually built
just after the patch.

The first patch should add a driver stub which is built.
Subsequent patches should add base driver and functionality
to the ethdev driver itself.