From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5C5E3A0544;
	Mon, 10 Oct 2022 10:02:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1958740146;
	Mon, 10 Oct 2022 10:02:15 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 529DD40041;
 Mon, 10 Oct 2022 10:02:13 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B7B235E;
 Mon, 10 Oct 2022 11:02:12 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B7B235E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1665388932;
 bh=OtrG3MD+aWVOpiOfdyqTooSqfwvTLyw0yEyjnjilZ5U=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=vfwmzyKSvGjwdlWIWPRx0aADUD9qgXCdvyZUHa8mjgF8Ds3YNH5BCUAHsuXI5A8d3
 TXzRkOTDyA5mg9myDJRbf7YoDvBu4PyjyyPqqu5bgDOYx3iBUFvrHUIZPFsFYge4Ss
 gSCd31UF/Z8sMdvnZ+tDLQ1PGEFluwOU8UeDYeT8=
Message-ID: <1e4935f4-2fb0-7977-782d-1c47f3c57c5b@oktetlabs.ru>
Date: Mon, 10 Oct 2022 11:02:12 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] mempool: make event callbacks process-private
Content-Language: en-US
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
 Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Olivier Matz <olivier.matz@6wind.com>, "stable@dpdk.org" <stable@dpdk.org>
References: <20220808094236.3395516-1-dkozlyuk@nvidia.com>
 <20220808094236.3395516-2-dkozlyuk@nvidia.com>
 <DM6PR12MB37533C2613A8B63E9975700CDF779@DM6PR12MB3753.namprd12.prod.outlook.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <DM6PR12MB37533C2613A8B63E9975700CDF779@DM6PR12MB3753.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 8/28/22 21:33, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Sent: Monday, August 8, 2022 12:43
>> To: dev@dpdk.org
>> Cc: Olivier Matz <olivier.matz@6wind.com>; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; stable@dpdk.org
>> Subject: [PATCH 1/2] mempool: make event callbacks process-private
>>
>> Callbacks for mempool events were registered in a process-shared tailq.
>> This was inherently incorrect because the same function may be loaded to a
>> different address in each process.
>> Make the tailq process-private.
>> Use the EAL tailq lock to reduce the number of different locks this module
>> operates.
>>
>> Fixes: da2b9cb25e5f ("mempool: add event callbacks")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>