DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, allain.legacy@windriver.com,
	Steven Webster <steven.webster@windriver.com>,
	Matt Peters <matt.peters@windriver.com>,
	"Kilheeney, Louise" <louise.kilheeney@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning
Date: Thu, 12 Mar 2020 13:25:46 +0000	[thread overview]
Message-ID: <1e853b9f-fd91-42ef-dc0f-d834e510c6ef@intel.com> (raw)
In-Reply-To: <20200311113300.32487-1-ktraynor@redhat.com>

On 3/11/2020 11:32 AM, Kevin Traynor wrote:
> gcc 10.0.1 reports:
> 
> ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’:
> ../drivers/net/avp/avp_ethdev.c:1791:24:
> warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>  1791 |   tx_bufs[i] = avp_bufs[count];
>       |                ~~~~~~~~^~~~~~~
> ../drivers/net/avp/avp_ethdev.c:1791:24:
> warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Fix by intializing the array.
> 
> Fixes: 295abce2d25b ("net/avp: add packet transmit functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> v2: no change
> 
> note, commit log violates line length but I didn't want to split warning msg.
> 
> Cc: allain.legacy@windriver.com
> Cc: Steven Webster <steven.webster@windriver.com>
> Cc: Matt Peters <matt.peters@windriver.com>
> ---
>  drivers/net/avp/avp_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> index cd747b6be..1abe96ce5 100644
> --- a/drivers/net/avp/avp_ethdev.c
> +++ b/drivers/net/avp/avp_ethdev.c
> @@ -1695,5 +1695,5 @@ avp_xmit_scattered_pkts(void *tx_queue,
>  {
>  	struct rte_avp_desc *avp_bufs[(AVP_MAX_TX_BURST *
> -				       RTE_AVP_MAX_MBUF_SEGMENTS)];
> +				       RTE_AVP_MAX_MBUF_SEGMENTS)] = {};
>  	struct avp_queue *txq = (struct avp_queue *)tx_queue;
>  	struct rte_avp_desc *tx_bufs[AVP_MAX_TX_BURST];
> 

Isn't this a false positive, can there be any case 'avp_bufs[]' used
uninitialized? Or am I missing something.

If this is false positive, does it worth to report to issue to gcc?

  parent reply	other threads:[~2020-03-12 13:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  9:37 [dpdk-dev] [PATCH " Kevin Traynor
2020-02-20  9:37 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: " Kevin Traynor
2020-02-26  6:12   ` Akhil Goyal
2020-03-10 13:08   ` Ananyev, Konstantin
2020-03-10 18:52     ` Kevin Traynor
2020-03-10 19:03       ` Ananyev, Konstantin
2020-03-11 11:32 ` [dpdk-dev] [PATCH v2 1/2] net/avp: " Kevin Traynor
2020-03-11 11:33   ` [dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: " Kevin Traynor
2020-03-11 12:04     ` Ananyev, Konstantin
2020-05-06  9:18       ` David Marchand
2020-03-11 23:56   ` [dpdk-dev] [PATCH v2 1/2] net/avp: " Webster, Steven
2020-05-06  9:18     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-03-12 13:25   ` Ferruh Yigit [this message]
2020-03-12 14:18     ` [dpdk-dev] " Kevin Traynor
2020-03-12 14:31       ` Ferruh Yigit
2020-03-12 15:15         ` Kevin Traynor
2020-03-12 16:47           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e853b9f-fd91-42ef-dc0f-d834e510c6ef@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=allain.legacy@windriver.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=louise.kilheeney@intel.com \
    --cc=matt.peters@windriver.com \
    --cc=stable@dpdk.org \
    --cc=steven.webster@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).